Add static mapping for dynamodb metricset #17614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/integrations-platforms (Team:Platforms) |
ChrsMark
changed the title
|
@jsoriano I added dashboard changes in this PR, feel free to comment! |
|
Thanks! Some suggestions on the dashboard:
|
ChrsMark
force-pushed
the
mapping_aws_dynamodb
branch
from
691dbc8
to
bb65cc6
Compare
Signed-off-by: chrismark <chrismarkou92@gmail.com>
ChrsMark
force-pushed
the
mapping_aws_dynamodb
branch
from
bb65cc6
to
e4151dc
Compare
ChrsMark
changed the title
kaiyan-sheng
approved these changes
Apr 9, 2020
|
Tested and it works! Thanks for the help! |
kaiyan-sheng
reviewed
Apr 9, 2020
| Streams during the specified time period. | ||
| fields: | ||
| - name: avg | ||
| type: long |
There was a problem hiding this comment.
Should some of these metrics be double type? For example, in data.json aws.dynamodb.metrics.SuccessfulRequestLatency.avg = 1.6592021822660081
There was a problem hiding this comment.
+1, I think that most of the metrics here should be double.
There was a problem hiding this comment.
😬 nice catch, thank you both!
Signed-off-by: chrismark <chrismarkou92@gmail.com>
ChrsMark
added a commit
to ChrsMark/beats
that referenced
this pull request
Apr 14, 2020
* Add static mapping for dynamodb metricset Signed-off-by: chrismark <chrismarkou92@gmail.com> * Fix field types Signed-off-by: chrismark <chrismarkou92@gmail.com> (cherry picked from commit e023845)
ChrsMark
added a commit
to ChrsMark/beats
that referenced
this pull request
Apr 14, 2020
* Add static mapping for dynamodb metricset Signed-off-by: chrismark <chrismarkou92@gmail.com> * Fix field types Signed-off-by: chrismark <chrismarkou92@gmail.com> (cherry picked from commit e023845)
ChrsMark
added a commit
that referenced
this pull request
Apr 14, 2020
ChrsMark
added a commit
that referenced
this pull request
Apr 14, 2020
kaiyan-sheng
added a commit
that referenced
this pull request
Apr 29, 2020
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds static mappings for
awsdynamodbmetricset.Why is it important?
To avoid having breaking non TSVB visualisations when there no data in ES to create the respective fields with the dynamic mapping.