Fix tags for coredns/envoyproxy #19134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When {{ .tags }} is evaluated in the module config it not written in the correct format.
This fixes that issue and also conditionally enables `publisher_pipeline.disable_host`
based on whether tags contains `forwarded` to be consistent with every other module
that allows for `var.tags` to be set (relates: elastic#13920).
For example (https://play.golang.org/p/LUr-X94msd1):
var.tags: [foo, bar]
will be written into the config as
tags: [foo bar]
which is a single value array containing the string "foo bar" rather than two tags.
botelastic
bot
added
needs_team
|
Pinging @elastic/siem (Team:SIEM) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
|
run tests |
marc-gr
approved these changes
Jun 12, 2020
v1v
added a commit
to v1v/beats
that referenced
this pull request
Jun 15, 2020
…ngs-archive * upstream/master: Fix minor spelling error in Jenkinsfile (elastic#19153) [CI] fail if not possible to install python3 (elastic#19164) [Elastic Agent] Improved mage demo experience (elastic#18445) [yum] Clear cached data and add retry loop (elastic#19182) fix lint job by updating NOTICE (elastic#19161) Fix tags for coredns/envoyproxy (elastic#19134) Disable host.* fields by default for CrowdStrike module (elastic#19132) Allow host.* fields to be disabled in Zeek module (elastic#19113) Rename to management.Manager, add UpdateStatus to Manager interface. (elastic#19114) Edit Elastic Agent docs (elastic#19146) [JJBB] create job definition for the golang-crossbuild project (elastic#19162) Fix incorrect usage of hints builder when exposed port is a substring of the hint (elastic#19052) Add basic cloudfoundry integration tests (elastic#19018)
andrewkroh
added
the
needs_backport
andrewkroh
added a commit
to andrewkroh/beats
that referenced
this pull request
Jun 18, 2020
When {{ .tags }} is evaluated in the module config it not written in the correct format.
This fixes that issue and also conditionally enables `publisher_pipeline.disable_host`
based on whether tags contains `forwarded` to be consistent with every other module
that allows for `var.tags` to be set (relates: elastic#13920).
For example (https://play.golang.org/p/LUr-X94msd1):
var.tags: [foo, bar]
will be written into the config as
tags: [foo bar]
which is a single value array containing the string "foo bar" rather than two tags.
(cherry picked from commit b48c388)
6 tasks
andrewkroh
added
v7.9.0
and removed
needs_backport
andrewkroh
added a commit
that referenced
this pull request
Jun 26, 2020
When {{ .tags }} is evaluated in the module config it not written in the correct format.
This fixes that issue and also conditionally enables `publisher_pipeline.disable_host`
based on whether tags contains `forwarded` to be consistent with every other module
that allows for `var.tags` to be set (relates: #13920).
For example (https://play.golang.org/p/LUr-X94msd1):
var.tags: [foo, bar]
will be written into the config as
tags: [foo bar]
which is a single value array containing the string "foo bar" rather than two tags.
(cherry picked from commit b48c388)
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
When {{ .tags }} is evaluated in the module config it not written in the correct format.
This fixes that issue and also conditionally enables `publisher_pipeline.disable_host`
based on whether tags contains `forwarded` to be consistent with every other module
that allows for `var.tags` to be set (relates: elastic#13920).
For example (https://play.golang.org/p/LUr-X94msd1):
var.tags: [foo, bar]
will be written into the config as
tags: [foo bar]
which is a single value array containing the string "foo bar" rather than two tags.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When
{{ .tags }}is evaluated in the module config it not written in the correct format.This fixes that issue and also conditionally enables
publisher_pipeline.disable_hostbased on whether tags contains
forwardedto be consistent with every other modulethat allows for
var.tagsto be set (relates: #13920).For example (https://play.golang.org/p/LUr-X94msd1):
will be written into the config as
which is a single value array containing the string "foo bar" rather than two tags.
Why is it important?
If a user specified more than one tag in a module config then they would not have had the expect tags in their events.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues