Fix incorrect usage of hints builder when exposed port is a substring of the hint #19052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
botelastic
bot
added
the
needs_team
vjsamuel
force-pushed
the
correct_hints_usage
branch
from
6dd7beb
to
05187fe
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
|
jenkins run the tests please |
botelastic
bot
removed
the
needs_team
|
Pinging @elastic/siem (Team:SIEM) |
botelastic
bot
added
the
needs_team
jsoriano
reviewed
Jun 8, 2020
|
@ChrsMark could you also take a look to this change? Thanks! |
|
Pinging @elastic/integrations-platforms (Team:Platforms) |
botelastic
bot
removed
the
needs_team
vjsamuel
force-pushed
the
correct_hints_usage
branch
2 times, most recently
from
603aeeb
to
de74e23
Compare
|
ok to test |
|
jenkins run the tests please |
jsoriano
reviewed
Jun 9, 2020
vjsamuel
force-pushed
the
correct_hints_usage
branch
2 times, most recently
from
21efb1f
to
9070b0e
Compare
jsoriano
approved these changes
Jun 10, 2020
|
jenkins run the tests please |
jsoriano
added
v7.9.0
needs_backport
vjsamuel
force-pushed
the
correct_hints_usage
branch
from
9070b0e
to
6c07c5f
Compare
6 tasks
jsoriano
pushed a commit
to jsoriano/beats
that referenced
this pull request
Jun 12, 2020
… of the hint (elastic#19052) This PR makes sure that if a user exposes port 80 and has 8080 on the metric hint, then we don't use that port to do the autodiscover as the port could be exposed on another container. (cherry picked from commit 138a23a)
jsoriano
removed
the
needs_backport
v1v
added a commit
to v1v/beats
that referenced
this pull request
Jun 15, 2020
…ngs-archive * upstream/master: Fix minor spelling error in Jenkinsfile (elastic#19153) [CI] fail if not possible to install python3 (elastic#19164) [Elastic Agent] Improved mage demo experience (elastic#18445) [yum] Clear cached data and add retry loop (elastic#19182) fix lint job by updating NOTICE (elastic#19161) Fix tags for coredns/envoyproxy (elastic#19134) Disable host.* fields by default for CrowdStrike module (elastic#19132) Allow host.* fields to be disabled in Zeek module (elastic#19113) Rename to management.Manager, add UpdateStatus to Manager interface. (elastic#19114) Edit Elastic Agent docs (elastic#19146) [JJBB] create job definition for the golang-crossbuild project (elastic#19162) Fix incorrect usage of hints builder when exposed port is a substring of the hint (elastic#19052) Add basic cloudfoundry integration tests (elastic#19018)
jsoriano
added a commit
that referenced
this pull request
Jun 15, 2020
… of the hint (#19052) (#19163) This PR makes sure that if a user exposes port 80 and has 8080 on the metric hint, then we don't use that port to do the autodiscover as the port could be exposed on another container. (cherry picked from commit 138a23a) Co-authored-by: Vijay Samuel <vjsamuel@ebay.com>
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
… of the hint (elastic#19052) This PR makes sure that if a user exposes port 80 and has 8080 on the metric hint, then we don't use that port to do the autodiscover as the port could be exposed on another container.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change - Bug
What does this PR do?
This PR makes sure that if a user exposes port
80and has8080on the metric hint, then we dont use that port to do the autodiscover as the port could be exposed on another containerWhy is it important?
This is important as this impacts what container metadata gets appended to the metric.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
Related issues
Use cases