Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the downloadConfig and retryConfig from plugin/process.Application and plugin/service.Application. #19603

Merged
merged 2 commits into from
Jul 9, 2020

Conversation

blakerouse
Copy link
Contributor

What does this PR do?

Remove the downloadConfig and retryConfig from plugin/process.Application and plugin/service.Application.

Why is it important?

They are not used by either.

Checklist

  • My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label Team:Ingest Management labels Jul 2, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 2, 2020
@blakerouse blakerouse self-assigned this Jul 2, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 2, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #19603 updated]

  • Start Time: 2020-07-06T12:43:14.781+0000

  • Duration: 30 min 17 sec

Copy link
Contributor

@michalpristas michalpristas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also I'm working on a config change in 2 phases one of them will be refactor of how we handle configuration and some cleanup

@blakerouse blakerouse merged commit fb53a8a into elastic:master Jul 9, 2020
@blakerouse blakerouse deleted the agent-cleanup-app-cfgs branch July 9, 2020 14:18
blakerouse added a commit to blakerouse/beats that referenced this pull request Jul 9, 2020
…tion and plugin/service.Application. (elastic#19603)

* Remove the downloadConfig and retryConfig from plugin/process.Application and plugin/service.Application.

* Run mage fmt.

(cherry picked from commit fb53a8a)
v1v added a commit to v1v/beats that referenced this pull request Jul 9, 2020
* upstream/master:
  Add `docker logs` support to the Elastic Log Driver (elastic#19531)
  [Elastic Agent] Fix saving of agent configuration on Windows to have proper ACLs (elastic#19793)
  Send the config revision down to the endpoint application. (elastic#19759)
  [Elastic Agent] Add support for multiple hosts in connection to kibana (elastic#19628)
  Remove the downloadConfig and retryConfig from plugin/process.Application and plugin/service.Application. (elastic#19603)
  Update go version to 1.14.4 (elastic#19753)
  ci: set builds as skipped when they do not match the trigger (elastic#19750)
  [Auditbeat] Fix up socket dataset runaway CPU usage (elastic#19764)
  Convert cloudfoundry input to v2 (elastic#19717)
blakerouse added a commit that referenced this pull request Jul 9, 2020
…tion and plugin/service.Application. (#19603) (#19788)

* Remove the downloadConfig and retryConfig from plugin/process.Application and plugin/service.Application.

* Run mage fmt.

(cherry picked from commit fb53a8a)
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
…tion and plugin/service.Application. (elastic#19603)

* Remove the downloadConfig and retryConfig from plugin/process.Application and plugin/service.Application.

* Run mage fmt.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants