Convert cloudfoundry input to v2 #19717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urso
added
review
refactoring
Filebeat
|
Pinging @elastic/integrations (Team:Integrations) |
botelastic
bot
added
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
|
jsoriano
requested changes
Jul 8, 2020
urso
force-pushed
the
filebeat-cloudfoundr-input-v2
branch
from
653e900
to
dac4538
Compare
jsoriano
approved these changes
Jul 9, 2020
|
|
||
| func (i *inputV2) Test(_ v2.TestContext) error { | ||
| // XXX: try to connect, but don't consume | ||
| return nil |
There was a problem hiding this comment.
We can do the same test here as with v1.
| go func() { | ||
| c.wg.Add(1) |
urso
pushed a commit
to urso/beats
that referenced
this pull request
Jul 9, 2020
(cherry picked from commit b9cb9e4)
2 tasks
v1v
added a commit
to v1v/beats
that referenced
this pull request
Jul 9, 2020
* upstream/master: Add `docker logs` support to the Elastic Log Driver (elastic#19531) [Elastic Agent] Fix saving of agent configuration on Windows to have proper ACLs (elastic#19793) Send the config revision down to the endpoint application. (elastic#19759) [Elastic Agent] Add support for multiple hosts in connection to kibana (elastic#19628) Remove the downloadConfig and retryConfig from plugin/process.Application and plugin/service.Application. (elastic#19603) Update go version to 1.14.4 (elastic#19753) ci: set builds as skipped when they do not match the trigger (elastic#19750) [Auditbeat] Fix up socket dataset runaway CPU usage (elastic#19764) Convert cloudfoundry input to v2 (elastic#19717)
urso
pushed a commit
that referenced
this pull request
Jul 9, 2020
(cherry picked from commit b9cb9e4)
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Move cloudfoundry input to v2 input API
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas~~- [ ] I have made corresponding changes to the documentation~~~~
- [ ] I have made corresponding change to the default configuration files- [ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
Related issues