Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #21993 to 7.x: [Filebeat] Add max_number_of_messages config parameter for S3 input #22035

Merged
merged 2 commits into from
Oct 22, 2020
Merged

Cherry-pick #21993 to 7.x: [Filebeat] Add max_number_of_messages config parameter for S3 input #22035

merged 2 commits into from
Oct 22, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Oct 20, 2020

Cherry-pick of PR #21993 to 7.x branch. Original message:

What does this PR do?

This PR adds max_number_of_messages config option for S3 input to control the number of SQS messages returning from each ReceiveMessage API call.

Why is it important?

This will help to debug performance issues since this controls how many messages returned once and how many log files will be processed in parallel together.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@kaiyan-sheng kaiyan-sheng added [zube]: In Review backport Team:Platforms Label for the Integrations - Platforms team labels Oct 20, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 20, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 20, 2020
@kaiyan-sheng kaiyan-sheng self-assigned this Oct 20, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 20, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22035 updated]

  • Start Time: 2020-10-21T13:31:23.730+0000

  • Duration: 73 min 4 sec

Test stats 🧪

Test Results
Failed 0
Passed 1947
Skipped 259
Total 2206

@@ -717,6 +717,8 @@ field. You can revert this change by configuring tags for the module and omittin
- New juniper.srx dataset for Juniper SRX logs. {pull}20017[20017]
- Adding support for Microsoft 365 Defender (Microsoft Threat Protection) {pull}21446[21446]
- Adding support for FIPS in s3 input {pull}21446[21446]
- Add SSL option to checkpoint module {pull}19560[19560]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙂

@kaiyan-sheng kaiyan-sheng merged commit fe4bbd8 into elastic:7.x Oct 22, 2020
@kaiyan-sheng kaiyan-sheng deleted the backport_21993_7.x branch October 22, 2020 13:27
@zube zube bot removed the [zube]: Done label Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants