Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #23229 to 7.x: [Heartbeat] Enable script processor #23768

Merged
merged 1 commit into from Jan 29, 2021

Conversation

andrewvc
Copy link
Contributor

@andrewvc andrewvc commented Jan 29, 2021

Cherry-pick of PR #23229 to 7.x branch. Original message:

Enables the script processor for heartbeat. This is an opt-in processor, but there's really never been a concrete need for that. This fixes #22788 .

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

Add a script section to the processors block, it will work!

Use cases

Mostly useful for situations where people want to apply novel complex logic. See #22788

Enables the script processor for heartbeat. This is an opt-in processor, but there's really never been a concrete need for that. This fixes elastic#22788 .

(cherry picked from commit b89e5d6)
@andrewvc andrewvc requested a review from a team as a code owner January 29, 2021 21:34
@andrewvc andrewvc added [zube]: In Review backport Team:obs-ds-hosted-services Label for the Observability Hosted Services team labels Jan 29, 2021
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 29, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime (Team:Uptime)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jan 29, 2021
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport looks good.

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23768 opened

    • Start Time: 2021-01-29T21:35:15.821+0000
  • Duration: 30 min 32 sec

  • Commit: 27678dd

Test stats 🧪

Test Results
Failed 0
Passed 3144
Skipped 76
Total 3220

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 3144
Skipped 76
Total 3220

@andrewvc andrewvc merged commit 82da952 into elastic:7.x Jan 29, 2021
@andrewvc andrewvc deleted the backport_23229_7.x branch January 29, 2021 22:11
@zube zube bot removed the [zube]: Done label Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:obs-ds-hosted-services Label for the Observability Hosted Services team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants