Update float, half_float and scaled_float mappings #2430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
force-pushed
the
verify-fields
branch
from
5cd7c3f
to
97d930f
Compare
| }, | ||
| "requests_per_sec": 0.0119197, | ||
| "requests_per_sec": 0.00331858, |
There was a problem hiding this comment.
This will be rounded to 3 digits in elasticsearch which I think is fine. @tsg WDYT?
Merged
| @@ -1687,15 +1687,15 @@ Number of requested checkpoints that have been performed. | |||
| [float] | |||
| === postgresql.bgwriter.checkpoints.times.write.ms | |||
|
|
|||
| type: float | |||
| type: scaled_float | |||
There was a problem hiding this comment.
I'd leave these as floats because they are the total (not the derivative) number of milliseconds, so if you have an instance running for a year these numbers can be huge. Since float is what Postgres uses to report them, I'd say it's safer for us to also use floats to avoid overflows.
|
Left two comments, otherwise LGTM. |
ruflin
force-pushed
the
verify-fields
branch
from
97d930f
to
97e2106
Compare
|
@tsg new version pushed with the adjustments to postgres. |
* The mappings for float, half_float and scaled_float were reviewed and adjusted * All integers were converted to long as this was already happening automatically in the script * Json examples updated Closes elastic#2238
ruflin
force-pushed
the
verify-fields
branch
from
97e2106
to
649ebbb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2238