Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Packetbeat] Add url.extension to Packetbeat HTTP events #25999

Merged
merged 4 commits into from
Jun 15, 2021
Merged

[Packetbeat] Add url.extension to Packetbeat HTTP events #25999

merged 4 commits into from
Jun 15, 2021

Conversation

legoguy1000
Copy link
Contributor

@legoguy1000 legoguy1000 commented May 29, 2021 •
edited
Loading

What does this PR do?

Add url.extension to Packetbeat HTTP events

Why is it important?

Adds additional field per ECS spec that can be used for correlation and ML.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 29, 2021
@legoguy1000 legoguy1000 marked this pull request as ready for review May 29, 2021 21:43
@legoguy1000 legoguy1000 requested a review from a team as a code owner May 29, 2021 21:43
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 29, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #25999 updated

  • Start Time: 2021-06-14T19:45:21.798+0000

  • Duration: 90 min 45 sec

  • Commit: 9bee3c3

Test stats 🧪

Test Results
Failed 0
Passed 4933
Skipped 45
Total 4978

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 4933
Skipped 45
Total 4978

@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label May 31, 2021
@jamiehynds jamiehynds added enhancement needs_team Indicates that the issue/PR needs a Team:* label labels May 31, 2021
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label May 31, 2021
@botelastic
Copy link

botelastic bot commented May 31, 2021

This pull request doesn't have a Team:<team> label.

@P1llus
Copy link
Member

P1llus commented Jun 3, 2021

run tests

@legoguy1000 legoguy1000 mentioned this pull request Jun 4, 2021
Closed
@P1llus
Copy link
Member

P1llus commented Jun 7, 2021

run tests

@andrewkroh andrewkroh added the backport-v7.14.0 Automated backport with mergify label Jun 15, 2021
@andrewkroh andrewkroh merged commit 3d341a8 into elastic:master Jun 15, 2021
@andrewkroh
Copy link
Member

Thanks @legoguy1000

mergify bot pushed a commit that referenced this pull request Jun 15, 2021
@legoguy1000
[Packetbeat] Add url.extension to Packetbeat HTTP events (#25999)
7fbda4a 
* #25990: Add `url.extension` to Packetbeat HTTP events

* update changelog

* add tests

* updated per comment

(cherry picked from commit 3d341a8)
@mergify mergify bot mentioned this pull request Jun 15, 2021
Merged
andrewkroh pushed a commit that referenced this pull request Jun 15, 2021
@mergify @legoguy1000
[Packetbeat] Add url.extension to Packetbeat HTTP events (#25999) (#…
563b84f 
…26326)

* #25990: Add `url.extension` to Packetbeat HTTP events

* update changelog

* add tests

* updated per comment

(cherry picked from commit 3d341a8)

Co-authored-by: Alex Resnick <adr8292@gmail.com>
michalpristas pushed a commit to michalpristas/beats that referenced this pull request Jun 17, 2021
@legoguy1000 @michalpristas
[Packetbeat] Add url.extension to Packetbeat HTTP events (elastic#2…
2d8b720 
…5999)

* elastic#25990: Add `url.extension` to Packetbeat HTTP events

* update changelog

* add tests

* updated per comment
@legoguy1000 legoguy1000 deleted the 25990-packetbeat-url branch June 19, 2021 18:51
mdelapenya added a commit to mdelapenya/beats that referenced this pull request Jun 21, 2021
@mdelapenya
Merge branch 'master' into archive-system-tests
ead2f67 
* master: (25 commits)
  Fix UBI source URL (elastic#26384)
  Skip test_rotating_file in osx and windows (elastic#26379)
  Remove outdated k8s manifests for managed elastic-agent (elastic#26368)
  Enable agent to send custom headers to kibana/ES (elastic#26275)
  [Automation] Update elastic stack version to 8.0.0-943ef2c0 for testing (elastic#26354)
  Make the Syslog input GA (elastic#26293)
  Move Kerberos FAST config flag to shared kerberos config (elastic#26141)
  Add k8s cluster identifiers (elastic#26056)
  Store message from MongoDB json logs in message field (elastic#26338)
  update threatintel ECS version (elastic#26274)
  update envoyproxy ECS version (elastic#26277)
  [Filebeat] [MongoDB] Support MongoDB 4.4 json logs (elastic#24774)
  Update go-structform to 0.0.9 (elastic#26251)
  Forward port 7.13.2 changelog to master (elastic#26323)
  Updated filter expression for filtering 86 artifacts (elastic#26313)
  Osquerybeat: Align with the rest of the beats, set the ECS version (elastic#26324)
  [Packetbeat] Add `url.extension` to Packetbeat HTTP events (elastic#25999)
  Change link to snapshots in README (elastic#26317)
  Don't include full ES index template in errors (elastic#25743)
  First refactor of the system module - system/cpu and system/core (elastic#25771)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees
No one assigned
Labels
backport-v7.14.0 Automated backport with mergify enhancement Packetbeat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add url.extension to Packetbeat
5 participants
@legoguy1000 @elasticmachine @P1llus @andrewkroh @jamiehynds