Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): use the right param type #26469

Merged
merged 1 commit into from Jun 24, 2021
Merged

Conversation

mdelapenya
Copy link
Contributor

@mdelapenya mdelapenya commented Jun 24, 2021

What does this PR do?

It uses the right param type (string instead of boolean) when triggering the e2e job after a wrong copy&paste.

Why is it important?

Jenkins, as expected, is honouring the param type used in the caller, but not honouring the type in the triggered pipeline. This issue has historical rationale, as the parameters are created dynamically.

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Jenkins, as expected, is honouring the param type used in the caller, but
not honouring the type in the triggered pipeline. This issue has historical
rationale, as the parameters are created dynamically
@mdelapenya mdelapenya self-assigned this Jun 24, 2021
@mdelapenya mdelapenya added the Team:Automation Label for the Observability productivity team label Jun 24, 2021
@mdelapenya mdelapenya requested a review from a team June 24, 2021 12:20
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 24, 2021
@mdelapenya mdelapenya added backport-v7.13.0 Automated backport with mergify backport-v7.14.0 Automated backport with mergify labels Jun 24, 2021
@mdelapenya mdelapenya marked this pull request as ready for review June 24, 2021 12:21
@mdelapenya mdelapenya changed the title fix: use the right param type fix(ci): use the right param type Jun 24, 2021
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #26469 opened

  • Start Time: 2021-06-24T12:20:16.556+0000

  • Duration: 14 min 15 sec

  • Commit: f599755

Trends 🧪

Image of Build Times

❕ Flaky test report

No test was executed to be analysed.

@mdelapenya mdelapenya merged commit f429a82 into elastic:master Jun 24, 2021
mergify bot pushed a commit that referenced this pull request Jun 24, 2021
Jenkins, as expected, is honouring the param type used in the caller, but
not honouring the type in the triggered pipeline. This issue has historical
rationale, as the parameters are created dynamically

(cherry picked from commit f429a82)

# Conflicts:
#	.ci/packaging.groovy
mergify bot pushed a commit that referenced this pull request Jun 24, 2021
Jenkins, as expected, is honouring the param type used in the caller, but
not honouring the type in the triggered pipeline. This issue has historical
rationale, as the parameters are created dynamically

(cherry picked from commit f429a82)

# Conflicts:
#	.ci/packaging.groovy
mdelapenya added a commit to mdelapenya/beats that referenced this pull request Jun 28, 2021
* master: (32 commits)
  [Metricbeat] Change Account ID to Project ID in `gcp.billing` module (elastic#26412)
  update libbeat fields.ecs.yml file and ecsVersion to 1.10.0 (elastic#26121)
  [Filebeat] Update AWS ELB ingest pipeline (elastic#26441)
  [FIlebeat] add strict_date_optional_time_nanos date format to PanOS module (elastic#26158)
  Fix the irregular and typo on prometheus module. (elastic#25726)
  [Filebeat] Parse additonal debug data fields for Okta module (elastic#25818)
  fix: update MSSQL Server linux image's Docker registry (elastic#26440)
  Update indexing.go godocs (elastic#26408)
  Do not close filestream harvester if an unexpected error is returned when close.on_state_change.* is enabled (elastic#26411)
  Add support for copytruncate method when rotating input logs with an external tool in `filestream` input (elastic#23457)
  Allow fields with ip_range datatype (elastic#26444)
  Add Anomali ThreatStream support to threatintel module (elastic#26350)
  fix: use the right param type (elastic#26469)
  [Automation] Update elastic stack version to 8.0.0-7640093f for testing (elastic#26460)
  Set SM Filebeat modules as GA (elastic#26226)
  Fix rfc5464 date parsing in the syslog input (elastic#26419)
  Add linked account information into billing metricset (elastic#26285)
  [Filebeat] Update HA Proxy log grok patterns (elastic#25835)
  disable metricbeat logstash test_node_stats (elastic#26436)
  chore: pass BEAT_VERSION when running E2E tests (elastic#26291)
  ...
v1v added a commit that referenced this pull request Jul 14, 2021
Jenkins, as expected, is honouring the param type used in the caller, but
not honouring the type in the triggered pipeline. This issue has historical
rationale, as the parameters are created dynamically

(cherry picked from commit f429a82)

# Conflicts:
#	.ci/packaging.groovy

Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>
Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
v1v added a commit that referenced this pull request Jul 14, 2021
Jenkins, as expected, is honouring the param type used in the caller, but
not honouring the type in the triggered pipeline. This issue has historical
rationale, as the parameters are created dynamically

(cherry picked from commit f429a82)

# Conflicts:
#	.ci/packaging.groovy

Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>
Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
@v1v
Copy link
Member

v1v commented Jul 14, 2021

@Mergifyio backport 7.14

mergify bot pushed a commit that referenced this pull request Jul 14, 2021
Jenkins, as expected, is honouring the param type used in the caller, but
not honouring the type in the triggered pipeline. This issue has historical
rationale, as the parameters are created dynamically

(cherry picked from commit f429a82)

# Conflicts:
#	.ci/packaging.groovy
@mergify
Copy link
Contributor

mergify bot commented Jul 14, 2021

Command backport 7.14: success

Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.13.0 Automated backport with mergify backport-v7.14.0 Automated backport with mergify Team:Automation Label for the Observability productivity team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants