[Filebeat] adding base64encode func to value template #27681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P1llus
added
Filebeat
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
botelastic
bot
added
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
|
LGTM, However, I think we should add the option to output non-padded base64 (RawStdEncoding), it may be necessary in some cases. Something like There's also URLEncoding, don't know how frequent that is used. |
marc-gr
approved these changes
Sep 2, 2021
Co-authored-by: Marc Guasch <marc-gr@users.noreply.github.com>
mergify bot
pushed a commit
that referenced
this pull request
Sep 3, 2021
* adding base64encode func to value template * add docs and changelog * Update x-pack/filebeat/input/httpjson/internal/v2/value_tpl.go Co-authored-by: Marc Guasch <marc-gr@users.noreply.github.com> * adding comments from PR Co-authored-by: Marc Guasch <marc-gr@users.noreply.github.com> (cherry picked from commit bf7103c)
P1llus
added a commit
that referenced
this pull request
Sep 3, 2021
* adding base64encode func to value template * add docs and changelog * Update x-pack/filebeat/input/httpjson/internal/v2/value_tpl.go Co-authored-by: Marc Guasch <marc-gr@users.noreply.github.com> * adding comments from PR Co-authored-by: Marc Guasch <marc-gr@users.noreply.github.com> (cherry picked from commit bf7103c) Co-authored-by: Marius Iversen <marius.iversen@elastic.co>
Icedroid
pushed a commit
to Icedroid/beats
that referenced
this pull request
Nov 1, 2021
* adding base64encode func to value template * add docs and changelog * Update x-pack/filebeat/input/httpjson/internal/v2/value_tpl.go Co-authored-by: Marc Guasch <marc-gr@users.noreply.github.com> * adding comments from PR Co-authored-by: Marc Guasch <marc-gr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adds base64encode functionality for value templates in httpjson input.
Why is it important?
Adds new functionality to httpjson input.
Adding possibility for
.requestand.headercomes in a separate PR.Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues