Update sarama to master + SASL fix #2798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urso
commented
Oct 18, 2016
urso
commented
- based on v1.10.1
- master:
- fixes bug in in v0.10 protocol if compression is enabled (default)
- introduces broker metrics
- SASL/plain included
- Add support kafka 0.10.0.1 version string to valid libbeat kafka settings
- Hook up sarama kafka metrics (go-metrics introduces endpoint debug/metrics)
added 3 commits
October 18, 2016 15:40
- based on v1.10.1 - master: - fixes bug in in v0.10 protocol if compression is enabled (default) - introduces broker metrics - SASL/plain included
urso
added
review
needs_backport
tsg
reviewed
Oct 18, 2016
| reg := metrics.NewPrefixedRegistry("libbeat.kafka.") | ||
|
|
||
| // Note: registers /debug/metrics handler for displaying all expvar counters | ||
| exp.Exp(reg) |
There was a problem hiding this comment.
Will that also include our other expvars under /debug/metrics? If yes, it's kind of strange to register them here, right?
There was a problem hiding this comment.
Yes, debug/metrics will display all expvars.
urso
pushed a commit
to urso/beats
that referenced
this pull request
Oct 18, 2016
* Update sarama to master + SASL fix - based on v1.10.1 - master: - fixes bug in in v0.10 protocol if compression is enabled (default) - introduces broker metrics - SASL/plain included * Add kafka 0.10.0.1 version string to config * Hook up sarama kafka metrics
tsg
pushed a commit
that referenced
this pull request
Oct 19, 2016
* Update sarama to master + SASL fix - based on v1.10.1 - master: - fixes bug in in v0.10 protocol if compression is enabled (default) - introduces broker metrics - SASL/plain included * Add kafka 0.10.0.1 version string to config * Hook up sarama kafka metrics
|
Fixes #2651 |
|
Fixes #2717 |
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
* Update sarama to master + SASL fix - based on v1.10.1 - master: - fixes bug in in v0.10 protocol if compression is enabled (default) - introduces broker metrics - SASL/plain included * Add kafka 0.10.0.1 version string to config * Hook up sarama kafka metrics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.