Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metricbeat] gcp: fix integration tests #28364

Merged
merged 5 commits into from
Oct 13, 2021
Merged

[Metricbeat] gcp: fix integration tests #28364

merged 5 commits into from
Oct 13, 2021

Conversation

endorama
Copy link
Member

@endorama endorama commented Oct 12, 2021 •
edited

What does this PR do?

Provide fixes for gcp metricbeat module integration tests.

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

How to test this PR locally

TEST_TAGS=gcp MODULE=gcp mage goIntegTest

Related issues

Use cases

Screenshots

Logs

@endorama endorama added Team:Integrations Label for the Integrations team backport-v7.16.0 Automated backport with mergify ci labels Oct 12, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 12, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 12, 2021 •
edited by jenkins-beats-ci bot

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-13T07:53:46.177+0000

  • Duration: 152 min 58 sec

  • Commit: e4fcab7

Test stats 🧪

Test Results
Failed 0
Passed 53548
Skipped 5323
Total 58871

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

@mergify
Copy link
Contributor

mergify bot commented Oct 13, 2021

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b gcp/fix-ci upstream/gcp/fix-ci
git merge upstream/master
git push upstream gcp/fix-ci

@endorama
ci: whitelist GCP_* env vars
d8642d7 
GCP SDK require GCP_* based variable for a correct initialization.
In our tests for GCP module we require GCP_PROJECT_ID and
GCP_CREDENTIALS_FILE_PATH to be set.
@endorama
gcp.billing: add billing build tag
c1bc43f 
GCP Billing tests require access to the billing account. This access is
restricted and will not be granted to everyone working on beats.

In order to be able to run integration tests without a always-failing
gcp.billing tests, adding this tag allow to skip billing tests unless
specified.
@endorama
gcp: document running integration tests
b6065ef
@endorama
gcp.billing: fix testing metricset initialization
0e4e610
@endorama
update CHANGELOG-developer.next
e4fcab7
@endorama endorama mentioned this pull request Oct 13, 2021
Merged
6 tasks
@endorama endorama merged commit e8066e9 into elastic:master Oct 13, 2021
@endorama endorama deleted the gcp/fix-ci branch October 13, 2021 10:48
mergify bot pushed a commit that referenced this pull request Oct 13, 2021
@endorama
[Metricbeat] gcp: fix integration tests (#28364)
0edcc3e 
(cherry picked from commit e8066e9)

# Conflicts:
#	x-pack/metricbeat/module/gcp/DEVELOPMENT.md
#	x-pack/metricbeat/module/gcp/billing/billing_integration_test.go
@mergify mergify bot mentioned this pull request Oct 13, 2021
Merged
endorama added a commit that referenced this pull request Oct 13, 2021
@endorama
[Metricbeat] gcp: fix integration tests (#28364)
f9d6842
endorama added a commit that referenced this pull request Oct 13, 2021
@endorama
[Metricbeat] gcp: fix integration tests (#28364)
4bcc6c9 
(cherry picked from commit e8066e9)
endorama added a commit that referenced this pull request Oct 14, 2021
@endorama
[Metricbeat] gcp: fix integration tests (#28364)
c611e59 
(cherry picked from commit e8066e9)
endorama added a commit that referenced this pull request Oct 14, 2021
@mergify @endorama
[7.x](backport #28364) [Metricbeat] gcp: fix integration tests (#28390)
4a080bf 
Co-authored-by: endorama <526307+endorama@users.noreply.github.com>
Icedroid pushed a commit to Icedroid/beats that referenced this pull request Nov 1, 2021
@endorama
[Metricbeat] gcp: fix integration tests (elastic#28364)
5a07557
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

Assignees
No one assigned
Labels
backport-v7.16.0 Automated backport with mergify ci Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@endorama @elasticmachine @kaiyan-sheng