[Oracle Module] Change tablespace metricset collection period

[yug-rajani]

• Enhancement

What does this PR do?

This PR enhances the Oracle Metricbeat Module to set the default value of the collection period for the tablespace metricset as 10 minutes. In addition to that, it also adds a condition to warn users if they change the collection frequency to be less than 60 seconds.

Why is it important?

Oracle DBAs typically look at the growth or reduction of their table space and disk space over long periods of time. It's just wasted performance and overkill to pull those statistics every 10 seconds. It is important so that users don’t accidentally impact their databases, don’t waste cycles/resources and witness performance issues as the first impression.

Checklist

• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have made corresponding change to the default configuration files
• I have added tests that prove my fix is effective or that my feature works
• I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

• Closes [Oracle Module] Change tablespace metricset collection period #30948

[elasticmachine]

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Start Time: 2022-04-15T08:58:06.316+0000

• Duration: 71 min 42 sec

Test stats 🧪

Test	Results
Failed	0
Passed	3875
Skipped	997
Total	4872

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

• /test : Re-trigger the build.

• /package : Generate the packages and run the E2E tests.

• /beats-tester : Run the installation tests with beats-tester.

• run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

[yug-rajani]

We noticed that linting tests are failing because of the old code of the Oracle module which we haven't touched as a part of our task.
Found CI failures because of deprecated packages and others are because the linting tests might have been introduced at a later stage after this package was pushed.
It would not be possible to get the PR merged without resolving these issues.

[cmacknz]

Fixing the lint errors here should be straightforward. Here's a patch with the necessary changes (I don't think I can push this to your branch):

diff --git a/x-pack/metricbeat/module/oracle/tablespace/data_test.go b/x-pack/metricbeat/module/oracle/tablespace/data_test.go
index 8fa58514bb..54ee24e619 100644
--- a/x-pack/metricbeat/module/oracle/tablespace/data_test.go
+++ b/x-pack/metricbeat/module/oracle/tablespace/data_test.go
@@ -6,7 +6,6 @@ package tablespace
 
 import (
 	"context"
-	"fmt"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
@@ -28,7 +27,7 @@ func TestEventMapping(t *testing.T) {
 	events, err := m.extractAndTransform(context.Background())
 	assert.NoError(t, err)
 
-	fmt.Printf("Total %d events\n", len(events))
+	t.Logf("Total %d events\n", len(events))
 
 	t.Run("Happy Path", func(t *testing.T) {
 		for _, event := range events {
diff --git a/x-pack/metricbeat/module/oracle/tablespace/metricset.go b/x-pack/metricbeat/module/oracle/tablespace/metricset.go
index 8fec8fd0a7..478fe9d2bd 100644
--- a/x-pack/metricbeat/module/oracle/tablespace/metricset.go
+++ b/x-pack/metricbeat/module/oracle/tablespace/metricset.go
@@ -6,8 +6,7 @@ package tablespace
 
 import (
 	"context"
-
-	"github.com/pkg/errors"
+	"fmt"
 
 	"github.com/elastic/beats/v7/metricbeat/mb"
 	"github.com/elastic/beats/v7/x-pack/metricbeat/module/oracle"
@@ -37,7 +36,7 @@ type MetricSet struct {
 func New(base mb.BaseMetricSet) (mb.MetricSet, error) {
 	config := oracle.ConnectionDetails{}
 	if err := base.Module().UnpackConfig(&config); err != nil {
-		return nil, errors.Wrap(err, "error parsing config file")
+		return nil, fmt.Errorf("error parsing config file: %w", err)
 	}
 
 	return &MetricSet{
@@ -52,7 +51,7 @@ func New(base mb.BaseMetricSet) (mb.MetricSet, error) {
 func (m *MetricSet) Fetch(ctx context.Context, reporter mb.ReporterV2) (err error) {
 	db, err := oracle.NewConnection(&m.connectionDetails)
 	if err != nil {
-		return errors.Wrap(err, "error creating connection to Oracle")
+		return fmt.Errorf("error creating connection to Oracle: %w", err)
 	}
 	defer db.Close()
 
@@ -60,12 +59,12 @@ func (m *MetricSet) Fetch(ctx context.Context, reporter mb.ReporterV2) (err erro
 
 	events, err := m.extractAndTransform(ctx)
 	if err != nil {
-		return errors.Wrap(err, "error getting or interpreting data from Oracle")
+		return fmt.Errorf("error getting or interpreting data from Oracle: %w", err)
 	}
 
 	m.Load(ctx, events, reporter)
 
-	return
+	return err
 }
 
 //Load is the L of an ETL. In this case, takes the events and sends them to Elasticseach

[yug-rajani]

Thanks, @cmacknz! I have pushed the changes and the pipeline is green. What we were mainly concerned about was the inconsistency that might be caused if we update the files modified as a part of this PR and leave the other files of the Oracle module unchanged. We discussed the same with the team, and I guess that's the way the new step in the CI aims to improve the existing codebase in new PR's.

[mtojek]

@yug-elastic Could you please add a changelog.next entry for this PR?

[yug-rajani]

@yug-elastic Could you please add a changelog.next entry for this PR?

Sure, added it. Please verify.

[mtojek]

LGTM

[masci]

approving in behalf of codeowners group