Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md for Metricbeat on K8s #33308

Merged
merged 10 commits into from
Oct 18, 2022
Merged

Update README.md for Metricbeat on K8s #33308

merged 10 commits into from
Oct 18, 2022

Conversation

constanca-m
Copy link
Contributor

@constanca-m constanca-m commented Oct 11, 2022

What does this PR do?

Updated README.md file for Metricbeat on Kubernetes to explain to the user how to run Metricbeat locally or on cloud.

Why is it important?

The updated file makes clear to the user how to run Metricbeat on Kubernetes.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • Test example on kind and on GKE

@constanca-m constanca-m added review Metricbeat Metricbeat Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team labels Oct 11, 2022
@constanca-m constanca-m requested review from a team as code owners October 11, 2022 13:22
@constanca-m constanca-m requested review from fearful-symmetry and faec and removed request for a team October 11, 2022 13:22
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 11, 2022
@mergify
Copy link
Contributor

mergify bot commented Oct 11, 2022

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @constanca-m? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 11, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-10-18T10:35:50.725+0000

  • Duration: 8 min 22 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

CHANGELOG.next.asciidoc Outdated Show resolved Hide resolved
deploy/kubernetes/metricbeat/README.md Outdated Show resolved Hide resolved
deploy/kubernetes/metricbeat/README.md Show resolved Hide resolved
deploy/kubernetes/metricbeat/README.md Outdated Show resolved Hide resolved
deploy/kubernetes/metricbeat/README.md Outdated Show resolved Hide resolved
@constanca-m constanca-m merged commit 8ce9ffa into elastic:main Oct 18, 2022
@constanca-m constanca-m deleted the add-readme-mb-k8s branch October 18, 2022 12:03
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
* Update README.md for Metricbeat on K8s

* Update README.md for Metricbeat on K8s

* Clarified README.md for Metricbeat on K8s

* Deleted HTML in README.md for Metricbeat on K8s

* Apply suggestions from code review

* Align table

* Align table

Co-authored-by: Giuseppe Santoro <giuseppe.santoro@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Metricbeat Metricbeat review Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants