packaging: staging artifacts with DEV=false

[v1v]

What does this PR do?

reduce the size of the Beats and Agent release artifacts, possible significantly. It should also lead to a small increase in efficiency.

Why

Setting DEV=true includes debug symbols in the released binary and disabled most build optimizations. Unrequired for releases

[cmacknz]

Which specific builds are staging? Release branches?

[v1v]

the release function is called when generating the binaries, if a branch then it uses staging otherwise snapshot.

See

beats/.ci/packaging.groovy

Lines 289 to 307 in e8df5e9

	release('snapshot')
	dir("${BASE_DIR}"){
	pushCIDockerImages(arch: 'amd64')
	}
	}
	prepareE2ETestForPackage("${beat}")
	// Staging is only needed from branches (main or release branches)
	if (isBranch()) {
	// As long as we reuse the same worker to package more than
	// once, the workspace gets corrupted with some permissions
	// therefore let's reset the workspace to a new location
	// in order to reuse the worker and successfully run the package
	def work = "workspace/${env.JOB_BASE_NAME}-${env.BUILD_NUMBER}-staging"
	ws(work) {
	withEnv(["HOME=${env.WORKSPACE}"]) {
	deleteDir()
	release('staging')
	}

[elasticmachine]

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Start Time: 2022-11-09T14:38:00.716+0000

• Duration: 12 min 26 sec

Test stats 🧪

Test	Results
Failed	0
Passed	3
Skipped	0
Total	3

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

• /test : Re-trigger the build.

• /package : Generate the packages and run the E2E tests.

• /beats-tester : Run the installation tests with beats-tester.

• run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

[cmacknz]

I actually think it is worth adding a changelog entry for this.

Probably adding something like "Re-enable build optimizations to reduce binary size and improve performance" in the bugfix section affecting all Beats: https://github.com/elastic/beats/blob/main/CHANGELOG.next.asciidoc#bugfixes

[v1v]

/package