[metricbeat] [gcp] remove compute metadata cache #33655

gpop63 · 2022-11-11T17:12:00Z

What does this PR do?

Removes compute metadata cache.

Why is it important?

Checklist

My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have made corresponding change to the default configuration files
I have added tests that prove my fix is effective or that my feature works
I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

[ ]

How to test this PR locally

Related issues

Closes: GCP metadata instance cache is never refreshed but also never used #32734

Use cases

Screenshots

Logs

mergify · 2022-11-11T17:12:37Z

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @gpop63? 🙏.
For such, you'll need to label your PR with:

The upcoming major version of the Elastic Stack
The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

elasticmachine · 2022-11-11T18:07:57Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-12-05T19:27:56.062+0000
Duration: 54 min 23 sec

Test stats 🧪

Test	Results
Failed	0
Passed	1392
Skipped	90
Total	1482

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

gpop63 · 2022-11-15T11:08:57Z

/test

…metadata_cache

endorama · 2022-11-23T13:13:28Z

@gpop63 I like the direction this is headed, can we move forward with it?

…metadata_cache

kaiyan-sheng · 2022-11-29T18:50:55Z

x-pack/metricbeat/module/gcp/metrics/compute/metadata.go

 	"github.com/elastic/beats/v7/x-pack/metricbeat/module/gcp"
 	"github.com/elastic/elastic-agent-libs/logp"
 )

+/*
 const (


can we remove these const since we are not using it anymore? :)

endorama

Logic is correct, can you please clean up all the commented code?

mergify · 2022-12-01T11:41:06Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b remove_gcp-compute_metadata_cache upstream/remove_gcp-compute_metadata_cache
git merge upstream/main
git push upstream remove_gcp-compute_metadata_cache

…metadata_cache

endorama · 2022-12-01T14:29:20Z

x-pack/metricbeat/module/gcp/metrics/compute/metadata_test.go

-	projectID:     "projectID",
-	instanceCache: common.NewCache(30*time.Second, 13),
+	projectID: "projectID",
+	// instanceCache: common.NewCache(30*time.Second, 13),


Can we get rid of this too?

endorama · 2022-12-01T14:29:22Z

x-pack/metricbeat/module/gcp/metrics/compute/metadata.go

+	region    string
+	regions   []string
+	opt       []option.ClientOption
+	// instanceCache *common.Cache


Can we get rid of this too?

mergify · 2022-12-02T15:09:51Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b remove_gcp-compute_metadata_cache upstream/remove_gcp-compute_metadata_cache
git merge upstream/main
git push upstream remove_gcp-compute_metadata_cache

sonarcloud · 2022-12-05T19:33:41Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.3% Duplication

* remove compute metadata cache * add logs and change map key type * add import aliases * add changelog entry * cleanup comments * remove comments (cherry picked from commit 74edd05) # Conflicts: # x-pack/metricbeat/module/gcp/metrics/compute/metadata.go

…che (#33948) * [metricbeat] [gcp] remove compute metadata cache (#33655) * remove compute metadata cache * add logs and change map key type * add import aliases * add changelog entry * cleanup comments * remove comments (cherry picked from commit 74edd05) # Conflicts: # x-pack/metricbeat/module/gcp/metrics/compute/metadata.go * fix CHANGELOG * fix merge conflicts * fix linter * remove unused package --------- Co-authored-by: Gabriel Pop <94497545+gpop63@users.noreply.github.com> Co-authored-by: Edoardo Tenani <edoardo.tenani@elastic.co> Co-authored-by: Edoardo Tenani <526307+endorama@users.noreply.github.com>

* remove compute metadata cache * add logs and change map key type * add import aliases * add changelog entry * cleanup comments * remove comments

remove compute metadata cache

c606c49

botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 11, 2022

gpop63 changed the title ~~[metricbeat] [gc] remove compute metadata cache~~ [metricbeat] [gcp] remove compute metadata cache Nov 11, 2022

gpop63 added the Team:Cloud-Monitoring Label for the Cloud Monitoring team label Nov 11, 2022

botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 11, 2022

mergify bot assigned gpop63 Nov 11, 2022

gpop63 added backport-v7.17.0 Automated backport with mergify backport-v8.4.0 Automated backport with mergify labels Nov 11, 2022

add logs and change map key type

bad28ca

Merge remote-tracking branch 'upstream/main' into remove_gcp-compute_…

114a009

…metadata_cache

gpop63 force-pushed the remove_gcp-compute_metadata_cache branch from efb1722 to 114a009 Compare November 15, 2022 11:22

gpop63 and others added 2 commits November 15, 2022 14:49

Merge branch 'main' into remove_gcp-compute_metadata_cache

62396a5

add import aliases

b38858b

gpop63 added 2 commits November 23, 2022 22:35

Merge remote-tracking branch 'upstream/main' into remove_gcp-compute_…

fd29c5f

…metadata_cache

add changelog entry

2d18131

gpop63 marked this pull request as ready for review November 23, 2022 21:29

gpop63 requested a review from a team as a code owner November 23, 2022 21:29

kaiyan-sheng reviewed Nov 29, 2022

View reviewed changes

endorama requested changes Nov 30, 2022

View reviewed changes

gpop63 added 2 commits December 1, 2022 13:45

cleanup comments

d9f4192

Merge remote-tracking branch 'upstream/main' into remove_gcp-compute_…

0f0233a

…metadata_cache

endorama reviewed Dec 1, 2022

View reviewed changes

remove comments

23b6c18

endorama approved these changes Dec 2, 2022

View reviewed changes

kaiyan-sheng approved these changes Dec 2, 2022

View reviewed changes

Merge branch 'main' into remove_gcp-compute_metadata_cache

f5cf092

gpop63 merged commit 74edd05 into elastic:main Dec 5, 2022

mergify bot mentioned this pull request Dec 5, 2022

[7.17](backport #33655) [metricbeat] [gcp] remove compute metadata cache #33948

Merged

mergify bot mentioned this pull request Dec 5, 2022

[8.4](backport #33655) [metricbeat] [gcp] remove compute metadata cache #33949

Closed

chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023

[metricbeat] [gcp] remove compute metadata cache (#33655)

1635b42

* remove compute metadata cache * add logs and change map key type * add import aliases * add changelog entry * cleanup comments * remove comments

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[metricbeat] [gcp] remove compute metadata cache #33655

[metricbeat] [gcp] remove compute metadata cache #33655

gpop63 commented Nov 11, 2022

mergify bot commented Nov 11, 2022

elasticmachine commented Nov 11, 2022 •

edited by jenkins-beats-ci bot

Build stats

Test stats 🧪

gpop63 commented Nov 15, 2022

endorama commented Nov 23, 2022

kaiyan-sheng Nov 29, 2022

endorama left a comment

mergify bot commented Dec 1, 2022

endorama Dec 1, 2022

endorama Dec 1, 2022

mergify bot commented Dec 2, 2022

sonarcloud bot commented Dec 5, 2022

[metricbeat] [gcp] remove compute metadata cache #33655

[metricbeat] [gcp] remove compute metadata cache #33655

Conversation

gpop63 commented Nov 11, 2022

What does this PR do?

Why is it important?

Checklist

Author's Checklist

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

mergify bot commented Nov 11, 2022

elasticmachine commented Nov 11, 2022 • edited by jenkins-beats-ci bot

💚 Build Succeeded

Build stats

Test stats 🧪

💚 Flaky test report

🤖 GitHub comments

gpop63 commented Nov 15, 2022

endorama commented Nov 23, 2022

kaiyan-sheng Nov 29, 2022

Choose a reason for hiding this comment

endorama left a comment

Choose a reason for hiding this comment

mergify bot commented Dec 1, 2022

endorama Dec 1, 2022

Choose a reason for hiding this comment

endorama Dec 1, 2022

Choose a reason for hiding this comment

mergify bot commented Dec 2, 2022

sonarcloud bot commented Dec 5, 2022

elasticmachine commented Nov 11, 2022 •

edited by jenkins-beats-ci bot