Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding filenames from the zip to the response for httpjson #34044

Merged
merged 6 commits into from
Dec 15, 2022

Conversation

kgeller
Copy link
Contributor

@kgeller kgeller commented Dec 14, 2022

What does this PR do?

The httpjson input will report filenames for application/zip events in the response.

Why is it important?

We have a bug for an integration that utilizes the filename to determine a log_type field as the field is in the name. For example, filename="delivery_20160705162902600.log" -> log_type: delivery. When utilizing compress: true, the filename is instead a random guid and so the log_type can't be derived, example filename="8578FCFC-A305-4D9A-99CB-F4D5ECEFE297.zip".

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Closes #33952

Use cases

Screenshots

Logs

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Dec 14, 2022
@mergify
Copy link
Contributor

mergify bot commented Dec 14, 2022

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @kgeller? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 14, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-12-15T15:31:57.248+0000

  • Duration: 75 min 41 sec

Test stats 🧪

Test Results
Failed 0
Passed 2532
Skipped 167
Total 2699

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kgeller kgeller added backport-skip Skip notification from the automated backport with mergify 8.7-candidate labels Dec 14, 2022
@marc-gr marc-gr added backport-v7.17.0 Automated backport with mergify backport-v8.6.0 Automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify backport-v7.17.0 Automated backport with mergify labels Dec 15, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kgeller kgeller marked this pull request as ready for review December 15, 2022 15:37
@kgeller kgeller requested a review from a team as a code owner December 15, 2022 15:38
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@kgeller kgeller merged commit b3f3633 into elastic:main Dec 15, 2022
@kgeller kgeller deleted the adding_zip_header_info branch December 15, 2022 17:11
mergify bot pushed a commit that referenced this pull request Dec 15, 2022
kgeller pushed a commit that referenced this pull request Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.7-candidate backport-v8.6.0 Automated backport with mergify enhancement Filebeat Filebeat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

httpjson to report the filename for application/zip based events
3 participants