x-pack/filebeat/input/httpjson: fix relation parameter handling in getRFC5988Link #34622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
bug
Filebeat
botelastic
bot
added
needs_team
efd6
force-pushed
the
34603-httpjson
branch
2 times, most recently
from
ff4e493
to
0dcd7db
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
efd6
changed the title
|
This pull request is now in conflicts. Could you fix it? 🙏 |
Previously the regular expression required a space separating the "ral" tag from previous text. While the examples in RFC5988 show a separating space, the ABNF does not indicate a requirement; the space that does exist in the examples is allowed by RFC2616 because of the implied *LWS rule for token separation. The new regular expression also more carefully considers quoting for rel parameters and semicolon requirements.
mergify bot
pushed a commit
that referenced
this pull request
Mar 21, 2023
…ink (#34622) Previously the regular expression required a space separating the "ral" tag from previous text. While the examples in RFC5988 show a separating space, the ABNF does not indicate a requirement; the space that does exist in the examples is allowed by RFC2616 because of the implied *LWS rule for token separation. The new regular expression also more carefully considers quoting for rel parameters and semicolon requirements. (cherry picked from commit ba67aa8)
mergify bot
pushed a commit
that referenced
this pull request
Mar 21, 2023
…ink (#34622) Previously the regular expression required a space separating the "ral" tag from previous text. While the examples in RFC5988 show a separating space, the ABNF does not indicate a requirement; the space that does exist in the examples is allowed by RFC2616 because of the implied *LWS rule for token separation. The new regular expression also more carefully considers quoting for rel parameters and semicolon requirements. (cherry picked from commit ba67aa8)
efd6
added a commit
that referenced
this pull request
Mar 21, 2023
…ink (#34622) (#34867) Previously the regular expression required a space separating the "ral" tag from previous text. While the examples in RFC5988 show a separating space, the ABNF does not indicate a requirement; the space that does exist in the examples is allowed by RFC2616 because of the implied *LWS rule for token separation. The new regular expression also more carefully considers quoting for rel parameters and semicolon requirements. (cherry picked from commit ba67aa8) Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
efd6
added a commit
that referenced
this pull request
Mar 21, 2023
…parameter handling in getRFC5988Link (#34868) * x-pack/filebeat/input/httpjson: fix relation parameter in getRFC5988Link (#34622) Previously the regular expression required a space separating the "ral" tag from previous text. While the examples in RFC5988 show a separating space, the ABNF does not indicate a requirement; the space that does exist in the examples is allowed by RFC2616 because of the implied *LWS rule for token separation. The new regular expression also more carefully considers quoting for rel parameters and semicolon requirements. (cherry picked from commit ba67aa8) * remove irrelevant changelog lines * use common.MapStr * adjust test for previous split behaviour Between 7.17 and 8.6, the capacity to split link headers from single strings was added, so make each link a single string --------- Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com> Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
chrisberkhout
pushed a commit
that referenced
this pull request
Jun 1, 2023
…ink (#34622) Previously the regular expression required a space separating the "ral" tag from previous text. While the examples in RFC5988 show a separating space, the ABNF does not indicate a requirement; the space that does exist in the examples is allowed by RFC2616 because of the implied *LWS rule for token separation. The new regular expression also more carefully considers quoting for rel parameters and semicolon requirements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Previously the regular expression required a space separating the "rel" tag from previous text. While the examples in RFC5988 show a separating space, the ABNF does not indicate a requirement; the space that does exist in the examples is allowed by RFC2616 because of the implied *LWS rule for token separation.
The new regular expression also more carefully considers quoting for rel parameters and semicolon requirements.
Why is it important?
The existing code rejects valid links.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs