Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.17](backport #34647) Add SafeProcessor wrapper #34666

Merged
merged 3 commits into from Feb 24, 2023
Merged

[7.17](backport #34647) Add SafeProcessor wrapper #34666

merged 3 commits into from Feb 24, 2023

Commits on Feb 24, 2023

  1. Add SafeProcessor wrapper (#34647) 

    Each processor might end up in multiple processor groups.
Every group has its own `Close` that calls `Close` on each
processor of that group which leads to multiple `Close` calls
on the same processor.

If the `SafeProcessor` wrapper was not used,
the processor would have to handle multiple `Close` calls with
adding `sync.Once` in its `Close` function.

We make it easer for processor developers and take care of it
in the processor registry instead.

(cherry picked from commit 5007b58)
    @rdner @mergify
    rdner authored and mergify[bot] committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    eb12562 View commit details
    Browse the repository at this point in the history

  2. Remove extra changelog entries

    @rdner
    rdner committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    d34cace View commit details
    Browse the repository at this point in the history

  3. Fix different constructor signature

    @rdner
    rdner committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    0d24396 View commit details
    Browse the repository at this point in the history