Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Azure Metrics] Fix CassandraConnectionClosures metric configuration #34742

Merged
merged 4 commits into from Oct 20, 2023

Conversation

zmoog
Copy link
Contributor

@zmoog zmoog commented Mar 6, 2023

What does this PR do?

Move the CassandraConnectionClosures metric name from the always-available list of metrics to the Cassandra-focused list of metrics.

Metric names not always available should be listed in a section marked with the ignore_unsupported setting set to true.

Why is it important?

The integration works if the subscription has at least one Cassandra cluster available but fails otherwise.

Checklist

- [ ] My code follows the style guidelines of this project
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation

  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 6, 2023
@zmoog zmoog self-assigned this Mar 6, 2023
@zmoog zmoog added bug Team:Cloud-Monitoring Label for the Cloud Monitoring team labels Mar 6, 2023
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 6, 2023
@mergify
Copy link
Contributor

mergify bot commented Mar 6, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @zmoog? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 6, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 51 min 21 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@zmoog zmoog force-pushed the zmoog/azure-metrics-database-error branch from 5edfd50 to 1cff909 Compare March 8, 2023 16:24
@zmoog
Copy link
Contributor Author

zmoog commented Mar 8, 2023

/test

@mergify
Copy link
Contributor

mergify bot commented Mar 30, 2023

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b zmoog/azure-metrics-database-error upstream/zmoog/azure-metrics-database-error
git merge upstream/main
git push upstream zmoog/azure-metrics-database-error

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Jun 27, 2023

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b zmoog/azure-metrics-database-error upstream/zmoog/azure-metrics-database-error
git merge upstream/main
git push upstream zmoog/azure-metrics-database-error

zmoog and others added 3 commits October 19, 2023 16:27
The name of the metric, "CassandraConnectionClosures" is listed in the
wrong section of the metrics configuration.

It should be moved to a different section that includes metric names
which may or may not be available depending on the environment, with
the "ignore_unsupported" setting set to true.
The `CassandraConnectionClosures` metric only supports the following
dimensions:

- `ClosureReason`
- `Region`
@zmoog zmoog force-pushed the zmoog/azure-metrics-database-error branch from 1cff909 to d28f3e0 Compare October 19, 2023 14:29
@kaiyan-sheng kaiyan-sheng added backport-v7.17.0 Automated backport with mergify backport-v8.11.0 Automated backport with mergify labels Oct 19, 2023
@zmoog zmoog marked this pull request as ready for review October 19, 2023 16:31
@zmoog zmoog requested a review from a team as a code owner October 19, 2023 16:31
@zmoog zmoog merged commit 42f2f94 into main Oct 20, 2023
21 checks passed
@zmoog zmoog deleted the zmoog/azure-metrics-database-error branch October 20, 2023 08:54
mergify bot pushed a commit that referenced this pull request Oct 20, 2023
…34742)

* Move CassandraConnectionClosures metrics

The name of the metric, "CassandraConnectionClosures" is listed in the
wrong section of the metrics configuration.

It should be moved to a different section that includes metric names
which may or may not be available depending on the environment, with
the "ignore_unsupported" setting set to true.

* Update changelog

* Fix dimensions for CassandraConnectionClosures

The `CassandraConnectionClosures` metric only supports the following
dimensions:

- `ClosureReason`
- `Region`

(cherry picked from commit 42f2f94)
mergify bot pushed a commit that referenced this pull request Oct 20, 2023
…34742)

* Move CassandraConnectionClosures metrics

The name of the metric, "CassandraConnectionClosures" is listed in the
wrong section of the metrics configuration.

It should be moved to a different section that includes metric names
which may or may not be available depending on the environment, with
the "ignore_unsupported" setting set to true.

* Update changelog

* Fix dimensions for CassandraConnectionClosures

The `CassandraConnectionClosures` metric only supports the following
dimensions:

- `ClosureReason`
- `Region`

(cherry picked from commit 42f2f94)
zmoog added a commit that referenced this pull request Oct 20, 2023
…34742) (#36921)

* Move CassandraConnectionClosures metrics

The name of the metric, "CassandraConnectionClosures" is listed in the
wrong section of the metrics configuration.

It should be moved to a different section that includes metric names
which may or may not be available depending on the environment, with
the "ignore_unsupported" setting set to true.

* Update changelog

* Fix dimensions for CassandraConnectionClosures

The `CassandraConnectionClosures` metric only supports the following
dimensions:

- `ClosureReason`
- `Region`

(cherry picked from commit 42f2f94)

Co-authored-by: Maurizio Branca <maurizio.branca@elastic.co>
zmoog added a commit that referenced this pull request Oct 20, 2023
…es metric configuration (#36920)

* [Azure Metrics] Fix CassandraConnectionClosures metric configuration (#34742)

* Move CassandraConnectionClosures metrics

The name of the metric, "CassandraConnectionClosures" is listed in the
wrong section of the metrics configuration.

It should be moved to a different section that includes metric names
which may or may not be available depending on the environment, with
the "ignore_unsupported" setting set to true.

* Update changelog

* Fix dimensions for CassandraConnectionClosures

The `CassandraConnectionClosures` metric only supports the following
dimensions:

- `ClosureReason`
- `Region`

(cherry picked from commit 42f2f94)

* Remove extra changelog entries

* Remove extra empty line

---------

Co-authored-by: Maurizio Branca <maurizio.branca@elastic.co>
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
…lastic#34742)

* Move CassandraConnectionClosures metrics

The name of the metric, "CassandraConnectionClosures" is listed in the
wrong section of the metrics configuration.

It should be moved to a different section that includes metric names
which may or may not be available depending on the environment, with
the "ignore_unsupported" setting set to true.

* Update changelog

* Fix dimensions for CassandraConnectionClosures

The `CassandraConnectionClosures` metric only supports the following
dimensions:

- `ClosureReason`
- `Region`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.17.0 Automated backport with mergify backport-v8.11.0 Automated backport with mergify bug Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants