Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filebeat/scripts/mage - Remove installation of journald deps from crossBuild #34939

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Mar 27, 2023

What does this PR do?

The golang-crossbuild images contain the journald development dependencies so
the build steps do not need make changes to the environment before building.

Fixes #34938

Why is it important?

Packaging builds are failing. (see #34938 (comment))

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

cd filebeat; SNAPSHOT=true mage -v package

Related issues

@andrewkroh andrewkroh added :Packaging Filebeat Filebeat Packaging build-system Issue or change affecting Mage, Make, or build scripts. build-failures Build failures in the CI. labels Mar 27, 2023
@andrewkroh andrewkroh requested a review from a team as a code owner March 27, 2023 15:48
@andrewkroh andrewkroh requested review from belimawr and rdner and removed request for a team March 27, 2023 15:48
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 27, 2023
@mergify
Copy link
Contributor

mergify bot commented Mar 27, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @andrewkroh? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@mergify
Copy link
Contributor

mergify bot commented Mar 27, 2023

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b bugfix/filebeat/remove-journald-crossbuild-deps upstream/bugfix/filebeat/remove-journald-crossbuild-deps
git merge upstream/main
git push upstream bugfix/filebeat/remove-journald-crossbuild-deps

@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 27, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-28T13:19:29.710+0000

  • Duration: 44 min 29 sec

Test stats 🧪

Test Results
Failed 0
Passed 4712
Skipped 571
Total 5283

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

…ssBuild

The golang-crossbuild images contain the journald development dependencies so
the build steps do not need make changes to the environment before building.

Fixes elastic#34938
@andrewkroh andrewkroh force-pushed the bugfix/filebeat/remove-journald-crossbuild-deps branch from 548a8ef to 33fbe01 Compare March 27, 2023 18:13
@andrewkroh andrewkroh added the Team:Elastic-Agent Label for the Agent team label Mar 27, 2023
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 27, 2023
@rdner rdner added backport-v7.17.0 Automated backport with mergify backport-v8.7.0 Automated backport with mergify labels Mar 28, 2023
@rdner
Copy link
Member

rdner commented Mar 28, 2023

I didn't know we could just remove them :)

This will help prevent merge conflicts.
@andrewkroh andrewkroh merged commit 192be24 into elastic:main Mar 28, 2023
andrewkroh added a commit that referenced this pull request Mar 28, 2023
…ssBuild (#34939)

The golang-crossbuild images contain the journald development dependencies so
the build steps do not need make changes to the environment before building.

Fixes #34938

(cherry picked from commit 192be24)
andrewkroh added a commit that referenced this pull request Mar 28, 2023
…ssBuild (#34939)

The golang-crossbuild images contain the journald development dependencies so
the build steps do not need make changes to the environment before building.

Fixes #34938

(cherry picked from commit 192be24)
andrewkroh added a commit that referenced this pull request Mar 28, 2023
…ssBuild (#34939) (#34953)

The golang-crossbuild images contain the journald development dependencies so
the build steps do not need make changes to the environment before building.

Fixes #34938

(cherry picked from commit 192be24)

Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
andrewkroh added a commit that referenced this pull request Mar 28, 2023
…ssBuild (#34939) (#34954)

The golang-crossbuild images contain the journald development dependencies so
the build steps do not need make changes to the environment before building.

Fixes #34938

(cherry picked from commit 192be24)

Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
…ssBuild (#34939)

The golang-crossbuild images contain the journald development dependencies so
the build steps do not need make changes to the environment before building.

Fixes #34938
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.17.0 Automated backport with mergify backport-v8.7.0 Automated backport with mergify build-failures Build failures in the CI. build-system Issue or change affecting Mage, Make, or build scripts. Filebeat Filebeat :Packaging Packaging Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Packaging build is failing for 8.7 and main
3 participants