New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{,x-pack/}packetbeat: fix documentation for flows period #35009
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
docs
Packetbeat
Team:Security-External Integrations
backport-v7.17.0
Automated backport with mergify
8.8-candidate
bugfix
backport-v8.7.0
Automated backport with mergify
labels
Apr 4, 2023
efd6
force-pushed
the
i5771-packetbeat-docs
branch
3 times, most recently
from
April 4, 2023 01:58
da69def
to
9783d09
Compare
efd6
force-pushed
the
i5771-packetbeat-docs
branch
from
April 4, 2023 03:27
9783d09
to
9b14d49
Compare
efd6
changed the title
{,x-pack}/packetbeat: fix documentation for flows period
{,x-pack/}packetbeat: fix documentation for flows period
Apr 4, 2023
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
bhapas
approved these changes
Apr 12, 2023
mergify bot
pushed a commit
that referenced
this pull request
Apr 14, 2023
(cherry picked from commit d043a69)
mergify bot
pushed a commit
that referenced
this pull request
Apr 14, 2023
(cherry picked from commit d043a69)
efd6
added a commit
that referenced
this pull request
Apr 14, 2023
efd6
added a commit
that referenced
this pull request
Apr 14, 2023
chrisberkhout
pushed a commit
that referenced
this pull request
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
8.8-candidate
backport-v7.17.0
Automated backport with mergify
backport-v8.7.0
Automated backport with mergify
bugfix
docs
Packetbeat
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This fixes documentation that misdirects users to use "-1" as a sentinel. This value causes packetbeat to fail to configure.
See
beats/packetbeat/flows/flows.go
Lines 49 to 66 in 25acf60
Why is it important?
The current documentation misleads users to use an invalid value.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs