Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filebeat/input/tcp - Fix panic in linux input metrics (#35068) #35074

Merged
merged 1 commit into from Apr 12, 2023
Merged

filebeat/input/tcp - Fix panic in linux input metrics (#35068) #35074

merged 1 commit into from Apr 12, 2023

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Apr 12, 2023 •
edited

What does this PR do?

A panic occurred while parsing /proc/net/tcp and reaching the final empty line. This occurred on Linux when the desired socket was not found in the list.

Fixes #35064

Why is it important?

The panic causes Filebeat to exit.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@andrewkroh
filebeat/input/tcp - Fix panic in linux input metrics (elastic#35068)
d24433f 
A panic occurred while parsing /proc/net/tcp and reaching the final empty line.
This occurred on Linux when the desired socket was not found in the list.

Fixes elastic#35064
@andrewkroh andrewkroh added bug Filebeat Filebeat backport-v8.7.0 Automated backport with mergify labels Apr 12, 2023
@andrewkroh andrewkroh requested a review from a team as a code owner April 12, 2023 19:27
@andrewkroh andrewkroh requested review from belimawr and cmacknz and removed request for a team April 12, 2023 19:27
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 12, 2023
@andrewkroh andrewkroh mentioned this pull request Apr 12, 2023
Closed
@andrewkroh andrewkroh requested a review from a team April 12, 2023 19:35
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Apr 12, 2023
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-12T19:27:26.107+0000

  • Duration: 72 min 38 sec

Test stats 🧪

Test Results
Failed 0
Passed 7627
Skipped 753
Total 8380

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@andrewkroh andrewkroh merged commit a550cf8 into elastic:main Apr 12, 2023
26 checks passed
@mergify mergify bot mentioned this pull request Apr 12, 2023
Merged
andrewkroh added a commit that referenced this pull request Apr 12, 2023
@andrewkroh
filebeat/input/tcp - Fix panic in linux input metrics (#35068) (#35074)
73b95a1 
A panic occurred while parsing /proc/net/tcp and reaching the final empty line.
This occurred on Linux when the desired socket was not found in the list.

Fixes #35064

(cherry picked from commit a550cf8)
andrewkroh added a commit that referenced this pull request Apr 13, 2023
@mergify @andrewkroh
filebeat/input/tcp - Fix panic in linux input metrics (#35068) (#35074)…
c00c30f 
… (#35076)

A panic occurred while parsing /proc/net/tcp and reaching the final empty line.
This occurred on Linux when the desired socket was not found in the list.

Fixes #35064

(cherry picked from commit a550cf8)

Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
@andrewkroh @chrisberkhout
filebeat/input/tcp - Fix panic in linux input metrics (#35068) (#35074)
1bcb342 
A panic occurred while parsing /proc/net/tcp and reaching the final empty line.
This occurred on Linux when the desired socket was not found in the list.

Fixes #35064
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@belimawr belimawr Awaiting requested review from belimawr belimawr is a code owner automatically assigned from elastic/elastic-agent-data-plane

@cmacknz cmacknz Awaiting requested review from cmacknz cmacknz is a code owner automatically assigned from elastic/elastic-agent-data-plane

@leehinman leehinman Awaiting requested review from leehinman

Assignees

@andrewkroh andrewkroh

Labels
backport-v8.7.0 Automated backport with mergify bug Filebeat Filebeat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Filebeat] TCP/UDP input cause a panic on Linux under certain conditions
2 participants
@andrewkroh @elasticmachine