Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x-pack/filebeat/input/httpjson: add benchmarks #35138

Merged
merged 2 commits into from
Jun 8, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Apr 20, 2023

What does this PR do?

This adds benchmarking for the HTTPJSON input as a prelude to a refactor and revision. It also refactors the structure of the testing code to separate the test table from the test function; this is partly to allow sharing of test cases between the tests and benchmarks, and partly for clarity.

Test names are altered to reduce stutter and make direct copy/paste of the name in terminal output from go test findable in the Go source.

Why is it important?

This is needed to allow a comparison between HTTPJSON and the new CEL input (the original reason), to guard against perf regressions in an upcoming revision, and to allow us to direct performance improvement work based on evidence. The formatting changes in the test table are QoL.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • Recommend hide whitespace for review of test file changes.

How to test this PR locally

Run go test in x-pack/filebeat/input/httpjson, optionally with -bench . and friends.

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 added Team:Security-External Integrations backport-skip Skip notification from the automated backport with mergify labels Apr 20, 2023
@efd6 efd6 self-assigned this Apr 20, 2023
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Apr 20, 2023
@efd6 efd6 added the Filebeat Filebeat label Apr 20, 2023
@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 20, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-07T16:04:25.489+0000

  • Duration: 76 min 45 sec

Test stats 🧪

Test Results
Failed 0
Passed 2961
Skipped 177
Total 3138

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify

This comment was marked as outdated.

@efd6
Copy link
Contributor Author

efd6 commented Apr 27, 2023

/test

@efd6 efd6 force-pushed the x-httpjson-benchmarks branch 2 times, most recently from 43de5f7 to 003afcb Compare May 24, 2023 22:14
@efd6 efd6 marked this pull request as ready for review May 24, 2023 23:39
@efd6 efd6 requested a review from a team as a code owner May 24, 2023 23:39
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

efd6 added 2 commits June 7, 2023 13:33
Also rename test cases to reduce stutter and improve test debug ergonomics.
@efd6
Copy link
Contributor Author

efd6 commented Jun 7, 2023

/test

@efd6 efd6 merged commit 2248267 into elastic:main Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.9-candidate backport-skip Skip notification from the automated backport with mergify enhancement Filebeat Filebeat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants