Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x-pack/filebeat/input/httpjson: provide XML decoding functionality #35235

Merged
merged 3 commits into from May 19, 2023
Merged

x-pack/filebeat/input/httpjson: provide XML decoding functionality #35235

merged 3 commits into from May 19, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Apr 27, 2023

What does this PR do?

This addition makes use of the mito XML library to allow users to decode XML responses with type hints.

Why is it important?

This is a blocker for an integration.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 added enhancement Filebeat Filebeat Team:Security-External Integrations backport-skip Skip notification from the automated backport with mergify 8.9-candidate labels Apr 27, 2023
@efd6 efd6 self-assigned this Apr 27, 2023
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Apr 27, 2023
@efd6 efd6 force-pushed the 34438-httpjson branch 2 times, most recently from 4e62604 to 7904f81 Compare April 27, 2023 04:44
@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 27, 2023 •
edited by jenkins-beats-ci bot

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-12T10:29:51.967+0000

  • Duration: 121 min 50 sec

Test stats 🧪

Test Results
Failed 0
Passed 26367
Skipped 1975
Total 28342

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@efd6 efd6 marked this pull request as ready for review April 27, 2023 20:42
@efd6 efd6 requested review from a team as code owners April 27, 2023 20:42
@efd6 efd6 requested review from ycombinator and cmacknz and removed request for a team April 27, 2023 20:42
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@mergify

This comment was marked as outdated.

Sign in to view
@efd6 efd6 force-pushed the 34438-httpjson branch 2 times, most recently from 9abe7df to a440d28 Compare May 7, 2023 22:56
@efd6 efd6 mentioned this pull request May 8, 2023
Merged
6 tasks
@mergify

This comment was marked as outdated.

Sign in to view
bhapas
bhapas reviewed May 10, 2023
View reviewed changes
x-pack/filebeat/input/httpjson/encoding.go Outdated Show resolved Hide resolved
x-pack/filebeat/input/httpjson/encoding.go Show resolved Hide resolved
x-pack/filebeat/input/httpjson/input.go Outdated Show resolved Hide resolved
x-pack/filebeat/input/httpjson/input_test.go Show resolved Hide resolved
x-pack/filebeat/input/httpjson/request.go Outdated Show resolved Hide resolved
@mergify

This comment was marked as outdated.

Sign in to view
@efd6
x-pack/filebeat/input/httpjson: provide XML decoding functionality
238c351 
This addition makes use of the mito XML library to allow users to decode
XML responses with type hints.
@efd6 efd6 requested a review from bhapas May 11, 2023 00:30
bhapas
bhapas previously approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@bhapas bhapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efd6 efd6 requested a review from bhapas May 12, 2023 10:30
@efd6
Copy link
Contributor Author

efd6 commented May 12, 2023

I've upgraded the mito dep to the more strict xml parser version. PTAL

@efd6 efd6 requested review from a team, belimawr and faec and removed request for a team May 15, 2023 09:44
@efd6
Copy link
Contributor Author

efd6 commented May 16, 2023

@belimawr or @faec Would either of you be able to take a look at this for the go.mod and NOTICE.txt changes?

@efd6 efd6 merged commit f8f25ad into elastic:main May 19, 2023
111 of 113 checks passed
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
@efd6 @chrisberkhout
x-pack/filebeat/input/httpjson: provide XML decoding functionality (#…
5020d3f 
…35235)

This addition makes use of the mito XML library to allow users to decode
XML responses with type hints.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmacknz cmacknz cmacknz approved these changes

@bhapas bhapas bhapas approved these changes

@belimawr belimawr Awaiting requested review from belimawr belimawr was automatically assigned from elastic/elastic-agent-data-plane

@faec faec Awaiting requested review from faec faec was automatically assigned from elastic/elastic-agent-data-plane

Assignees

@efd6 efd6

Labels
8.9-candidate backport-skip Skip notification from the automated backport with mergify enhancement Filebeat Filebeat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@efd6 @elasticmachine @cmacknz @bhapas