Improve couchbase module #3545
Merged
Improve couchbase module #3545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ruflin
commented
Feb 7, 2017
ruflin
commented
- Fix typo spacial to spatial. Change fieldnames couchbase.node.couch..actual_disk_size. to couchbase.node.couch..disk_size. for consistency.
- Add system tests to verify docs
- Update data.json
* Fix typo spacial to spatial. Change fieldnames couchbase.node.couch.*.actual_disk_size.* to couchbase.node.couch.*.disk_size.* for consistency. * Add system tests to verify docs * Update data.json
ruflin
force-pushed
the
spacial-to-spatial
branch
from
4c7446b
to
9f1787c
Compare
monicasarbu
reviewed
Feb 7, 2017
| @@ -625,14 +625,14 @@ | |||
| }, | |||
| "views": { | |||
| "properties": { | |||
| "actual_disk_size": { | |||
| "data_size": { | |||
There was a problem hiding this comment.
isn't disk_size instead of data_size?
There was a problem hiding this comment.
The diff is confusing here. disk_size is acutally on like 635 and data_size was moved up here (alphabetical sorting).
monicasarbu
reviewed
Feb 7, 2017
| "properties": { | ||
| "bytes": { | ||
| "type": "long" | ||
| } | ||
| } | ||
| }, | ||
| "data_size": { | ||
| "disk_size": { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.