Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve couchbase module #3545

Merged
merged 1 commit into from Feb 7, 2017

Conversation

@ruflin
Copy link
Collaborator

commented Feb 7, 2017

  • Fix typo spacial to spatial. Change fieldnames couchbase.node.couch..actual_disk_size. to couchbase.node.couch..disk_size. for consistency.
  • Add system tests to verify docs
  • Update data.json
Improve couchbase module
* Fix typo spacial to spatial. Change fieldnames couchbase.node.couch.*.actual_disk_size.* to couchbase.node.couch.*.disk_size.* for consistency.
* Add system tests to verify docs
* Update data.json

@ruflin ruflin force-pushed the ruflin:spacial-to-spatial branch from 4c7446b to 9f1787c Feb 7, 2017

@@ -625,14 +625,14 @@
},
"views": {
"properties": {
"actual_disk_size": {
"data_size": {

This comment has been minimized.

Copy link
@monicasarbu

monicasarbu Feb 7, 2017

Contributor

isn't disk_size instead of data_size?

This comment has been minimized.

Copy link
@ruflin

ruflin Feb 7, 2017

Author Collaborator

The diff is confusing here. disk_size is acutally on like 635 and data_size was moved up here (alphabetical sorting).

"properties": {
"bytes": {
"type": "long"
}
}
},
"data_size": {
"disk_size": {

This comment has been minimized.

Copy link
@monicasarbu

monicasarbu Feb 7, 2017

Contributor

Is this by intention?

This comment has been minimized.

Copy link
@ruflin

ruflin Feb 7, 2017

Author Collaborator

See comment above.

@monicasarbu monicasarbu merged commit a8bd416 into elastic:master Feb 7, 2017

4 checks passed

CLA Commit author has signed the CLA
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
default Build finished.
Details

@ruflin ruflin deleted the ruflin:spacial-to-spatial branch Feb 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.