Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: Fix grammatical mistakes in *.tmpl files #35697

Merged
merged 17 commits into from
Jun 23, 2023
Merged

Conversation

shmsr
Copy link
Member

@shmsr shmsr commented Jun 6, 2023

  • Bug
  • Docs

What does this PR do?

It fixes some grammatical mistakes in the *.tmpl files.

Why is it important?

It is important because it is important to have solid documentation with as few errors as possible. The template files are sometimes used for configuration and sometimes even for generating code. It's important to have as fewer grammatical mistakes as possible. There's a linked issue as well.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 6, 2023
@shmsr shmsr changed the title Fix grammatical mistakes in *.tmpl files all: Fix grammatical mistakes in *.tmpl files Jun 6, 2023
@shmsr shmsr marked this pull request as ready for review June 6, 2023 10:31
@shmsr shmsr requested review from a team as code owners June 6, 2023 10:31
@mergify mergify bot assigned shmsr Jun 6, 2023
@mergify
Copy link
Contributor

mergify bot commented Jun 6, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @shmsr? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@shmsr
Copy link
Member Author

shmsr commented Jun 6, 2023

It is possible there are more errors. But I'm doing this manually and even with the help of a tool but each change should be manually checked. It's possible that I missed some *.tmpl files and even some errors. But we can have multiple PRs so that changeset is reviewable in each PR.

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 6, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-23T06:44:48.738+0000

  • Duration: 150 min 31 sec

Test stats 🧪

Test Results
Failed 0
Passed 27454
Skipped 2023
Total 29477

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

heartbeat/heartbeat.yml Outdated Show resolved Hide resolved
@shmsr
Copy link
Member Author

shmsr commented Jun 12, 2023

LGTM for the text changes! 🚀 Hopefully one of the Beats code owners can assist with the CI checks and merging, since these changes are in code files.

Thanks @kilfoyle for reviewing.

@belimawr
Copy link
Contributor

/test

@belimawr belimawr self-assigned this Jun 14, 2023
@shmsr shmsr enabled auto-merge (squash) June 14, 2023 09:14
@shmsr
Copy link
Member Author

shmsr commented Jun 14, 2023

@belimawr Whom should I ask for a review from elastic/{uptime,security-external-integrations,security-asset-management}? I'm not able to merge.

@shmsr shmsr removed the request for review from ycombinator June 16, 2023 02:16
@shmsr
Copy link
Member Author

shmsr commented Jun 16, 2023

Ping @elastic/security-asset-management @elastic/uptime. Could someone please review this PR?

@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Jun 20, 2023
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 20, 2023
Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the heartbeat portion

@shmsr shmsr requested a review from aleksmaus June 21, 2023 04:08
Copy link
Member

@aleksmaus aleksmaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

osquerybeat updates LGTM, thank you!

@shmsr shmsr merged commit 8ac9531 into elastic:main Jun 23, 2023
152 of 153 checks passed
@shmsr shmsr deleted the fix-tmpl-files branch July 4, 2023 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grammatical mistakes in template *.tmpl files
8 participants