-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
all: Fix grammatical mistakes in *.tmpl
files
#35697
Conversation
*.tmpl
files
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
It is possible there are more errors. But I'm doing this manually and even with the help of a tool but each change should be manually checked. It's possible that I missed some *.tmpl files and even some errors. But we can have multiple PRs so that changeset is reviewable in each PR. |
Thanks @kilfoyle for reviewing. |
/test |
@belimawr Whom should I ask for a review from |
Ping @elastic/security-asset-management @elastic/uptime. Could someone please review this PR? |
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the heartbeat portion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
osquerybeat updates LGTM, thank you!
What does this PR do?
It fixes some grammatical mistakes in the *.tmpl files.
Why is it important?
It is important because it is important to have solid documentation with as few errors as possible. The template files are sometimes used for configuration and sometimes even for generating code. It's important to have as fewer grammatical mistakes as possible. There's a linked issue as well.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues
*.tmpl
files #35696