Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin PyYAML version to 5.3.1 to avoid CI errors temporarily #36091

Merged
merged 2 commits into from
Jul 18, 2023

Conversation

shmsr
Copy link
Member

@shmsr shmsr commented Jul 17, 2023

What does this PR do?

CPython 3.0 was released recently which has introduced a regression that leads to failures when installing PyYAML (and perhaps other packages too). This is a temporary fix and this commits needs to be reverted when a proper fix is available.

Why is it important?

If we don't fix it CI would keep failing.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

CPython 3.0 released recently which appears to have introduced a regression that leads to failures when installing PyYAML
(and perhaps other packages too). This is a temporarily fix and this commits needs to be reverted when a proper fix is
available.
@shmsr shmsr added the bug label Jul 17, 2023
@shmsr shmsr requested review from a team as code owners July 17, 2023 20:11
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 17, 2023
@botelastic
Copy link

botelastic bot commented Jul 17, 2023

This pull request doesn't have a Team:<team> label.

@mergify mergify bot assigned shmsr Jul 17, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 17, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @shmsr? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@shmsr shmsr enabled auto-merge (squash) July 17, 2023 20:22
@rdner rdner added the backport-v7.17.0 Automated backport with mergify label Jul 17, 2023
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 17, 2023

❕ Build Aborted

There is a new build on-going so the previous on-going builds have been aborted.

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-17T20:11:31.144+0000

  • Duration: 362 min 29 sec

Test stats 🧪

Test Results
Failed 0
Passed 11074
Skipped 311
Total 11385

Steps errors 18

Expand to view the steps failures

Show only the first 10 steps failures

Print Message
  • Took 0 min 0 sec . View more details here
  • Description: �[39;49m[INFO] Allocating a worker with the labels 'windows-2022'.�[0m
Print Message
  • Took 0 min 0 sec . View more details here
  • Description: �[39;49m[INFO] Allocating a worker with the labels 'windows-2022'.�[0m
Archive the artifacts
  • Took 0 min 0 sec . View more details here
Checks if running on a Unix-like node
  • Took 0 min 0 sec . View more details here
Google Storage Download
  • Took 0 min 4 sec . View more details here
Checks if running on a Unix-like node
  • Took 0 min 0 sec . View more details here
Print Message
  • Took 0 min 0 sec . View more details here
  • Description: �[39;49m[INFO] Allocating a worker with the labels 'rhel-9'.�[0m
Print Message
  • Took 0 min 0 sec . View more details here
  • Description: �[39;49m[INFO] Allocating a worker with the labels 'windows-2022'.�[0m
Error signal
  • Took 0 min 0 sec . View more details here
  • Description: Error 'org.jenkinsci.plugins.workflow.steps.FlowInterruptedException'
Recursively delete the current directory from the workspace
  • Took 0 min 3 sec . View more details here

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes CI!

@shmsr
Copy link
Member Author

shmsr commented Jul 18, 2023

Need someone from @elastic/elastic-agent-data-plane and @elastic/obs-cloudnative-monitoring to approve as well.

@pierrehilbert
Copy link
Collaborator

@bturquet can we have someone in your team to review here please?

@shmsr shmsr merged commit 46adbac into elastic:main Jul 18, 2023
90 checks passed
mergify bot pushed a commit that referenced this pull request Jul 18, 2023
CPython 3.0 was released recently which appears to have introduced a regression that leads to failures when installing PyYAML (and perhaps other packages too). This is a temporary fix and this commits needs to be reverted when a proper fix is available.

(cherry picked from commit 46adbac)

# Conflicts:
#	libbeat/tests/system/requirements.txt
#	libbeat/tests/system/requirements_aix.txt
@shmsr shmsr deleted the fix-ci-py-issue branch July 18, 2023 06:54
@efd6
Copy link
Contributor

efd6 commented Jul 18, 2023

Will this be backported to 8.9?

@pierrehilbert pierrehilbert added the backport-v8.9.0 Automated backport with mergify label Jul 18, 2023
mergify bot pushed a commit that referenced this pull request Jul 18, 2023
CPython 3.0 was released recently which appears to have introduced a regression that leads to failures when installing PyYAML (and perhaps other packages too). This is a temporary fix and this commits needs to be reverted when a proper fix is available.

(cherry picked from commit 46adbac)
rdner added a commit that referenced this pull request Jul 18, 2023
…s temporarily (#36093)

* Pin PyYAML version to 5.3.1 to avoid CI errors temporarily (#36091)

CPython 3.0 was released recently which appears to have introduced a regression that leads to failures when installing PyYAML (and perhaps other packages too). This is a temporary fix and this commits needs to be reverted when a proper fix is available.

(cherry picked from commit 46adbac)

# Conflicts:
#	libbeat/tests/system/requirements.txt
#	libbeat/tests/system/requirements_aix.txt

* Resolve conflicts

---------

Co-authored-by: subham sarkar <subham.sarkar@elastic.co>
Co-authored-by: Denis Rechkunov <denis.rechkunov@elastic.co>
pierrehilbert pushed a commit that referenced this pull request Jul 18, 2023
…36097)

CPython 3.0 was released recently which appears to have introduced a regression that leads to failures when installing PyYAML (and perhaps other packages too). This is a temporary fix and this commits needs to be reverted when a proper fix is available.

(cherry picked from commit 46adbac)

Co-authored-by: subham sarkar <subham.sarkar@elastic.co>
@pierrehilbert pierrehilbert added the backport-v8.7.0 Automated backport with mergify label Jul 24, 2023
mergify bot pushed a commit that referenced this pull request Jul 24, 2023
CPython 3.0 was released recently which appears to have introduced a regression that leads to failures when installing PyYAML (and perhaps other packages too). This is a temporary fix and this commits needs to be reverted when a proper fix is available.

(cherry picked from commit 46adbac)

# Conflicts:
#	libbeat/tests/system/requirements.txt
#	libbeat/tests/system/requirements_aix.txt
#	metricbeat/Dockerfile
pierrehilbert added a commit that referenced this pull request Jul 24, 2023
… temporarily (#36141)

* Pin PyYAML version to 5.3.1 to avoid CI errors temporarily (#36091)

CPython 3.0 was released recently which appears to have introduced a regression that leads to failures when installing PyYAML (and perhaps other packages too). This is a temporary fix and this commits needs to be reverted when a proper fix is available.

(cherry picked from commit 46adbac)

# Conflicts:
#	libbeat/tests/system/requirements.txt
#	libbeat/tests/system/requirements_aix.txt
#	metricbeat/Dockerfile

* Update requirements.txt

* Update requirements_aix.txt

* Update CHANGELOG-developer.next.asciidoc

* Update Dockerfile

---------

Co-authored-by: subham sarkar <subham.sarkar@elastic.co>
Co-authored-by: Pierre HILBERT <pierre.hilbert@elastic.co>
@pierrehilbert pierrehilbert added the backport-v8.8.0 Automated backport with mergify label Aug 1, 2023
mergify bot pushed a commit that referenced this pull request Aug 1, 2023
CPython 3.0 was released recently which appears to have introduced a regression that leads to failures when installing PyYAML (and perhaps other packages too). This is a temporary fix and this commits needs to be reverted when a proper fix is available.

(cherry picked from commit 46adbac)

# Conflicts:
#	libbeat/tests/system/requirements.txt
#	libbeat/tests/system/requirements_aix.txt
pierrehilbert pushed a commit that referenced this pull request Aug 1, 2023
… temporarily (#36189)

Backport from #36091

What does this PR do?
CPython 3.0 was released recently which has introduced a regression that leads to failures when installing PyYAML (and perhaps other packages too). This is a temporary fix and this commits needs to be reverted when a proper fix is available.

Why is it important?
If we don't fix it CI would keep failing.
cmacknz added a commit that referenced this pull request Jan 5, 2024
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
…6091)

CPython 3.0 was released recently which appears to have introduced a regression that leads to failures when installing PyYAML (and perhaps other packages too). This is a temporary fix and this commits needs to be reverted when a proper fix is available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.17.0 Automated backport with mergify backport-v8.7.0 Automated backport with mergify backport-v8.8.0 Automated backport with mergify backport-v8.9.0 Automated backport with mergify bug needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants