Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependabot: skip github.com/elastic/mito auto updates #36158

Merged
merged 1 commit into from
Jul 28, 2023
Merged

dependabot: skip github.com/elastic/mito auto updates #36158

merged 1 commit into from
Jul 28, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Jul 25, 2023

What does this PR do?

See title.

Why is it important?

Autoupdates fail to bring required docs updates.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 added enhancement Filebeat Filebeat backport-skip Skip notification from the automated backport with mergify 8.10-candidate labels Jul 25, 2023
@efd6 efd6 requested a review from cmacknz July 25, 2023 21:26
@efd6 efd6 self-assigned this Jul 25, 2023
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 25, 2023
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 25, 2023
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-25T21:28:00.667+0000

  • Duration: 12 min 14 sec

Test stats 🧪

Test Results
Failed 0
Passed 3
Skipped 0
Total 3

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@efd6 efd6 marked this pull request as ready for review July 25, 2023 21:46
@efd6 efd6 requested a review from a team as a code owner July 25, 2023 21:46
@efd6 efd6 requested a review from ycombinator July 25, 2023 21:46
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

andrewkroh
andrewkroh approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand it, but let's see if this stops the PRs.

What I don't understand is:

  • none of the allow values match github.com/elastic/mito
  • the last time it opened a PR for mito that PR did not have labels that would have associated it with any of these config groups

@cmacknz
Copy link
Member

cmacknz commented Jul 28, 2023

Yeah if we look at #36153 it labelled the PR for the agent data plane team. You may need the ignore directive alongside each allow and not just the ones for the SEI team.

@efd6 efd6 merged commit 3b94f18 into elastic:main Jul 28, 2023
6 checks passed
@cmacknz
Copy link
Member

cmacknz commented Aug 4, 2023

I think dependabot may not like the way we have written our configuration:

The property '#/updates/1' is a duplicate. Update configs must have a unique combination of 'package-ecosystem', 'directory', and 'target-branch'
The property '#/updates/2' is a duplicate. Update configs must have a unique combination of 'package-ecosystem', 'directory', and 'target-branch'

For some reason dependenbot decided to validate this in https://github.com/elastic/beats/pull/36233/checks?check_run_id=15603998412. I had never seen this check run before otherwise.

andrewkroh added a commit to andrewkroh/beats that referenced this pull request Aug 16, 2023
@andrewkroh
.github/dependabot.yml - Revert team based segmentation
26514e5 
Dependabot does not allow multiple configurations for a given
Go module. So this reverts the change to segment the configuration
along team boundaries with explicit team-based reviewer requirements.
It was complaining about

The property '#/updates/1' is a duplicate. Update configs must have a unique combination of 'package-ecosystem', 'directory', and 'target-branch'
The property '#/updates/2' is a duplicate. Update configs must have a unique combination of 'package-ecosystem', 'directory', and 'target-branch'

as pointed out in elastic#36158 (comment).
@andrewkroh andrewkroh mentioned this pull request Aug 16, 2023
Merged
@andrewkroh
Copy link
Member

I created a PR to follow-up on that dependabot error: #36345

andrewkroh added a commit that referenced this pull request Aug 16, 2023
@andrewkroh
.github/dependabot.yml - Revert team based segmentation (#36345)
a86e699 
Dependabot does not allow multiple configurations for a given
Go module. So this reverts the change to segment the configuration
along team boundaries with explicit team-based reviewer requirements.
It was complaining about

    The property '#/updates/1' is a duplicate. Update configs must have a unique combination of 'package-ecosystem', 'directory', and 'target-branch'
    The property '#/updates/2' is a duplicate. Update configs must have a unique combination of 'package-ecosystem', 'directory', and 'target-branch'

as pointed out in #36158 (comment).
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
@efd6 @Scholar-Li
dependabot: skip github.com/elastic/mito auto updates (elastic#36158)
9e1f0bc
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
@andrewkroh @Scholar-Li
.github/dependabot.yml - Revert team based segmentation (elastic#36345)
7d6f10e 
Dependabot does not allow multiple configurations for a given
Go module. So this reverts the change to segment the configuration
along team boundaries with explicit team-based reviewer requirements.
It was complaining about

    The property '#/updates/1' is a duplicate. Update configs must have a unique combination of 'package-ecosystem', 'directory', and 'target-branch'
    The property '#/updates/2' is a duplicate. Update configs must have a unique combination of 'package-ecosystem', 'directory', and 'target-branch'

as pointed out in elastic#36158 (comment).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmacknz cmacknz cmacknz approved these changes

@andrewkroh andrewkroh andrewkroh approved these changes

@ycombinator ycombinator Awaiting requested review from ycombinator ycombinator was automatically assigned from elastic/elastic-agent-data-plane

Assignees

@efd6 efd6

Labels
8.10-candidate backport-skip Skip notification from the automated backport with mergify enhancement Filebeat Filebeat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@efd6 @elasticmachine @cmacknz @andrewkroh