Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Heartbeat] Add default TZ to heartbeat docker images #36193

Merged
merged 2 commits into from Aug 4, 2023
Merged

[Heartbeat] Add default TZ to heartbeat docker images #36193

merged 2 commits into from Aug 4, 2023

Conversation

emilioalvap
Copy link
Collaborator

@emilioalvap emilioalvap commented Aug 1, 2023 •
edited

What does this PR do?

Fizes #36117. Add default TZ value to fix synthetic journeys for timezone-triggered errors.

Why is it important?

Unspecified timezone values can cause navigation errors on synthetics journeys.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.
  • I have made my commit title and message explanatory about the purpose and the reason of the change

How to test this PR locally

  1. Build heartbeat docker image locally.
  2. Create a journey that navigates to a Kibana URL.
  3. Wait for Kibana login page to load properly.

@emilioalvap emilioalvap added bug Team:obs-ds-hosted-services Label for the Observability Hosted Services team release-note:skip The PR should be ignored when processing the changelog labels Aug 1, 2023
@emilioalvap emilioalvap requested a review from a team August 1, 2023 13:15
@emilioalvap emilioalvap requested a review from a team as a code owner August 1, 2023 13:15
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime (Team:Uptime)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Aug 1, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 1, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @emilioalvap? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@emilioalvap emilioalvap added the backport-v8.9.0 Automated backport with mergify label Aug 1, 2023
@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 1, 2023 •
edited by jenkins-beats-ci bot

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-01T13:16:57.438+0000

  • Duration: 113 min 25 sec

Test stats 🧪

Test Results
Failed 0
Passed 27593
Skipped 2008
Total 29601

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@emilioalvap emilioalvap merged commit c09b949 into elastic:main Aug 4, 2023
113 of 114 checks passed
mergify bot pushed a commit that referenced this pull request Aug 4, 2023
@emilioalvap @mergify
[Heartbeat] Add default TZ to heartbeat docker images (#36193)
a09cfe0 
## What does this PR do?

Fixes #36117. Add default TZ
value to fix synthetic journeys for timezone-triggered errors.

## Why is it important?

Unspecified timezone values can cause navigation errors on synthetics
journeys.

3# How to test this PR locally

1. Build heartbeat docker image locally.
2. Create a journey that navigates to a Kibana URL.
3. Wait for Kibana login page to load properly.

(cherry picked from commit c09b949)
@mergify mergify bot mentioned this pull request Aug 4, 2023
Merged
emilioalvap added a commit that referenced this pull request Aug 4, 2023
@mergify @emilioalvap
[8.9](backport #36193) [Heartbeat] Add default TZ to heartbeat docker…
f64a87c 
… images (#36239)

This is an automatic backport of pull request #36193 done by
[Mergify](https://mergify.com).


---


<details>
<summary>Mergify commands and options</summary>

<br />

More conditions and actions can be found in the
[documentation](https://docs.mergify.com/).

You can also trigger Mergify actions by commenting on this pull request:

- `@Mergifyio refresh` will re-evaluate the rules
- `@Mergifyio rebase` will rebase this PR on its base branch
- `@Mergifyio update` will merge the base branch into this PR
- `@Mergifyio backport <destination>` will backport this PR on
`<destination>` branch

Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you
can:

- look at your merge queues
- generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com
</details>

Co-authored-by: Emilio Alvarez Piñeiro <95703246+emilioalvap@users.noreply.github.com>
@emilioalvap emilioalvap removed their assignment Aug 8, 2023
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
@emilioalvap @Scholar-Li
[Heartbeat] Add default TZ to heartbeat docker images (elastic#36193)
19c3b25 
## What does this PR do?

Fixes elastic#36117. Add default TZ
value to fix synthetic journeys for timezone-triggered errors.

## Why is it important?

Unspecified timezone values can cause navigation errors on synthetics
journeys.

3# How to test this PR locally

1. Build heartbeat docker image locally.
2. Create a journey that navigates to a Kibana URL.
3. Wait for Kibana login page to load properly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@belimawr belimawr belimawr approved these changes

@vigneshshanmugam vigneshshanmugam vigneshshanmugam approved these changes

@fearful-symmetry fearful-symmetry Awaiting requested review from fearful-symmetry fearful-symmetry is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees
No one assigned
Labels
backport-v8.9.0 Automated backport with mergify bug release-note:skip The PR should be ignored when processing the changelog Team:obs-ds-hosted-services Label for the Observability Hosted Services team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@emilioalvap @elasticmachine @belimawr @vigneshshanmugam