Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filebeat GCP input remove erroneous error log #36296

Merged
merged 3 commits into from Aug 14, 2023
Merged

Filebeat GCP input remove erroneous error log #36296

merged 3 commits into from Aug 14, 2023

Conversation

kgeller
Copy link
Contributor

@kgeller kgeller commented Aug 11, 2023 •
edited

Proposed commit message

Removing an erroneous error log that slipped in with the addition of input metrics to the gcp input.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@kgeller kgeller self-assigned this Aug 11, 2023
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Aug 11, 2023
@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 11, 2023 •
edited by jenkins-beats-ci bot

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-14T13:17:57.084+0000

  • Duration: 76 min 59 sec

Test stats 🧪

Test Results
Failed 0
Passed 3132
Skipped 176
Total 3308

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kgeller kgeller marked this pull request as ready for review August 11, 2023 15:05
@kgeller kgeller requested a review from a team as a code owner August 11, 2023 15:05
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

andrewkroh
andrewkroh approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog entry.

@kgeller kgeller merged commit 6b76cfe into elastic:main Aug 14, 2023
21 checks passed
@kgeller kgeller deleted the correct-error-log branch August 14, 2023 14:39
mergify bot pushed a commit that referenced this pull request Aug 14, 2023
@kgeller @mergify
Filebeat GCP input remove erroneous error log (#36296)
2c93cfa 
Removing an erroneous error log that slipped in with the addition of input metrics to the gcp input

(cherry picked from commit 6b76cfe)
@mergify mergify bot mentioned this pull request Aug 14, 2023
Merged
kgeller added a commit that referenced this pull request Aug 14, 2023
@mergify @kgeller
Filebeat GCP input remove erroneous error log (#36296) (#36314)
c51dfe3 
Removing an erroneous error log that slipped in with the addition of input metrics to the gcp input

(cherry picked from commit 6b76cfe)

Co-authored-by: Kylie Meli <kylie.geller@elastic.co>
@andrewkroh andrewkroh mentioned this pull request Aug 21, 2023
Closed
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
@kgeller @Scholar-Li
Filebeat GCP input remove erroneous error log (elastic#36296)
a06387b 
Removing an erroneous error log that slipped in with the addition of input metrics to the gcp input
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees

@kgeller kgeller

Labels
backport-v8.9.0 Automated backport with mergify cleanup Filebeat Filebeat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kgeller @elasticmachine @andrewkroh