Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x-pack/filebeat/input/httpjson: improve template evaluation logging #36668

Merged
merged 1 commit into from Sep 28, 2023
Merged

x-pack/filebeat/input/httpjson: improve template evaluation logging #36668

merged 1 commit into from Sep 28, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Sep 24, 2023

Proposed commit message

This adds valuable missing context to the debug logging emitted for template evaluation. Previously, only the final result was printed to the log, which failed to provide the information required to be able to determine why any given template was being executed. So add the target name to the logs.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 added enhancement Filebeat Filebeat Team:Security-External Integrations backport-skip Skip notification from the automated backport with mergify 8.11-candidate labels Sep 24, 2023
@efd6 efd6 self-assigned this Sep 24, 2023
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Sep 24, 2023
@efd6 efd6 force-pushed the 35432-httpjson-template-logging branch from 38301bb to 055a104 Compare September 24, 2023 21:24
@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 24, 2023 •
edited by jenkins-beats-ci bot

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-24T23:56:32.001+0000

  • Duration: 78 min 30 sec

Test stats 🧪

Test Results
Failed 0
Passed 3177
Skipped 174
Total 3351

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@efd6 efd6 marked this pull request as ready for review September 24, 2023 22:46
@efd6 efd6 requested a review from a team as a code owner September 24, 2023 22:46
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6
x-pack/filebeat/input/httpjson: improve template evaluation logging
9b150ba 
This adds valuable missing context to the debug logging emitted for
template evaluation. Previously, only the final result was printed to
the log, which failed to provide the information required to be able to
determine why any given template was being executed. So add the target
name to the logs.
@efd6 efd6 force-pushed the 35432-httpjson-template-logging branch from 055a104 to 9b150ba Compare September 24, 2023 23:56
marc-gr
marc-gr approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@marc-gr marc-gr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@efd6 efd6 merged commit 017b589 into elastic:main Sep 28, 2023
19 of 21 checks passed
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
@efd6 @Scholar-Li
x-pack/filebeat/input/httpjson: improve template evaluation logging (e…
e5d78b7 
…lastic#36668)

This adds valuable missing context to the debug logging emitted for
template evaluation. Previously, only the final result was printed to
the log, which failed to provide the information required to be able to
determine why any given template was being executed. So add the target
name to the logs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc-gr marc-gr marc-gr approved these changes

Assignees

@efd6 efd6

Labels
8.11-candidate backport-skip Skip notification from the automated backport with mergify enhancement Filebeat Filebeat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@efd6 @elasticmachine @marc-gr