Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x-pack/filebeat/input/httpjson: refactor/simplify package #35432

Closed
efd6 opened this issue May 11, 2023 · 1 comment
Closed

x-pack/filebeat/input/httpjson: refactor/simplify package #35432

efd6 opened this issue May 11, 2023 · 1 comment
Assignees

Comments

@efd6
Copy link
Contributor

efd6 commented May 11, 2023

The HTTPJSON input has grown to be unwieldy to maintain and debug. To address this we should refactor it to reduce the complication of the code.

Aspects to target:

  1. There is significant code non-locality, making it hard to reason about behaviour quickly. This includes similar code in single step processing v multi-step processing (the later derived from the former) living in variously in different files or adjacent.
  2. There is significant use of indirection that makes the code more opaque than is truly necessary.
  3. It is not clear that the use of concurrency provides a performance benefit and introduces the requirement for locking in a number of places, so look into transforming to sequential processing where possible.

ref: #34929

@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants