Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to elastic-agent-libs v0.6.2. #36969

Merged
merged 4 commits into from Oct 27, 2023

Conversation

cmacknz
Copy link
Member

@cmacknz cmacknz commented Oct 26, 2023

Increases the version of golang.org/x/net to one that has the HTTP2 rapid reset fix.

Increases the version of golang.org/x/net to one that has the HTTP2
rapid reset fix.
@cmacknz cmacknz self-assigned this Oct 26, 2023
@cmacknz cmacknz requested a review from a team as a code owner October 26, 2023 13:54
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 26, 2023
@cmacknz cmacknz added backport-v7.17.0 Automated backport with mergify backport-v8.11.0 Automated backport with mergify labels Oct 26, 2023
@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Oct 26, 2023
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 26, 2023
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 26, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 143 min 24 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@cmacknz
Copy link
Member Author

cmacknz commented Oct 26, 2023

/test x-pack/filebeat-pythonIntegTest

@cmacknz
Copy link
Member Author

cmacknz commented Oct 26, 2023

This commit is causing XPackTest.test_fileset_file_170_squid to fail.

It is reporting the following differences:

{
    "values_changed": {
        "root["url.subdomain"]":            {"new_value": "a1568",        "old_value": "a1568.g"}, 
        "root["url.top_level_domain"]":     {"new_value": "akamai.net",   "old_value": "net"}, 
        "root["server.registered_domain"]": {"new_value": "g.akamai.net", "old_value": "akamai.net"}, 
        "root["server.top_level_domain"]":  {"new_value": "akamai.net",   "old_value": "net"}, 
        "root["url.registered_domain"]":    {"new_value": "g.akamai.net", "old_value": "akamai.net"}, 
        "root["server.subdomain"]":         {"new_value": "a1568",        "old_value": "a1568.g"}
    }
}

My suspicion is the that it must be the golang.org/x/net update, so looking at the commits between releases golang/net@v0.12.0...v0.17.0 nothing immediately jumped out.

Looking at the squid module configuration I can see it makes heavy use of the registered_domain processor:

This processor does indeed depend directly on golang.org/x/net module that was changed between released:

Specifically I believe it is golang/net@1e23797 which updates the public domain table in the publicsuffix table.

That commit is mostly a set of large binary files but in the tests I see they are adding cases for akamai domains and several of the changes look similar to what I am observing here.

I am going to update the test data and add a changelog entry noting this.

@cmacknz cmacknz requested a review from a team as a code owner October 26, 2023 20:21
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this whitespace change expected?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessary, my editor must have added that automatically on save. Will remove.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has led me down a rabbit whole because both vim and VSCode are adding a trailing newline on save and won't let me remove it. I am just going to leave this here as long as the test passes rather than trying to find which editor configuration lets me remove it.

Copy link
Contributor

@efd6 efd6 Oct 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an entry in .editorconfig that enforces trailing newlines. This is almost always correct, but not with expected test outcome JSON files. I turn off editorconfig awareness in the editor I use because of this.

@cmacknz cmacknz merged commit ae11b47 into elastic:main Oct 27, 2023
117 checks passed
@cmacknz cmacknz deleted the bump-elastic-agent-libs branch October 27, 2023 17:13
mergify bot pushed a commit that referenced this pull request Oct 27, 2023
* Update to elastic-agent-libs v0.6.2.

Increases the version of golang.org/x/net to one that has the HTTP2
rapid reset fix.

* Add changelog entry.

* Updates for latest version of golang.org/x/net/publicsuffix

* Update all remaining subdomains

(cherry picked from commit ae11b47)

# Conflicts:
#	NOTICE.txt
#	go.mod
#	go.sum
mergify bot pushed a commit that referenced this pull request Oct 27, 2023
* Update to elastic-agent-libs v0.6.2.

Increases the version of golang.org/x/net to one that has the HTTP2
rapid reset fix.

* Add changelog entry.

* Updates for latest version of golang.org/x/net/publicsuffix

* Update all remaining subdomains

(cherry picked from commit ae11b47)

# Conflicts:
#	go.sum
cmacknz added a commit that referenced this pull request Oct 27, 2023
* Update to elastic-agent-libs v0.6.2. (#36969)

* Update to elastic-agent-libs v0.6.2.

Increases the version of golang.org/x/net to one that has the HTTP2
rapid reset fix.

* Add changelog entry.

* Updates for latest version of golang.org/x/net/publicsuffix

* Update all remaining subdomains

(cherry picked from commit ae11b47)

# Conflicts:
#	go.sum

* Resolve conflicts.

* Remove extra entries in CHANGELOG.next.asciidoc

---------

Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>
cmacknz added a commit that referenced this pull request Oct 30, 2023
* Update to elastic-agent-libs v0.6.2. (#36969)

* Update to elastic-agent-libs v0.6.2.

Increases the version of golang.org/x/net to one that has the HTTP2
rapid reset fix.

* Add changelog entry.

* Updates for latest version of golang.org/x/net/publicsuffix

* Update all remaining subdomains

(cherry picked from commit ae11b47)

# Conflicts:
#	NOTICE.txt
#	go.mod
#	go.sum

* Resolve conflicts.

* Remove extra entries in CHANGELOG.next.asciidoc

---------

Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
* Update to elastic-agent-libs v0.6.2.

Increases the version of golang.org/x/net to one that has the HTTP2
rapid reset fix.

* Add changelog entry.

* Updates for latest version of golang.org/x/net/publicsuffix

* Update all remaining subdomains
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.17.0 Automated backport with mergify backport-v8.11.0 Automated backport with mergify Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants