Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update setup.ilm.check_exists documentation #37430

Merged
merged 3 commits into from
Feb 13, 2024
Merged

Update setup.ilm.check_exists documentation #37430

merged 3 commits into from
Feb 13, 2024

Conversation

belimawr
Copy link
Contributor

Proposed commit message

This commit updates the documentation from setup.ilm.check_exists in our reference configuration files to better explain how it works and align the wording with our public documentation.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

## Author's Checklist
## How to test this PR locally

Related issue

## Use cases
## Screenshots
## Logs

@belimawr belimawr added the Team:Elastic-Agent Label for the Agent team label Dec 13, 2023
@belimawr belimawr requested review from a team as code owners December 13, 2023 07:40
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Dec 13, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 13, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @belimawr? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@belimawr belimawr mentioned this pull request Dec 13, 2023
Closed
@belimawr belimawr added backport-v7.17.0 Automated backport with mergify backport-v8.12.0 Automated backport with mergify labels Dec 13, 2023
@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 13, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2024-02-12T08:29:33.516+0000

  • Duration: 160 min 23 sec

Test stats 🧪

Test Results
Failed 0
Passed 28901
Skipped 2018
Total 30919

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@pierrehilbert
Copy link
Collaborator

@narph could we please have someone to review here?

@pierrehilbert
Copy link
Collaborator

Thanks @efd6 .
@belimawr this is now ready to be merged :-)

@narph narph added Team:Security-Service Integrations Security Service Integrations Team and removed Team:Security-External Integrations labels Feb 8, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@belimawr belimawr requested review from a team as code owners February 8, 2024 13:46
ycombinator
ycombinator approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a nitpick. LGTM - useful clarification about precedence for the user.

belimawr and others added 2 commits February 9, 2024 15:55
@belimawr
Update setup.ilm.check_exists documentation
24a31b2 
This commit updates the documentation from `setup.ilm.check_exists` in
our reference configuration files to better explain how it works and
align the wording with our public documentation.
@belimawr @ycombinator
Apply suggestions from code review
a0d232a 
Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com>
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @belimawr

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @belimawr

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @belimawr

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @belimawr

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @belimawr

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @belimawr

@belimawr belimawr requested a review from efd6 February 12, 2024 14:54
@pierrehilbert
Copy link
Collaborator

@nfritts / @andrewkroh could we please have someone to review here?

@belimawr belimawr enabled auto-merge (squash) February 13, 2024 08:27
@belimawr
Copy link
Contributor Author

I've enabled auto-merge, hopefully we can get this merged soon.

@belimawr belimawr merged commit 33ca67e into elastic:main Feb 13, 2024
154 checks passed
mergify bot pushed a commit that referenced this pull request Feb 13, 2024
@belimawr @mergify
Update setup.ilm.check_exists documentation (#37430)
e0e9a5b 
This commit updates the documentation from `setup.ilm.check_exists` in
our reference configuration files to better explain how it works and
align the wording with our public documentation.

---------

Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com>
(cherry picked from commit 33ca67e)
mergify bot pushed a commit that referenced this pull request Feb 13, 2024
@belimawr @mergify
Update setup.ilm.check_exists documentation (#37430)
3c2428a 
This commit updates the documentation from `setup.ilm.check_exists` in
our reference configuration files to better explain how it works and
align the wording with our public documentation.

---------

Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com>
(cherry picked from commit 33ca67e)

# Conflicts:
#	libbeat/idxmgmt/lifecycle/config.go
This was referenced Feb 13, 2024
Merged
Merged
pierrehilbert pushed a commit that referenced this pull request Feb 14, 2024
@mergify @belimawr
Update setup.ilm.check_exists documentation (#37430) (#38002)
ebebb4e 
This commit updates the documentation from `setup.ilm.check_exists` in
our reference configuration files to better explain how it works and
align the wording with our public documentation.

---------

Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com>
(cherry picked from commit 33ca67e)

Co-authored-by: Tiago Queiroz <tiago.queiroz@elastic.co>
belimawr added a commit that referenced this pull request Mar 7, 2024
@belimawr
Update setup.ilm.check_exists documentation (#37430)
5117546 
This commit updates the documentation from `setup.ilm.check_exists` in
our reference configuration files to better explain how it works and
align the wording with our public documentation.

---------

Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com>
(cherry picked from commit 33ca67e)

# Conflicts:
#	libbeat/idxmgmt/lifecycle/config.go
belimawr added a commit that referenced this pull request Mar 7, 2024
@mergify @belimawr
[7.17](backport #37430) Update setup.ilm.check_exists documentation (…
acc9c4b 
…#38001)

This commit updates the documentation from `setup.ilm.check_exists` in
our reference configuration files to better explain how it works and
align the wording with our public documentation.

---------

Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com>
(cherry picked from commit 33ca67e)

# Conflicts:
#	libbeat/idxmgmt/lifecycle/config.go

* Remove file that is not part of the original PR

---------

Co-authored-by: Tiago Queiroz <tiago.queiroz@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ycombinator ycombinator ycombinator approved these changes

@rdner rdner rdner approved these changes

@gizas gizas gizas approved these changes

@andrewkroh andrewkroh andrewkroh approved these changes

@efd6 efd6 Awaiting requested review from efd6

Assignees

@belimawr belimawr

Labels
backport-v7.17.0 Automated backport with mergify backport-v8.12.0 Automated backport with mergify Team:Elastic-Agent Label for the Agent team Team:Security-Service Integrations Security Service Integrations Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

metricbeat.reference.yml contradict the official documentation
9 participants
@belimawr @elasticmachine @pierrehilbert @ycombinator @rdner @gizas @andrewkroh @efd6 @narph