Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

packetbeat/docs: add documentation for ingest pipelines #37798

Merged
merged 2 commits into from Feb 1, 2024
Merged

packetbeat/docs: add documentation for ingest pipelines #37798

merged 2 commits into from Feb 1, 2024

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Jan 31, 2024 •
edited

Follow up for #37291 addressing #37291 (review).

Proposed commit message

See commit.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6
packetbeat/docs: add documentation for ingest pipelines
235c6bb 
Also fix typo in winlogbeat load-ingest-pipelines doc.
@efd6 efd6 requested a review from andrewkroh January 31, 2024 06:03
@efd6 efd6 self-assigned this Jan 31, 2024
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 31, 2024
@efd6 efd6 added the Team:Security-Service Integrations Security Service Integrations Team label Jan 31, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jan 31, 2024
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2024-01-31T06:03:32.821+0000

  • Duration: 8 min 29 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@efd6 efd6 marked this pull request as ready for review January 31, 2024 06:38
@efd6 efd6 requested review from a team as code owners January 31, 2024 06:38
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

andrewkroh
andrewkroh approved these changes Jan 31, 2024
View reviewed changes
packetbeat/docs/modules.asciidoc Outdated
comply with the {ecs-ref}/index.html[Elastic Common Schema] (ECS). The modules
may also apply additional categorization, tagging, and parsing as necessary.

NOTE: The provided modules only support events in English. For more information
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this relevant to Packetbeat? For Windows events the keys can vary by OS langauage. I don't think that applies here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will remove.

@efd6 efd6 enabled auto-merge (squash) January 31, 2024 23:17
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 9 min 48 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@efd6 efd6 mentioned this pull request Feb 1, 2024
Open
6 tasks
@efd6 efd6 merged commit 842c77c into elastic:main Feb 1, 2024
24 checks passed
mergify bot pushed a commit that referenced this pull request Feb 1, 2024
@efd6 @mergify
packetbeat/docs: add documentation for ingest pipelines (#37798)
04111f5 
Also fix typo in winlogbeat load-ingest-pipelines doc.

(cherry picked from commit 842c77c)
@mergify mergify bot mentioned this pull request Feb 1, 2024
Merged
efd6 added a commit that referenced this pull request Feb 1, 2024
@mergify @efd6
packetbeat/docs: add documentation for ingest pipelines (#37798) (#37815
c7ec8f6 
)

Also fix typo in winlogbeat load-ingest-pipelines doc.

(cherry picked from commit 842c77c)

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
@efd6 @Scholar-Li
packetbeat/docs: add documentation for ingest pipelines (elastic#37798)
3c925d0 
Also fix typo in winlogbeat load-ingest-pipelines doc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrmolin jrmolin jrmolin approved these changes

@andrewkroh andrewkroh andrewkroh approved these changes

@marc-gr marc-gr marc-gr approved these changes

Assignees

@efd6 efd6

Labels
backport-v8.12.0 Automated backport with mergify bugfix docs enhancement Packetbeat Team:Security-Service Integrations Security Service Integrations Team Winlogbeat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@efd6 @elasticmachine @jrmolin @andrewkroh @marc-gr