refactor conditions #37999

sharbuz · 2024-02-13T14:01:12Z

What is the problem this PR solves?

Jenkins->Buildkite pipelines migration

Refactor common conditions to simplify adding new pipelines

Examples of the affected pipelines:
https://buildkite.com/elastic/beats-libbeat/builds/1356#018da65f-3d77-4dc6-a2c0-0bbc5f7d54f4
https://buildkite.com/elastic/beats-metricbeat/builds/2570#018da65f-40e1-4bcf-b828-2b6b961c770a
https://buildkite.com/elastic/beats-packetbeat/builds/1350#018da65f-4cc7-40fe-86d7-52512d2c68e2
https://buildkite.com/elastic/beats-winlogbeat/builds/520#018da65f-23ab-4ff9-9742-4351fed8ed05

When the PR is approved to merge I'll remove trigger steps from the main pipeline

Related issues

https://github.com/elastic/ingest-dev/issues/1693

botelastic · 2024-02-13T14:01:24Z

This pull request doesn't have a Team:<team> label.

elasticmachine · 2024-02-13T14:07:33Z

💔 Tests Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2024-02-15T06:23:40.583+0000
Duration: 71 min 4 sec

Test stats 🧪

Test	Results
Failed	1
Passed	10077
Skipped	38
Total	10116

Test errors

Expand to view the tests failures

`Extended / libbeat-arm-ubuntu-2204-aarch64 / TestFQDNEventSync – github.com/elastic/beats/v7/libbeat/processors/add_host_metadata`

Expand to view the error details

 Failed

Expand to view the stacktrace

 === RUN   TestFQDNEventSync
    add_host_metadata_test.go:512: updated FQDN
    add_host_metadata_test.go:529: Waiting for runners to return...
    add_host_metadata_test.go:525: 
        	Error Trace:	/var/lib/jenkins/workspace/PR-37999-11-dd8f6bf5-ab06-4284-ba27-b6a82c96a6da/src/github.com/elastic/beats/libbeat/processors/add_host_metadata/add_host_metadata_test.go:525
        	            				/var/lib/jenkins/workspace/PR-37999-11-dd8f6bf5-ab06-4284-ba27-b6a82c96a6da/.gvm/versions/go1.21.7.linux.arm64/src/runtime/asm_arm64.s:1197
        	Error:      	Not equal: 
        	            	expected: "foo.bar.baz"
        	            	actual  : "beats-ci-immutable-ubuntu-2204-aarch64-1707980012738283354.a.elastic-prod.internal"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-foo.bar.baz
        	            	+beats-ci-immutable-ubuntu-2204-aarch64-1707980012738283354.a.elastic-prod.internal
        	Test:       	TestFQDNEventSync
    add_host_metadata_test.go:525: 
        	Error Trace:	/var/lib/jenkins/workspace/PR-37999-11-dd8f6bf5-ab06-4284-ba27-b6a82c96a6da/src/github.com/elastic/beats/libbeat/processors/add_host_metadata/add_host_metadata_test.go:525
        	            				/var/lib/jenkins/workspace/PR-37999-11-dd8f6bf5-ab06-4284-ba27-b6a82c96a6da/.gvm/versions/go1.21.7.linux.arm64/src/runtime/asm_arm64.s:1197
        	Error:      	Not equal: 
        	            	expected: "foo.bar.baz"
        	            	actual  : "beats-ci-immutable-ubuntu-2204-aarch64-1707980012738283354.a.elastic-prod.internal"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-foo.bar.baz
        	            	+beats-ci-immutable-ubuntu-2204-aarch64-1707980012738283354.a.elastic-prod.internal
        	Test:       	TestFQDNEventSync
    add_host_metadata_test.go:525: 
        	Error Trace:	/var/lib/jenkins/workspace/PR-37999-11-dd8f6bf5-ab06-4284-ba27-b6a82c96a6da/src/github.com/elastic/beats/libbeat/processors/add_host_metadata/add_host_metadata_test.go:525
        	            				/var/lib/jenkins/workspace/PR-37999-11-dd8f6bf5-ab06-4284-ba27-b6a82c96a6da/.gvm/versions/go1.21.7.linux.arm64/src/runtime/asm_arm64.s:1197
        	Error:      	Not equal: 
        	            	expected: "foo.bar.baz"
        	            	actual  : "beats-ci-immutable-ubuntu-2204-aarch64-1707980012738283354.a.elastic-prod.internal"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-foo.bar.baz
        	            	+beats-ci-immutable-ubuntu-2204-aarch64-1707980012738283354.a.elastic-prod.internal
        	Test:       	TestFQDNEventSync
    add_host_metadata_test.go:525: 
        	Error Trace:	/var/lib/jenkins/workspace/PR-37999-11-dd8f6bf5-ab06-4284-ba27-b6a82c96a6da/src/github.com/elastic/beats/libbeat/processors/add_host_metadata/add_host_metadata_test.go:525
        	            				/var/lib/jenkins/workspace/PR-37999-11-dd8f6bf5-ab06-4284-ba27-b6a82c96a6da/.gvm/versions/go1.21.7.linux.arm64/src/runtime/asm_arm64.s:1197
        	Error:      	Not equal: 
        	            	expected: "foo.bar.baz"
        	            	actual  : "beats-ci-immutable-ubuntu-2204-aarch64-1707980012738283354.a.elastic-prod.internal"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-foo.bar.baz
        	            	+beats-ci-immutable-ubuntu-2204-aarch64-1707980012738283354.a.elastic-prod.internal
        	Test:       	TestFQDNEventSync
    add_host_metadata_test.go:525: 
        	Error Trace:	/var/lib/jenkins/workspace/PR-37999-11-dd8f6bf5-ab06-4284-ba27-b6a82c96a6da/src/github.com/elastic/beats/libbeat/processors/add_host_metadata/add_host_metadata_test.go:525
        	            				/var/lib/jenkins/workspace/PR-37999-11-dd8f6bf5-ab06-4284-ba27-b6a82c96a6da/.gvm/versions/go1.21.7.linux.arm64/src/runtime/asm_arm64.s:1197
        	Error:      	Not equal: 
        	            	expected: "foo.bar.baz"
        	            	actual  : "beats-ci-immutable-ubuntu-2204-aarch64-1707980012738283354.a.elastic-prod.internal"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-foo.bar.baz
        	            	+beats-ci-immutable-ubuntu-2204-aarch64-1707980012738283354.a.elastic-prod.internal
        	Test:       	TestFQDNEventSync
    add_host_metadata_test.go:525: 
        	Error Trace:	/var/lib/jenkins/workspace/PR-37999-11-dd8f6bf5-ab06-4284-ba27-b6a82c96a6da/src/github.com/elastic/beats/libbeat/processors/add_host_metadata/add_host_metadata_test.go:525
        	            				/var/lib/jenkins/workspace/PR-37999-11-dd8f6bf5-ab06-4284-ba27-b6a82c96a6da/.gvm/versions/go1.21.7.linux.arm64/src/runtime/asm_arm64.s:1197
        	Error:      	Not equal: 
        	            	expected: "foo.bar.baz"
        	            	actual  : "beats-ci-immutable-ubuntu-2204-aarch64-1707980012738283354.a.elastic-prod.internal"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-foo.bar.baz
        	            	+beats-ci-immutable-ubuntu-2204-aarch64-1707980012738283354.a.elastic-prod.internal
        	Test:       	TestFQDNEventSync
    add_host_metadata_test.go:525: 
        	Error Trace:	/var/lib/jenkins/workspace/PR-37999-11-dd8f6bf5-ab06-4284-ba27-b6a82c96a6da/src/github.com/elastic/beats/libbeat/processors/add_host_metadata/add_host_metadata_test.go:525
        	            				/var/lib/jenkins/workspace/PR-37999-11-dd8f6bf5-ab06-4284-ba27-b6a82c96a6da/.gvm/versions/go1.21.7.linux.arm64/src/runtime/asm_arm64.s:1197
        	Error:      	Not equal: 
        	            	expected: "foo.bar.baz"
        	            	actual  : "beats-ci-immutable-ubuntu-2204-aarch64-1707980012738283354.a.elastic-prod.internal"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-foo.bar.baz
        	            	+beats-ci-immutable-ubuntu-2204-aarch64-1707980012738283354.a.elastic-prod.internal
        	Test:       	TestFQDNEventSync
    add_host_metadata_test.go:525: 
        	Error Trace:	/var/lib/jenkins/workspace/PR-37999-11-dd8f6bf5-ab06-4284-ba27-b6a82c96a6da/src/github.com/elastic/beats/libbeat/processors/add_host_metadata/add_host_metadata_test.go:525
        	            				/var/lib/jenkins/workspace/PR-37999-11-dd8f6bf5-ab06-4284-ba27-b6a82c96a6da/.gvm/versions/go1.21.7.linux.arm64/src/runtime/asm_arm64.s:1197
        	Error:      	Not equal: 
        	            	expected: "foo.bar.baz"
        	            	actual  : "beats-ci-immutable-ubuntu-2204-aarch64-1707980012738283354.a.elastic-prod.internal"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-foo.bar.baz
        	            	+beats-ci-immutable-ubuntu-2204-aarch64-1707980012738283354.a.elastic-prod.internal
        	Test:       	TestFQDNEventSync
    add_host_metadata_test.go:525: 
        	Error Trace:	/var/lib/jenkins/workspace/PR-37999-11-dd8f6bf5-ab06-4284-ba27-b6a82c96a6da/src/github.com/elastic/beats/libbeat/processors/add_host_metadata/add_host_metadata_test.go:525
        	            				/var/lib/jenkins/workspace/PR-37999-11-dd8f6bf5-ab06-4284-ba27-b6a82c96a6da/.gvm/versions/go1.21.7.linux.arm64/src/runtime/asm_arm64.s:1197
        	Error:      	Not equal: 
        	            	expected: "foo.bar.baz"
        	            	actual  : "beats-ci-immutable-ubuntu-2204-aarch64-1707980012738283354.a.elastic-prod.internal"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-foo.bar.baz
        	            	+beats-ci-immutable-ubuntu-2204-aarch64-1707980012738283354.a.elastic-prod.internal
        	Test:       	TestFQDNEventSync
    add_host_metadata_test.go:525: 
        	Error Trace:	/var/lib/jenkins/workspace/PR-37999-11-dd8f6bf5-ab06-4284-ba27-b6a82c96a6da/src/github.com/elastic/beats/libbeat/processors/add_host_metadata/add_host_metadata_test.go:525
        	            				/var/lib/jenkins/workspace/PR-37999-11-dd8f6bf5-ab06-4284-ba27-b6a82c96a6da/.gvm/versions/go1.21.7.linux.arm64/src/runtime/asm_arm64.s:1197
        	Error:      	Not equal: 
        	            	expected: "foo.bar.baz"
        	            	actual  : "beats-ci-immutable-ubuntu-2204-aarch64-1707980012738283354.a.elastic-prod.internal"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-foo.bar.baz
        	            	+beats-ci-immutable-ubuntu-2204-aarch64-1707980012738283354.a.elastic-prod.internal
        	Test:       	TestFQDNEventSync
coverage: 74.8% of statements
panic: test timed out after 10m0s
running tests:
	TestFQDNEventSync (10m0s)

goroutine 63 [running]:
testing.(*M).startAlarm.func1()
	/var/lib/jenkins/workspace/PR-37999-11-dd8f6bf5-ab06-4284-ba27-b6a82c96a6da/.gvm/versions/go1.21.7.linux.arm64/src/testing/testing.go:2259 +0x320
created by time.goFunc
	/var/lib/jenkins/workspace/PR-37999-11-dd8f6bf5-ab06-4284-ba27-b6a82c96a6da/.gvm/versions/go1.21.7.linux.arm64/src/time/sleep.go:176 +0x38

goroutine 1 [chan receive, 9 minutes]:
testing.(*T).Run(0x40002564e0, {0x125d346?, 0x1a4616e5cc6?}, 0x12aa750)
	/var/lib/jenkins/workspace/PR-37999-11-dd8f6bf5-ab06-4284-ba27-b6a82c96a6da/.gvm/versions/go1.21.7.linux.arm64/src/testing/testing.go:1649 +0x350
testing.runTests.func1(0x4000297d10?)
	/var/lib/jenkins/workspace/PR-37999-11-dd8f6bf5-ab06-4284-ba27-b6a82c96a6da/.gvm/versions/go1.21.7.linux.arm64/src/testing/testing.go:2054 +0x48
testing.tRunner(0x40002564e0, 0x40003dfc28)
	/var/lib/jenkins/workspace/PR-37999-11-dd8f6bf5-ab06-4284-ba27-b6a82c96a6da/.gvm/versions/go1.21.7.linux.arm64/src/testing/testing.go:1595 +0xe8
testing.runTests(0x400028b900?, {0x19c0b60, 0xa, 0xa}, {0x40?, 0x11c81a0?, 0x1b5ca60?})
	/var/lib/jenkins/workspace/PR-37999-11-dd8f6bf5-ab06-4284-ba27-b6a82c96a6da/.gvm/versions/go1.21.7.linux.arm64/src/testing/testing.go:2052 +0x3b4
testing.(*M).Run(0x400028b900)
	/var/lib/jenkins/workspace/PR-37999-11-dd8f6bf5-ab06-4284-ba27-b6a82c96a6da/.gvm/versions/go1.21.7.linux.arm64/src/testing/testing.go:1925 +0x538
main.main()
	_testmain.go:99 +0x1c8

goroutine 51 [semacquire, 9 minutes]:
sync.runtime_Semacquire(0x4000256820?)
	/var/lib/jenkins/workspace/PR-37999-11-dd8f6bf5-ab06-4284-ba27-b6a82c96a6da/.gvm/versions/go1.21.7.linux.arm64/src/runtime/sema.go:62 +0x2c
sync.(*WaitGroup).Wait(0x400043f110)
	/var/lib/jenkins/workspace/PR-37999-11-dd8f6bf5-ab06-4284-ba27-b6a82c96a6da/.gvm/versions/go1.21.7.linux.arm64/src/sync/waitgroup.go:116 +0x74
github.com/elastic/beats/v7/libbeat/processors/add_host_metadata.TestFQDNEventSync(0x400044f040)
	/var/lib/jenkins/workspace/PR-37999-11-dd8f6bf5-ab06-4284-ba27-b6a82c96a6da/src/github.com/elastic/beats/libbeat/processors/add_host_metadata/add_host_metadata_test.go:530 +0x55c
testing.tRunner(0x400044f040, 0x12aa750)
	/var/lib/jenkins/workspace/PR-37999-11-dd8f6bf5-ab06-4284-ba27-b6a82c96a6da/.gvm/versions/go1.21.7.linux.arm64/src/testing/testing.go:1595 +0xe8
created by testing.(*T).Run in goroutine 1
	/var/lib/jenkins/workspace/PR-37999-11-dd8f6bf5-ab06-4284-ba27-b6a82c96a6da/.gvm/versions/go1.21.7.linux.arm64/src/testing/testing.go:1648 +0x33c

goroutine 52 [IO wait, 9 minutes]:
internal/poll.runtime_pollWait(0xffff3c1c7f38, 0x72)
	/var/lib/jenkins/workspace/PR-37999-11-dd8f6bf5-ab06-4284-ba27-b6a82c96a6da/.gvm/versions/go1.21.7.linux.arm64/src/runtime/netpoll.go:343 +0xa0
internal/poll.(*pollDesc).wait(0x400043c580?, 0x883f2c?, 0x0)
	/var/lib/jenkins/workspace/PR-37999-11-dd8f6bf5-ab06-4284-ba27-b6a82c96a6da/.gvm/versions/go1.21.7.linux.arm64/src/internal/poll/fd_poll_runtime.go:84 +0x28
internal/poll.(*pollDesc).waitRead(...)
	/var/lib/jenkins/workspace/PR-37999-11-dd8f6bf5-ab06-4284-ba27-b6a82c96a6da/.gvm/versions/go1.21.7.linux.arm64/src/internal/poll/fd_poll_runtime.go:89
internal/poll.(*FD).Accept(0x400043c580)
	/var/lib/jenkins/workspace/PR-37999-11-dd8f6bf5-ab06-4284-ba27-b6a82c96a6da/.gvm/versions/go1.21.7.linux.arm64/src/internal/poll/fd_unix.go:611 +0x250
net.(*netFD).accept(0x400043c580)
	/var/lib/jenkins/workspace/PR-37999-11-dd8f6bf5-ab06-4284-ba27-b6a82c96a6da/.gvm/versions/go1.21.7.linux.arm64/src/net/fd_unix.go:172 +0x28
net.(*TCPListener).accept(0x40003e1740)
	/var/lib/jenkins/workspace/PR-37999-11-dd8f6bf5-ab06-4284-ba27-b6a82c96a6da/.gvm/versions/go1.21.7.linux.arm64/src/net/tcpsock_posix.go:152 +0x28
net.(*TCPListener).Accept(0x40003e1740)
	/var/lib/jenkins/workspace/PR-37999-11-dd8f6bf5-ab06-4284-ba27-b6a82c96a6da/.gvm/versions/go1.21.7.linux.arm64/src/net/tcpsock.go:315 +0x2c
github.com/miekg/dns.(*Server).serveTCP(0x4000259458, {0x1398640?, 0x40003e1740})
	/var/lib/jenkins/workspace/PR-37999-11-dd8f6bf5-ab06-4284-ba27-b6a82c96a6da/pkg/mod/github.com/miekg/dns@v1.1.42/server.go:445 +0xe4
github.com/miekg/dns.(*Server).ActivateAndServe(0x4000259458)
	/var/lib/jenkins/workspace/PR-37999-11-dd8f6bf5-ab06-4284-ba27-b6a82c96a6da/pkg/mod/github.com/miekg/dns@v1.1.42/server.go:363 +0x330
created by github.com/foxcpp/go-mockdns.NewServerWithLogger in goroutine 51
	/var/lib/jenkins/workspace/PR-37999-11-dd8f6bf5-ab06-4284-ba27-b6a82c96a6da/pkg/mod/github.com/foxcpp/go-mockdns@v0.0.0-20201212160233-ede2f9158d15/server.go:67 +0x214

goroutine 53 [IO wait]:
internal/poll.runtime_pollWait(0xffff3c1c7e40, 0x72)
	/var/lib/jenkins/workspace/PR-37999-11-dd8f6bf5-ab06-4284-ba27-b6a82c96a6da/.gvm/versions/go1.21.7.linux.arm64/src/runtime/netpoll.go:343 +0xa0
internal/poll.(*pollDesc).wait(0x400043c600?, 0x40004a6000?, 0x0)
	/var/lib/jenkins/workspace/PR-37999-11-dd8f6bf5-ab06-4284-ba27-b6a82c96a6da/.gvm/versions/go1.21.7.linux.arm64/src/internal/poll/fd_poll_runtime.go:84 +0x28
internal/poll.(*pollDesc).waitRead(...)
	/var/lib/jenkins/workspace/PR-37999-11-dd8f6bf5-ab06-4284-ba27-b6a82c96a6da/.gvm/versions/go1.21.7.linux.arm64/src/internal/poll/fd_poll_runtime.go:89
internal/poll.(*FD).ReadMsgInet4(0x400043c600, {0x40004a6000, 0x200, 0x200}, {0x4000040570, 0x28, 0x28}, 0x1?, 0x400049eb38?)
	/var/lib/jenkins/workspace/PR-37999-11-dd8f6bf5-ab06-4284-ba27-b6a82c96a6da/.gvm/versions/go1.21.7.linux.arm64/src/internal/poll/fd_unix.go:328 +0x254
net.(*netFD).readMsgInet4(0x400043c600, {0x40004a6000?, 0x400049eaf8?, 0x8867b4?}, {0x4000040570?, 0x836d54?, 0x400049eb18?}, 0x860b3c?, 0x400049eb58?)
	/var/lib/jenkins/workspace/PR-37999-11-dd8f6bf5-ab06-4284-ba27-b6a82c96a6da/.gvm/versions/go1.21.7.linux.arm64/src/net/fd_posix.go:84 +0x2c
net.(*UDPConn).readMsg(0xffff3c1c7e88?, {0x40004a6000?, 0x0?, 0x12aad00?}, {0x4000040570?, 0x836d54?, 0x12c?})
	/var/lib/jenkins/workspace/PR-37999-11-dd8f6bf5-ab06-4284-ba27-b6a82c96a6da/.gvm/versions/go1.21.7.linux.arm64/src/net/udpsock_posix.go:101 +0x124
net.(*UDPConn).ReadMsgUDPAddrPort(0x40001228e0, {0x40004a6000?, 0x30?, 0x400006c800?}, {0x4000040570?, 0x0?, 0x400049eca8?})
	/var/lib/jenkins/workspace/PR-37999-11-dd8f6bf5-ab06-4284-ba27-b6a82c96a6da/.gvm/versions/go1.21.7.linux.arm64/src/net/udpsock.go:203 +0x34
net.(*UDPConn).ReadMsgUDP(0x911730?, {0x40004a6000?, 0xc16b8d77f47eca39?, 0x8bc0e8f1bf?}, {0x4000040570?, 0x8bc780?, 0x400049ed38?})
	/var/lib/jenkins/workspace/PR-37999-11-dd8f6bf5-ab06-4284-ba27-b6a82c96a6da/.gvm/versions/go1.21.7.linux.arm64/src/net/udpsock.go:191 +0x24
github.com/miekg/dns.ReadFromSessionUDP(0x4000259640?, {0x40004a6000, 0x200, 0x200})
	/var/lib/jenkins/workspace/PR-37999-11-dd8f6bf5-ab06-4284-ba27-b6a82c96a6da/pkg/mod/github.com/miekg/dns@v1.1.42/udp.go:42 +0x74
github.com/miekg/dns.(*Server).readUDP(0x4000259560, 0x40001228e0, 0x400049ee01?)
	/var/lib/jenkins/workspace/PR-37999-11-dd8f6bf5-ab06-4284-ba27-b6a82c96a6da/pkg/mod/github.com/miekg/dns@v1.1.42/server.go:687 +0x158
github.com/miekg/dns.defaultReader.ReadUDP({0x4000259560?}, 0x1390fa0?, 0x400016edc0?)
	/var/lib/jenkins/workspace/PR-37999-11-dd8f6bf5-ab06-4284-ba27-b6a82c96a6da/pkg/mod/github.com/miekg/dns@v1.1.42/server.go:174 +0x1c
github.com/miekg/dns.(*Server).serveUDP(0x4000259560, {0x139ed30?, 0x40001228e0})
	/var/lib/jenkins/workspace/PR-37999-11-dd8f6bf5-ab06-4284-ba27-b6a82c96a6da/pkg/mod/github.com/miekg/dns@v1.1.42/server.go:501 +0x210
github.com/miekg/dns.(*Server).ActivateAndServe(0x4000259560)
	/var/lib/jenkins/workspace/PR-37999-11-dd8f6bf5-ab06-4284-ba27-b6a82c96a6da/pkg/mod/github.com/miekg/dns@v1.1.42/server.go:358 +0x2a0
created by github.com/foxcpp/go-mockdns.NewServerWithLogger in goroutine 51
	/var/lib/jenkins/workspace/PR-37999-11-dd8f6bf5-ab06-4284-ba27-b6a82c96a6da/pkg/mod/github.com/foxcpp/go-mockdns@v0.0.0-20201212160233-ede2f9158d15/server.go:68 +0x250

Steps errors

Expand to view the steps failures

`libbeat-arm-ubuntu-2204-aarch64 - mage build unitTest`

Took 13 min 4 sec . View more details here
Description: mage build unitTest

`libbeat-arm-ubuntu-2204-aarch64 - mage build unitTest`

Took 11 min 39 sec . View more details here
Description: mage build unitTest

`libbeat-arm-ubuntu-2204-aarch64 - mage build unitTest`

Took 11 min 38 sec . View more details here
Description: mage build unitTest

`Error signal`

Took 0 min 0 sec . View more details here
Description: Error 'hudson.AbortException: script returned exit code 1'

🐛 Flaky test report

❕ There are test failures but not known flaky tests.

Expand to view the summary

Genuine test errors

💔 There are test failures but not known flaky tests, most likely a genuine test failure.

Name: Extended / libbeat-arm-ubuntu-2204-aarch64 / TestFQDNEventSync – github.com/elastic/beats/v7/libbeat/processors/add_host_metadata

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

sharbuz · 2024-02-13T14:11:58Z

/test libbeat

v1v · 2024-02-14T09:49:05Z

.buildkite/pipeline.yml

+    async: true
+    build:
+      env:
+        BUILDKITE_REFSPEC: "refs/pull/${BUILDKITE_PULL_REQUEST}/head"


What's the plan for supporting branches?

When the PR is approved to merge I'll remove trigger steps from the main pipeline

I guess that's the answer

.buildkite/winlogbeat/pipeline.winlogbeat.yml

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>

dliappis

LGTM

dliappis · 2024-02-14T14:04:36Z

.buildkite/scripts/common.sh

+[ -z "${run_libbeat_arm_tests+x}" ] && run_libbeat_arm_tests="$(buildkite-agent meta-data get run_libbeat_arm_tests --default "false")"
+[ -z "${run_packetbeat_arm_tests+x}" ] && run_packetbeat_arm_tests="$(buildkite-agent meta-data get run_packetbeat_arm_tests --default "false")"
+[ -z "${run_metricbeat_macos_tests+x}" ] && run_metricbeat_macos_tests="$(buildkite-agent meta-data get run_metricbeat_macos_tests --default "false")"
+[ -z "${run_packetbeat_macos_tests+x}" ] && run_packetbeat_macos_tests="$(buildkite-agent meta-data get run_packetbeat_macos_tests --default "false")"


In a future PR, we should refactor this, such that if a user attempts to run this manually over ssh, it's enough to set one of the variables e.g. export run_libbeat=true to ensure only the corresponding test runs.

As it is now, if a user only sets export run_libbeat=true, the remaining code will invoke buildkite-agent meta-data get run_<beatname> which will fail when not run via Buildkite.

…b.com:sharbuz/beats into refactor-congitions-and-migrate-xpack-libbeat

elasticmachine · 2024-02-15T06:41:22Z

💚 Build Succeeded

Buildkite Build
Commit: 8b06e5d

History

💔 Build #1360 failed 57d3129
💔 Build #1357 failed fde8c2d
💛 Build #1339 was flaky f150e7c
💔 Build #1337 failed 7056bd6
💔 Build #1334 failed 5228fd4

cc @sharbuz

elasticmachine · 2024-02-15T06:43:07Z

💔 Build Failed

Buildkite Build
Commit: 8b06e5d

Failed CI Steps

:mac: MacOS Unit Tests

History

💚 Build #1677 succeeded 57d3129
💔 Build #1675 failed fde8c2d
💔 Build #1659 failed f150e7c
💚 Build #1658 succeeded 7056bd6
💔 Build #1656 failed 5228fd4

cc @sharbuz

elasticmachine · 2024-02-15T06:56:17Z

💚 Build Succeeded

Buildkite Build
Commit: 8b06e5d

History

💚 Build #1353 succeeded 57d3129
💚 Build #1350 succeeded fde8c2d
💚 Build #1332 succeeded f150e7c
💔 Build #1330 failed 7056bd6
💔 Build #1327 failed 5228fd4
💔 Build #1319 failed bd9e8a3

cc @sharbuz

elasticmachine · 2024-02-15T06:57:20Z

💚 Build Succeeded

Buildkite Build
Commit: 8b06e5d

History

💚 Build #524 succeeded 57d3129
💔 Build #521 failed fde8c2d
💚 Build #503 succeeded f150e7c
💚 Build #501 succeeded 7056bd6
💔 Build #498 failed 5228fd4
💚 Build #490 succeeded bd9e8a3

cc @sharbuz

elasticmachine · 2024-02-15T07:00:07Z

💔 Build Failed

Buildkite Build
Commit: 8b06e5d

Failed CI Steps

:mac: MacOS Unit Tests

History

💔 Build #3016 failed 57d3129
💔 Build #3014 failed fde8c2d
💔 Build #2998 failed f150e7c
💚 Build #2997 succeeded 7056bd6
💚 Build #2988 succeeded bd9e8a3

cc @sharbuz

elasticmachine · 2024-02-15T07:12:48Z

💚 Build Succeeded

Buildkite Build
Commit: 8b06e5d

History

💚 Build #2573 succeeded 57d3129
💛 Build #2570 was flaky fde8c2d
💔 Build #2552 failed f150e7c
💔 Build #2547 failed 5228fd4
💔 Build #2539 failed bd9e8a3
💔 Build #2537 failed c5881a2

cc @sharbuz

jlind23 · 2024-02-15T09:02:13Z

Transient test failures not related to the Pr hence force merging to unblock @sharbuz.
Cc @dliappis

(cherry picked from commit 4163848)

(cherry picked from commit 4163848) Co-authored-by: sharbuz <87968844+sharbuz@users.noreply.github.com>

refactor conditions

d545002

sharbuz added Packetbeat Winlogbeat libbeat Metricbeat Metricbeat x-pack Issues and pull requests for X-Pack features. backport-v7.17.0 Automated backport with mergify backport-v8.12.0 Automated backport with mergify labels Feb 13, 2024

sharbuz self-assigned this Feb 13, 2024

botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 13, 2024

change all pipelines

c7aa93e

sharbuz added 4 commits February 13, 2024 16:34

add-triggers

c5881a2

fix conditions

bd9e8a3

fix conditions

5228fd4

fix conditions

7056bd6

sharbuz added macOS Enable builds in the CI for darwin testing arm Enable builds in the CI for ARM testing labels Feb 13, 2024

sharbuz added 3 commits February 13, 2024 18:50

fix conditions

f150e7c

remove gh notifications and full test

a0e7db3

add empty line

fde8c2d

sharbuz requested review from dliappis and v1v February 14, 2024 08:07

sharbuz marked this pull request as ready for review February 14, 2024 08:30

sharbuz requested a review from a team as a code owner February 14, 2024 08:30

v1v reviewed Feb 14, 2024

View reviewed changes

.buildkite/winlogbeat/pipeline.winlogbeat.yml Outdated Show resolved Hide resolved

Update .buildkite/winlogbeat/pipeline.winlogbeat.yml

57d3129

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>

sharbuz requested a review from v1v February 14, 2024 10:21

v1v approved these changes Feb 14, 2024

View reviewed changes

dliappis approved these changes Feb 14, 2024

View reviewed changes

v1v added the backport-v8.13.0 Automated backport with mergify label Feb 14, 2024

sharbuz added 2 commits February 15, 2024 08:22

remove triggers from the main pipeline

635c57a

Merge branch 'refactor-congitions-and-migrate-xpack-libbeat' of githu…

8b06e5d

…b.com:sharbuz/beats into refactor-congitions-and-migrate-xpack-libbeat

jlind23 merged commit 4163848 into elastic:main Feb 15, 2024
35 of 40 checks passed

mergify bot pushed a commit that referenced this pull request Feb 15, 2024

refactor conditions (#37999)

1a7986d

(cherry picked from commit 4163848)

mergify bot mentioned this pull request Feb 15, 2024

[7.17](backport #37999) refactor conditions #38032

Merged

mergify bot pushed a commit that referenced this pull request Feb 15, 2024

refactor conditions (#37999)

2ba7881

(cherry picked from commit 4163848)

mergify bot pushed a commit that referenced this pull request Feb 15, 2024

refactor conditions (#37999)

20e227b

(cherry picked from commit 4163848)

This was referenced Feb 15, 2024

[8.12](backport #37999) refactor conditions #38033

Merged

[8.13](backport #37999) refactor conditions #38034

Merged

sharbuz added a commit that referenced this pull request Feb 15, 2024

refactor conditions (#37999) (#38032)

c299121

(cherry picked from commit 4163848) Co-authored-by: sharbuz <87968844+sharbuz@users.noreply.github.com>

sharbuz added a commit that referenced this pull request Feb 15, 2024

refactor conditions (#37999) (#38033)

0b71acf

(cherry picked from commit 4163848) Co-authored-by: sharbuz <87968844+sharbuz@users.noreply.github.com>

sharbuz added a commit that referenced this pull request Feb 15, 2024

refactor conditions (#37999) (#38034)

faabc0e

(cherry picked from commit 4163848) Co-authored-by: sharbuz <87968844+sharbuz@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor conditions #37999

refactor conditions #37999

sharbuz commented Feb 13, 2024 •

edited

botelastic bot commented Feb 13, 2024

elasticmachine commented Feb 13, 2024 •

edited

Build stats

Test stats 🧪

`Extended / libbeat-arm-ubuntu-2204-aarch64 / TestFQDNEventSync – github.com/elastic/beats/v7/libbeat/processors/add_host_metadata`

`libbeat-arm-ubuntu-2204-aarch64 - mage build unitTest`

`libbeat-arm-ubuntu-2204-aarch64 - mage build unitTest`

`libbeat-arm-ubuntu-2204-aarch64 - mage build unitTest`

`Error signal`

Genuine test errors

sharbuz commented Feb 13, 2024

v1v Feb 14, 2024

v1v Feb 14, 2024

dliappis left a comment

dliappis Feb 14, 2024 •

edited

elasticmachine commented Feb 15, 2024

elasticmachine commented Feb 15, 2024 •

edited

elasticmachine commented Feb 15, 2024

elasticmachine commented Feb 15, 2024

elasticmachine commented Feb 15, 2024 •

edited

elasticmachine commented Feb 15, 2024

jlind23 commented Feb 15, 2024

refactor conditions #37999

refactor conditions #37999

Conversation

sharbuz commented Feb 13, 2024 • edited

What is the problem this PR solves?

Related issues

botelastic bot commented Feb 13, 2024

elasticmachine commented Feb 13, 2024 • edited

💔 Tests Failed

Build stats

Test stats 🧪

Test errors

Extended / libbeat-arm-ubuntu-2204-aarch64 / TestFQDNEventSync – github.com/elastic/beats/v7/libbeat/processors/add_host_metadata

Steps errors

libbeat-arm-ubuntu-2204-aarch64 - mage build unitTest

libbeat-arm-ubuntu-2204-aarch64 - mage build unitTest

libbeat-arm-ubuntu-2204-aarch64 - mage build unitTest

Error signal

🐛 Flaky test report

Genuine test errors

🤖 GitHub comments

sharbuz commented Feb 13, 2024

v1v Feb 14, 2024

Choose a reason for hiding this comment

v1v Feb 14, 2024

Choose a reason for hiding this comment

dliappis left a comment

Choose a reason for hiding this comment

dliappis Feb 14, 2024 • edited

Choose a reason for hiding this comment

elasticmachine commented Feb 15, 2024

💚 Build Succeeded

History

elasticmachine commented Feb 15, 2024 • edited

💔 Build Failed

Failed CI Steps

History

elasticmachine commented Feb 15, 2024

💚 Build Succeeded

History

elasticmachine commented Feb 15, 2024

💚 Build Succeeded

History

elasticmachine commented Feb 15, 2024 • edited

💔 Build Failed

Failed CI Steps

History

elasticmachine commented Feb 15, 2024

💚 Build Succeeded

History

jlind23 commented Feb 15, 2024

sharbuz commented Feb 13, 2024 •

edited

elasticmachine commented Feb 13, 2024 •

edited

`Extended / libbeat-arm-ubuntu-2204-aarch64 / TestFQDNEventSync – github.com/elastic/beats/v7/libbeat/processors/add_host_metadata`

`libbeat-arm-ubuntu-2204-aarch64 - mage build unitTest`

`libbeat-arm-ubuntu-2204-aarch64 - mage build unitTest`

`libbeat-arm-ubuntu-2204-aarch64 - mage build unitTest`

`Error signal`

dliappis Feb 14, 2024 •

edited

elasticmachine commented Feb 15, 2024 •

edited

elasticmachine commented Feb 15, 2024 •

edited