Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Heartbeat] Fix reference yaml format #38584

Merged
merged 5 commits into from Mar 27, 2024

Conversation

emilioalvap
Copy link
Collaborator

@emilioalvap emilioalvap commented Mar 25, 2024

Proposed commit message

Fix heartbeat.reference.yml incorrect formatting.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@emilioalvap emilioalvap added docs Team:obs-ds-hosted-services Label for the Observability Hosted Services team v8.12.0 labels Mar 25, 2024
@emilioalvap emilioalvap requested a review from a team as a code owner March 25, 2024 09:41
@elasticmachine
Copy link
Collaborator

Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Mar 25, 2024
Copy link
Contributor

mergify bot commented Mar 25, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @emilioalvap? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@emilioalvap emilioalvap added backport-v8.12.0 Automated backport with mergify backport-v8.13.0 Automated backport with mergify labels Mar 25, 2024
@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 25, 2024

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 53 min 2 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

@devcorpio devcorpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emilioalvap how did we catch this bug? is there any context available?

@emilioalvap
Copy link
Collaborator Author

@devcorpio mainly a discuss forum: https://discuss.elastic.co/t/heartbeat-reference-documentation-has-extra-syntax/355925

@emilioalvap emilioalvap merged commit 4305f30 into elastic:main Mar 27, 2024
46 of 47 checks passed
mergify bot pushed a commit that referenced this pull request Mar 27, 2024
Fix heartbeat.reference.yml incorrect formatting.

(cherry picked from commit 4305f30)
mergify bot pushed a commit that referenced this pull request Mar 27, 2024
Fix heartbeat.reference.yml incorrect formatting.

(cherry picked from commit 4305f30)
vigneshshanmugam pushed a commit that referenced this pull request Mar 27, 2024
Fix heartbeat.reference.yml incorrect formatting.

(cherry picked from commit 4305f30)

Co-authored-by: Emilio Alvarez Piñeiro <95703246+emilioalvap@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.12.0 Automated backport with mergify backport-v8.13.0 Automated backport with mergify docs Team:obs-ds-hosted-services Label for the Observability Hosted Services team v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants