Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to min_events in bulk_max_size docs. #38634

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

cmacknz
Copy link
Member

@cmacknz cmacknz commented Mar 26, 2024

As of https://github.com/elastic/beats/pull/37795/files in 8.13.0 queue.flush.min_events is no longer relevant.

@cmacknz cmacknz added Team:Elastic-Agent Label for the Agent team backport-v8.13.0 Automated backport with mergify labels Mar 26, 2024
@cmacknz cmacknz requested a review from faec March 26, 2024 20:31
@cmacknz cmacknz self-assigned this Mar 26, 2024
@cmacknz cmacknz requested a review from a team as a code owner March 26, 2024 20:31
@cmacknz cmacknz requested a review from belimawr March 26, 2024 20:31
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Mar 26, 2024
@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 26, 2024

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 9 min 41 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Collaborator

@pierrehilbert pierrehilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small fix but good to go. Thanks for taking care of this.

Co-authored-by: Pierre HILBERT <pierre.hilbert@elastic.co>
@cmacknz cmacknz enabled auto-merge (squash) March 26, 2024 20:47
@cmacknz cmacknz merged commit 989d36f into elastic:main Mar 26, 2024
36 of 44 checks passed
mergify bot pushed a commit that referenced this pull request Mar 26, 2024
* Remove references to min_events in bulk_max_size docs.

As of https://github.com/elastic/beats/pull/37795/files in 8.13.0
queue.flush.min_events is no longer relevant.

* Fix whitespace

Co-authored-by: Pierre HILBERT <pierre.hilbert@elastic.co>

---------

Co-authored-by: Pierre HILBERT <pierre.hilbert@elastic.co>
(cherry picked from commit 989d36f)
pierrehilbert pushed a commit that referenced this pull request Mar 27, 2024
* Remove references to min_events in bulk_max_size docs.

As of https://github.com/elastic/beats/pull/37795/files in 8.13.0
queue.flush.min_events is no longer relevant.

* Fix whitespace

Co-authored-by: Pierre HILBERT <pierre.hilbert@elastic.co>

---------

Co-authored-by: Pierre HILBERT <pierre.hilbert@elastic.co>
(cherry picked from commit 989d36f)

Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>
@cmacknz cmacknz deleted the update-bulk-max-size-docs branch March 27, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.13.0 Automated backport with mergify Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants