Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.17](backport #38047) security: add permissions block to workflows #38649

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 27, 2024

Details

⚠️ This PR was created by an automated tool. Please review the changes carefully. ⚠️

We want to set the default permissions for workflows to read-only for contents.
This is a security measure to prevent accidental changes to the repository.

This change adds a top-level permissions block to all workflows in the .github/workflows directory.

permissions:
  contents: read

In some cases workflows might need more permissions than just contents: read.
Please checkout this branch and add the necessary permissions to the workflows.

If your workflow uses a Personal Access Token (PAT), we can still add the permissions block,
but it will not have any effect.

Merging this PR as is might cause workflows that need more permissions to fail.

If there are any questions, please reach out to the @elastic/observablt-ci


This is an automatic backport of pull request #38047 done by [Mergify](https://mergify.com).

(cherry picked from commit f502623)

# Conflicts:
#	.github/workflows/platform-ingest-project-board.yml
#	.github/workflows/post-dependabot.yml
@mergify mergify bot requested a review from a team as a code owner March 27, 2024 08:55
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Mar 27, 2024
@mergify mergify bot requested review from ycombinator and rdner and removed request for a team March 27, 2024 08:55
Copy link
Contributor Author

mergify bot commented Mar 27, 2024

Cherry-pick of f502623 has failed:

On branch mergify/bp/7.17/pr-38047
Your branch is up to date with 'origin/7.17'.

You are currently cherry-picking commit f502623a2f.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .github/workflows/check-audtibeat.yml
	modified:   .github/workflows/check-dev-tools.yml
	modified:   .github/workflows/check-filebeat.yml
	modified:   .github/workflows/check-heartbeat.yml
	modified:   .github/workflows/check-libbeat.yml
	modified:   .github/workflows/check-metricbeat.yml
	modified:   .github/workflows/check-packetbeat.yml
	modified:   .github/workflows/check-winlogbeat.yml
	modified:   .github/workflows/check-xpack-auditbeat.yml
	modified:   .github/workflows/check-xpack-dockerlogbeat.yml
	modified:   .github/workflows/check-xpack-filebeat.yml
	modified:   .github/workflows/check-xpack-functionbeat.yml
	modified:   .github/workflows/check-xpack-heartbeat.yml
	modified:   .github/workflows/check-xpack-libbeat.yml
	modified:   .github/workflows/check-xpack-metricbeat.yml
	modified:   .github/workflows/check-xpack-osquerybeat.yml
	modified:   .github/workflows/check-xpack-packetbeat.yml
	modified:   .github/workflows/check-xpack-winlogbeat.yml
	modified:   .github/workflows/macos-auditbeat.yml
	modified:   .github/workflows/macos-filebeat.yml
	modified:   .github/workflows/macos-heartbeat.yml
	modified:   .github/workflows/macos-metricbeat.yml
	modified:   .github/workflows/macos-packetbeat.yml
	modified:   .github/workflows/macos-xpack-auditbeat.yml
	modified:   .github/workflows/macos-xpack-filebeat.yml
	modified:   .github/workflows/macos-xpack-functionbeat.yml
	modified:   .github/workflows/macos-xpack-heartbeat.yml
	modified:   .github/workflows/macos-xpack-metricbeat.yml
	modified:   .github/workflows/macos-xpack-osquerybeat.yml
	modified:   .github/workflows/macos-xpack-packetbeat.yml

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   .github/workflows/platform-ingest-project-board.yml
	deleted by us:   .github/workflows/post-dependabot.yml

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 27, 2024
@botelastic
Copy link

botelastic bot commented Mar 27, 2024

This pull request doesn't have a Team:<team> label.

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 16 min 50 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor Author

mergify bot commented Apr 1, 2024

This pull request has not been merged yet. Could you please review and merge it @reakaleek? 🙏

@v1v
Copy link
Member

v1v commented Apr 1, 2024

There is no need to backport it.

@v1v v1v closed this Apr 1, 2024
@mergify mergify bot deleted the mergify/bp/7.17/pr-38047 branch April 1, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport conflicts There is a conflict in the backported pull request needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants