Force package target to download acs file from manifest

[pazone]

Proposed commit message

For unknown reason the asc_url disappeared from manifest file
Quick fix: Forces the package target to download the .asc file even if it's not listed in the manifest.

Checklist

• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have made corresponding change to the default configuration files
• I have added tests that prove my fix is effective or that my feature works
• I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

[botelastic]

This pull request doesn't have a Team:<team> label.

[elasticmachine]

💔 Tests Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Start Time: 2024-04-09T12:07:12.317+0000

• Duration: 111 min 45 sec

Test stats 🧪

Test	Results
Failed	1
Passed	20613
Skipped	1422
Total	22036

Test errors

Expand to view the tests failures

Build&Test / metricbeat-pythonIntegTest / test_remote_write – metricbeat.module.prometheus.test_prometheus.TestRemoteWrite

Expand to view the error details

 failed on setup with "docker.errors.InvalidArgument: "host" network_mode is incompatible with port_bindings" 

Expand to view the stacktrace

 self = <class 'test_prometheus.TestRemoteWrite'>

    @classmethod
    def setUpClass(self):
        if not hasattr(self, 'beat_name'):
            self.beat_name = "metricbeat"
    
        if not hasattr(self, 'beat_path'):
            self.beat_path = os.path.abspath(os.path.join(os.path.dirname(__file__), "../../"))
    
>       super(BaseTest, self).setUpClass()

tests/system/metricbeat.py:28: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
../libbeat/tests/system/beat/beat.py:163: in setUpClass
    self.compose_up_with_retries()
../libbeat/tests/system/beat/beat.py:178: in compose_up_with_retries
    raise e
../libbeat/tests/system/beat/beat.py:174: in compose_up_with_retries
    self.compose_up()
../libbeat/tests/system/beat/compose.py:66: in compose_up
    project.up(
/opt/venv/lib/python3.11/site-packages/compose/project.py:697: in up
    results, errors = parallel.parallel_execute(
/opt/venv/lib/python3.11/site-packages/compose/parallel.py:108: in parallel_execute
    raise error_to_reraise
/opt/venv/lib/python3.11/site-packages/compose/parallel.py:206: in producer
    result = func(obj)
/opt/venv/lib/python3.11/site-packages/compose/project.py:679: in do
    return service.execute_convergence_plan(
/opt/venv/lib/python3.11/site-packages/compose/service.py:559: in execute_convergence_plan
    return self._execute_convergence_create(
/opt/venv/lib/python3.11/site-packages/compose/service.py:473: in _execute_convergence_create
    containers, errors = parallel_execute(
/opt/venv/lib/python3.11/site-packages/compose/parallel.py:108: in parallel_execute
    raise error_to_reraise
/opt/venv/lib/python3.11/site-packages/compose/parallel.py:206: in producer
    result = func(obj)
/opt/venv/lib/python3.11/site-packages/compose/service.py:478: in <lambda>
    lambda service_name: create_and_start(self, service_name.number),
/opt/venv/lib/python3.11/site-packages/compose/service.py:457: in create_and_start
    container = service.create_container(number=n, quiet=True)
/opt/venv/lib/python3.11/site-packages/compose/service.py:330: in create_container
    container_options = self._get_container_create_options(
/opt/venv/lib/python3.11/site-packages/compose/service.py:939: in _get_container_create_options
    container_options['host_config'] = self._get_container_host_config(
/opt/venv/lib/python3.11/site-packages/compose/service.py:1014: in _get_container_host_config
    return self.client.create_host_config(
/opt/venv/lib/python3.11/site-packages/docker/api/container.py:608: in create_host_config
    return HostConfig(*args, **kwargs)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = {}, version = '1.45', binds = [], port_bindings = {'9090/tcp': [None]}
lxc_conf = None, publish_all_ports = False, links = [], privileged = False
dns = None, dns_search = None, volumes_from = [], network_mode = 'host'
restart_policy = None, cap_add = None, cap_drop = None, devices = None
extra_hosts = None, read_only = None, pid_mode = None, ipc_mode = None
security_opt = None, ulimits = None, log_config = {'Type': '', 'Config': {}}
mem_limit = None, memswap_limit = None, mem_reservation = None
kernel_memory = None, mem_swappiness = None, cgroup_parent = None
group_add = None, cpu_quota = None, cpu_period = None, blkio_weight = None
blkio_weight_device = None, device_read_bps = None, device_write_bps = None
device_read_iops = None, device_write_iops = None, oom_kill_disable = None
shm_size = None, sysctls = None, tmpfs = None, oom_score_adj = None
dns_opt = None, cpu_shares = None, cpuset_cpus = None, userns_mode = None
uts_mode = None, pids_limit = None, isolation = None, auto_remove = False
storage_opt = None, init = None, init_path = None, volume_driver = None
cpu_count = None, cpu_percent = None, nano_cpus = None, cpuset_mems = None
runtime = None, mounts = None, cpu_rt_period = None, cpu_rt_runtime = None
device_cgroup_rules = None, device_requests = None, cgroupns = None

    def __init__(self, version, binds=None, port_bindings=None,
                 lxc_conf=None, publish_all_ports=False, links=None,
                 privileged=False, dns=None, dns_search=None,
                 volumes_from=None, network_mode=None, restart_policy=None,
                 cap_add=None, cap_drop=None, devices=None, extra_hosts=None,
                 read_only=None, pid_mode=None, ipc_mode=None,
                 security_opt=None, ulimits=None, log_config=None,
                 mem_limit=None, memswap_limit=None, mem_reservation=None,
                 kernel_memory=None, mem_swappiness=None, cgroup_parent=None,
                 group_add=None, cpu_quota=None, cpu_period=None,
                 blkio_weight=None, blkio_weight_device=None,
                 device_read_bps=None, device_write_bps=None,
                 device_read_iops=None, device_write_iops=None,
                 oom_kill_disable=False, shm_size=None, sysctls=None,
                 tmpfs=None, oom_score_adj=None, dns_opt=None, cpu_shares=None,
                 cpuset_cpus=None, userns_mode=None, uts_mode=None,
                 pids_limit=None, isolation=None, auto_remove=False,
                 storage_opt=None, init=None, init_path=None,
                 volume_driver=None, cpu_count=None, cpu_percent=None,
                 nano_cpus=None, cpuset_mems=None, runtime=None, mounts=None,
                 cpu_rt_period=None, cpu_rt_runtime=None,
                 device_cgroup_rules=None, device_requests=None,
                 cgroupns=None):
    
        if mem_limit is not None:
            self['Memory'] = parse_bytes(mem_limit)
    
        if memswap_limit is not None:
            self['MemorySwap'] = parse_bytes(memswap_limit)
    
        if mem_reservation:
            self['MemoryReservation'] = parse_bytes(mem_reservation)
    
        if kernel_memory:
            self['KernelMemory'] = parse_bytes(kernel_memory)
    
        if mem_swappiness is not None:
            if not isinstance(mem_swappiness, int):
                raise host_config_type_error(
                    'mem_swappiness', mem_swappiness, 'int'
                )
    
            self['MemorySwappiness'] = mem_swappiness
    
        if shm_size is not None:
            if isinstance(shm_size, str):
                shm_size = parse_bytes(shm_size)
    
            self['ShmSize'] = shm_size
    
        if pid_mode:
            if version_lt(version, '1.24') and pid_mode != 'host':
                raise host_config_value_error('pid_mode', pid_mode)
            self['PidMode'] = pid_mode
    
        if ipc_mode:
            self['IpcMode'] = ipc_mode
    
        if privileged:
            self['Privileged'] = privileged
    
        if oom_kill_disable:
            self['OomKillDisable'] = oom_kill_disable
    
        if oom_score_adj:
            if version_lt(version, '1.22'):
                raise host_config_version_error('oom_score_adj', '1.22')
            if not isinstance(oom_score_adj, int):
                raise host_config_type_error(
                    'oom_score_adj', oom_score_adj, 'int'
                )
            self['OomScoreAdj'] = oom_score_adj
    
        if publish_all_ports:
            self['PublishAllPorts'] = publish_all_ports
    
        if read_only is not None:
            self['ReadonlyRootfs'] = read_only
    
        if dns_search:
            self['DnsSearch'] = dns_search
    
        if network_mode == 'host' and port_bindings:
>           raise host_config_incompatible_error(
                'network_mode', 'host', 'port_bindings'
            )
E           docker.errors.InvalidArgument: "host" network_mode is incompatible with port_bindings

/opt/venv/lib/python3.11/site-packages/docker/types/containers.py:337: InvalidArgument 

Steps errors

Expand to view the steps failures

libbeat-pythonIntegTest - mage pythonIntegTest

• Took 7 min 41 sec . View more details here
• Description: mage pythonIntegTest

metricbeat-pythonIntegTest - mage pythonIntegTest

• Took 31 min 49 sec . View more details here
• Description: mage pythonIntegTest

metricbeat-pythonIntegTest - mage pythonIntegTest

• Took 21 min 41 sec . View more details here
• Description: mage pythonIntegTest

metricbeat-pythonIntegTest - mage pythonIntegTest

• Took 20 min 20 sec . View more details here
• Description: mage pythonIntegTest

Error signal

• Took 0 min 0 sec . View more details here
• Description: Error 'hudson.AbortException: script returned exit code 1'

🐛 Flaky test report

❕ There are test failures but not known flaky tests.

Expand to view the summary

Genuine test errors

💔 There are test failures but not known flaky tests, most likely a genuine test failure.

• Name: Build&Test / metricbeat-pythonIntegTest / test_remote_write – metricbeat.module.prometheus.test_prometheus.TestRemoteWrite

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

• /test : Re-trigger the build.

• /package : Generate the packages and run the E2E tests.

• /beats-tester : Run the installation tests with beats-tester.

• run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

[cmacknz]

For unknown reason the asc_url disappeared from manifest file

Shouldn't we fix this first rather than hacking around it here?

[pazone]

@cmacknz True. It was fixed by a correct manifestURL. Now I'm trying to understand why the asc files are not in the artifact list

[mergify]

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b acs_filies_quick_fix upstream/acs_filies_quick_fix
git merge upstream/7.17
git push upstream acs_filies_quick_fix