Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x-pack/filebeat/module/salesforce: Remove dashboards #39028

Merged
merged 10 commits into from
May 16, 2024

Conversation

kush-elastic
Copy link
Collaborator

@kush-elastic kush-elastic commented Apr 18, 2024

Description

This PR aims to remove dashboards from the recently revamped Salesforce module. The plan is to discontinue support for dashboards created in version 7.15.0, as the overall Beats framework has ceased support for version 8.X.X dashboards.

For the newer dashboards, support will continue in the upcoming revamp of the Salesforce Integration, ensuring that the latest features and functionalities are available for users.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@kush-elastic kush-elastic requested a review from a team as a code owner April 18, 2024 06:29
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 18, 2024
@kush-elastic kush-elastic self-assigned this Apr 18, 2024
@kush-elastic kush-elastic added module :Dashboards Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team labels Apr 18, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Apr 18, 2024
@kush-elastic kush-elastic added Filebeat Filebeat needs_team Indicates that the issue/PR needs a Team:* label labels Apr 18, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Apr 18, 2024
@botelastic
Copy link

botelastic bot commented Apr 18, 2024

This pull request doesn't have a Team:<team> label.

Copy link
Contributor

mergify bot commented Apr 18, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @kush-elastic? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 18, 2024

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 159 min 56 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@shmsr shmsr changed the title x-pack/filebeat/module/salesforce: Remove dashbaords from a Salesforce module x-pack/filebeat/module/salesforce: Remove dashbaords from the Salesforce module Apr 18, 2024
CHANGELOG.next.asciidoc Outdated Show resolved Hide resolved
@shmsr shmsr changed the title x-pack/filebeat/module/salesforce: Remove dashbaords from the Salesforce module x-pack/filebeat/module/salesforce: Remove dashboards Apr 18, 2024
CHANGELOG.next.asciidoc Outdated Show resolved Hide resolved
Copy link
Member

@shmsr shmsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove the changelog and the rest looks good.

@kush-elastic
Copy link
Collaborator Author

Hey @tommyers-elastic,
We need your approval on this PR as part of removing dashboards from Salesforce module.

@kush-elastic kush-elastic merged commit c7829d3 into elastic:main May 16, 2024
50 checks passed
@kush-elastic kush-elastic added the backport-v8.14.0 Automated backport with mergify label May 17, 2024
mergify bot pushed a commit that referenced this pull request May 17, 2024
* Remove dashboards from salesforce revamped module

* remove dashboards screenshots

* Add changelog entry

* update docs

* Update CHANGELOG.next.asciidoc

Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>

* fix docs

* remove changelog entry

---------

Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>
Co-authored-by: subham sarkar <subham.sarkar@elastic.co>
(cherry picked from commit c7829d3)
@kush-elastic kush-elastic added backport-v8.14.0 Automated backport with mergify and removed backport-v8.14.0 Automated backport with mergify labels May 31, 2024
kush-elastic added a commit that referenced this pull request May 31, 2024
* Remove dashboards from salesforce revamped module

* remove dashboards screenshots

* Add changelog entry

* update docs

* Update CHANGELOG.next.asciidoc

Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>

* fix docs

* remove changelog entry

---------

Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>
Co-authored-by: subham sarkar <subham.sarkar@elastic.co>
(cherry picked from commit c7829d3)

Co-authored-by: Kush Rana <89848966+kush-elastic@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.14.0 Automated backport with mergify :Dashboards Filebeat Filebeat module Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants