Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Auditbeat] Remove temporary "ReplaceFields" config option #39134

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

mjwolf
Copy link
Contributor

@mjwolf mjwolf commented Apr 22, 2024

Proposed commit message

Remove the "ReplaceFields" config option from the 'add_session_metadata' processor in Auditbeat. This was always intended to be a temporary config option, that allowed use of the Kibana session viewer, before the Kibana feature was fully developed.

The Kibana changes are now done, so this processor option is no longer needed.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc. This was developer only option, on a feature that's not GA, so I don't think it needs a changelog entry

Related issues

The ReplaceFields config option was used to support compatibility with session
viewer in Kibana that didn't support auditbeat fields. Kibana has now been
updated, and this config option isn't needed.
@mjwolf mjwolf requested a review from a team as a code owner April 22, 2024 15:39
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 22, 2024
@mjwolf mjwolf added the Team:Security-Linux Platform Linux Platform Team in Security Solution label Apr 22, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Apr 22, 2024
@mergify mergify bot assigned mjwolf Apr 22, 2024
Copy link
Contributor

mergify bot commented Apr 22, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @mjwolf? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

@pkoutsovasilis pkoutsovasilis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 43 min 24 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@mjwolf mjwolf merged commit b34334f into elastic:main Apr 22, 2024
32 checks passed
@mjwolf mjwolf added the backport-v8.14.0 Automated backport with mergify label Apr 23, 2024
mergify bot pushed a commit that referenced this pull request Apr 23, 2024
The ReplaceFields config option was used to support compatibility with session
viewer in Kibana that didn't support auditbeat fields. Kibana has now been
updated, and this config option isn't needed.

(cherry picked from commit b34334f)
mjwolf added a commit that referenced this pull request Apr 23, 2024
…) (#39168)

The ReplaceFields config option was used to support compatibility with session
viewer in Kibana that didn't support auditbeat fields. Kibana has now been
updated, and this config option isn't needed.

(cherry picked from commit b34334f)

Co-authored-by: Michael Wolf <michael.wolf@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.14.0 Automated backport with mergify enhancement Team:Security-Linux Platform Linux Platform Team in Security Solution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants