Ensure ordered DRA artifacts #39270
Merged
Ensure ordered DRA artifacts #39270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
needs_team
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
As things are now we allow parallel builds on the packaging pipeline, which would result in out of order artifacts (depending on which one takes longer to finish). This commit leverages a queue to ensure a FIFO queue for DRA artifacts.
dliappis
force-pushed
the
fix-out-of-order-dra-artifacts
branch
from
73e0a93
to
482b87c
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
dliappis
force-pushed
the
fix-out-of-order-dra-artifacts
branch
from
382bf03
to
d6c7dc2
Compare
pazone
approved these changes
Apr 30, 2024
dliappis
added
backport-v7.17.0
mergify bot
pushed a commit
that referenced
this pull request
Apr 30, 2024
As things are now we allow parallel builds on the packaging pipeline, which could result in out of order artifacts (depending on which one takes longer to finish). This commit implements two "queues" (snapshot/staging) to ensure ordered builds of DRA artifacts. Relates https://github.com/elastic/ingest-dev/issues/3095 (cherry picked from commit d275f27) # Conflicts: # .buildkite/packaging.pipeline.yml
mergify bot
pushed a commit
that referenced
this pull request
Apr 30, 2024
As things are now we allow parallel builds on the packaging pipeline, which could result in out of order artifacts (depending on which one takes longer to finish). This commit implements two "queues" (snapshot/staging) to ensure ordered builds of DRA artifacts. Relates https://github.com/elastic/ingest-dev/issues/3095 (cherry picked from commit d275f27) # Conflicts: # .buildkite/packaging.pipeline.yml
mergify bot
pushed a commit
that referenced
this pull request
Apr 30, 2024
As things are now we allow parallel builds on the packaging pipeline, which could result in out of order artifacts (depending on which one takes longer to finish). This commit implements two "queues" (snapshot/staging) to ensure ordered builds of DRA artifacts. Relates https://github.com/elastic/ingest-dev/issues/3095 (cherry picked from commit d275f27)
This was referenced Apr 30, 2024
dliappis
added a commit
that referenced
this pull request
Apr 30, 2024
As things are now we allow parallel builds on the packaging pipeline, which could result in out of order artifacts (depending on which one takes longer to finish). This commit implements two "queues" (snapshot/staging) to ensure ordered builds of DRA artifacts. Relates https://github.com/elastic/ingest-dev/issues/3095 (cherry picked from commit d275f27) Co-authored-by: Dimitrios Liappis <dimitrios.liappis@gmail.com>
pazone
pushed a commit
that referenced
this pull request
Apr 30, 2024
As things are now we allow parallel builds on the packaging pipeline, which could result in out of order artifacts (depending on which one takes longer to finish). This commit implements two "queues" (snapshot/staging) to ensure ordered builds of DRA artifacts. Relates elastic/ingest-dev#3095
pazone
pushed a commit
that referenced
this pull request
Apr 30, 2024
As things are now we allow parallel builds on the packaging pipeline, which could result in out of order artifacts (depending on which one takes longer to finish). This commit implements two "queues" (snapshot/staging) to ensure ordered builds of DRA artifacts. Relates elastic/ingest-dev#3095
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
As things are now we allow parallel builds on the
packaging pipeline, which would result in out of order artifacts (depending on which one takes longer to finish).
This commit leverages a queue to ensure a FIFO queue for DRA artifacts using the design pattern in:
https://buildkite.com/blog/concurrency-gates
Related issues
Testing/Screenshots
Using the latest approach, I triggered two DRA
mainsnapshot builds in succession using the env vars:and was able to see the first one triggered proceed:
whereas the second one was paused (as desired) waiting for the snapshot concurrency group:
It would have been nice to trigger a staging build at the same time (which should allow one job at a time, since it's a different concurrency gate) but it's not easy given the conditionals.