-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include metricbeat modules directory into agentbeat build #39278
Include metricbeat modules directory into agentbeat build #39278
Conversation
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
❯ tree module
module
├── activemq
│ ├── broker
│ │ └── manifest.yml
│ ├── module.yml
│ ├── queue
│ │ └── manifest.yml
│ └── topic
│ └── manifest.yml
├── airflow
│ ├── module.yml
│ └── statsd
│ └── manifest.yml
├── apache
│ └── module.yml
├── aws
│ ├── dynamodb
│ │ └── manifest.yml
│ ├── ebs
│ │ └── manifest.yml
│ ├── ec2
│ │ └── manifest.yml
│ ├── elb
│ │ └── manifest.yml
│ ├── kinesis
│ │ └── manifest.yml
│ ├── lambda
│ │ └── manifest.yml
│ ├── module.yml
│ ├── natgateway
│ │ └── manifest.yml
│ ├── rds
│ │ └── manifest.yml
│ ├── s3_daily_storage
│ │ └── manifest.yml
│ ├── s3_request
│ │ └── manifest.yml
│ ├── sns
│ │ └── manifest.yml
│ ├── sqs
│ │ └── manifest.yml
│ ├── transitgateway
│ │ └── manifest.yml
│ ├── usage
│ │ └── manifest.yml
│ └── vpn
│ └── manifest.yml
├── azure
│ ├── app_state
│ │ └── manifest.yml
│ ├── compute_vm
│ │ └── manifest.yml
│ ├── compute_vm_scaleset
│ │ └── manifest.yml
│ ├── container_instance
│ │ └── manifest.yml
│ ├── container_registry
│ │ └── manifest.yml
│ ├── container_service
│ │ └── manifest.yml
│ ├── database_account
│ │ └── manifest.yml
│ └── module.yml
├── cloudfoundry
│ └── module.yml
├── cockroachdb
│ ├── module.yml
│ └── status
│ └── manifest.yml
├── docker
│ └── module.yml
├── enterprisesearch
│ └── module.yml
├── gcp
│ ├── compute
│ │ └── manifest.yml
│ ├── dataproc
│ │ └── manifest.yml
│ ├── firestore
│ │ └── manifest.yml
│ ├── gke
│ │ └── manifest.yml
│ ├── loadbalancing
│ │ └── manifest.yml
│ ├── module.yml
│ ├── pubsub
│ │ └── manifest.yml
│ └── storage
│ └── manifest.yml
├── golang
│ └── module.yml
├── haproxy
│ └── module.yml
├── ibmmq
│ ├── module.yml
│ └── qmgr
│ └── manifest.yml
├── iis
│ ├── module.yml
│ ├── webserver
│ │ └── manifest.yml
│ └── website
│ └── manifest.yml
├── istio
│ ├── istiod
│ │ └── manifest.yml
│ ├── module.yml
│ └── proxy
│ └── manifest.yml
├── kafka
│ ├── broker
│ │ └── manifest.yml
│ ├── consumer
│ │ └── manifest.yml
│ ├── module.yml
│ └── producer
│ └── manifest.yml
├── kubernetes
│ └── module.yml
├── mongodb
│ └── module.yml
├── mysql
│ ├── module.yml
│ └── performance
│ └── manifest.yml
├── nats
│ └── module.yml
├── nginx
│ └── module.yml
├── rabbitmq
│ └── module.yml
├── redis
│ └── module.yml
├── redisenterprise
│ ├── module.yml
│ ├── node
│ │ └── manifest.yml
│ └── proxy
│ └── manifest.yml
├── stan
│ └── module.yml
├── system
│ └── module.yml
├── tomcat
│ ├── cache
│ │ └── manifest.yml
│ ├── memory
│ │ └── manifest.yml
│ ├── module.yml
│ ├── requests
│ │ └── manifest.yml
│ └── threading
│ └── manifest.yml
├── uwsgi
│ └── module.yml
├── vsphere
│ └── module.yml
└── windows
└── module.yml
79 directories, 79 files
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
mg.SerialDeps(Update, osquerybeat.FetchOsqueryDistros, CrossBuildDeps, CrossBuild, devtools.Package, TestPackages) | ||
// Add metricbeat lightweight modules. | ||
if err := metricbeat.CustomizeLightModulesPackaging(); err != nil { | ||
return err |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to wrap this error to add more context about what failed.
(cherry picked from commit 8c48989)
Proposed commit message
Fixes issue where
module
directory from metricbeat was not included into theagentbeat
build.module
directory is required for metricbeat lightweight modules to work.Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry inCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues