Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the annotating for snapshot and staging #39299

Merged
merged 2 commits into from Apr 30, 2024
Merged

Fix the annotating for snapshot and staging #39299

merged 2 commits into from Apr 30, 2024

Conversation

alexsapran
Copy link
Contributor

Proposed commit message

This commit adds the --append flag to the buildkite-annotate so that when it is called by the snapshot and staging steps will not overwrite the other annotation.

@alexsapran
Fix the annotating for snapshot and staging
1e3064b 
This commit adds the `--append` flag to the buildkite-annotate so that
when it is called by the snapshot and staging steps will not overwrite
the other annotation.

Signed-off-by: Alexandros Sapranidis <alexandros@elastic.co>
@alexsapran alexsapran added ci backport-v7.17.0 Automated backport with mergify backport-v8.13.0 Automated backport with mergify Team:Ingest-EngProd backport-v8.14.0 Automated backport with mergify labels Apr 30, 2024
@alexsapran alexsapran self-assigned this Apr 30, 2024
@alexsapran alexsapran requested a review from a team as a code owner April 30, 2024 11:34
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Apr 30, 2024
dliappis
dliappis approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexsapran
Change the annotation text
2650447 
Signed-off-by: Alexandros Sapranidis <alexandros@elastic.co>
dliappis
dliappis approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexsapran alexsapran enabled auto-merge (squash) April 30, 2024 11:39
@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 30, 2024 •
edited

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 12 min 18 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@alexsapran alexsapran merged commit f6bad74 into elastic:main Apr 30, 2024
80 of 106 checks passed
mergify bot pushed a commit that referenced this pull request Apr 30, 2024
@alexsapran @mergify
Fix the annotating for snapshot and staging (#39299)
9a4bb95 
* Fix the annotating for snapshot and staging

This commit adds the `--append` flag to the buildkite-annotate so that
when it is called by the snapshot and staging steps, it will not overwrite
the other annotation.

Signed-off-by: Alexandros Sapranidis <alexandros@elastic.co>
(cherry picked from commit f6bad74)

# Conflicts:
#	.buildkite/scripts/dra.sh
mergify bot pushed a commit that referenced this pull request Apr 30, 2024
@alexsapran @mergify
Fix the annotating for snapshot and staging (#39299)
b112980 
* Fix the annotating for snapshot and staging

This commit adds the `--append` flag to the buildkite-annotate so that
when it is called by the snapshot and staging steps, it will not overwrite
the other annotation.

Signed-off-by: Alexandros Sapranidis <alexandros@elastic.co>
(cherry picked from commit f6bad74)

# Conflicts:
#	.buildkite/scripts/dra.sh
This was referenced Apr 30, 2024
Closed
Closed
mergify bot pushed a commit that referenced this pull request Apr 30, 2024
@alexsapran @mergify
Fix the annotating for snapshot and staging (#39299)
9d7898d 
* Fix the annotating for snapshot and staging

This commit adds the `--append` flag to the buildkite-annotate so that
when it is called by the snapshot and staging steps, it will not overwrite
the other annotation.

Signed-off-by: Alexandros Sapranidis <alexandros@elastic.co>
(cherry picked from commit f6bad74)
@mergify mergify bot mentioned this pull request Apr 30, 2024
Merged
alexsapran added a commit that referenced this pull request Apr 30, 2024
@mergify @alexsapran
[8.14](backport #39299) Fix the annotating for snapshot and staging (#…
6e0fabe 
…39308)

* Fix the annotating for snapshot and staging

This commit adds the `--append` flag to the buildkite-annotate so that
when it is called by the snapshot and staging steps, it will not overwrite
the other annotation.

Signed-off-by: Alexandros Sapranidis <alexandros@elastic.co>
(cherry picked from commit f6bad74)

Co-authored-by: Alexandros Sapranidis <alexandros@elastic.co>
pazone pushed a commit that referenced this pull request Apr 30, 2024
@alexsapran @pazone
Fix the annotating for snapshot and staging (#39299)
9c618bf 
* Fix the annotating for snapshot and staging

This commit adds the `--append` flag to the buildkite-annotate so that
when it is called by the snapshot and staging steps, it will not overwrite
the other annotation.

Signed-off-by: Alexandros Sapranidis <alexandros@elastic.co>
pazone pushed a commit that referenced this pull request Apr 30, 2024
@alexsapran @pazone
Fix the annotating for snapshot and staging (#39299)
b6f7a90 
* Fix the annotating for snapshot and staging

This commit adds the `--append` flag to the buildkite-annotate so that
when it is called by the snapshot and staging steps, it will not overwrite
the other annotation.

Signed-off-by: Alexandros Sapranidis <alexandros@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dliappis dliappis dliappis approved these changes

Assignees

@alexsapran alexsapran

Labels
backport-v7.17.0 Automated backport with mergify backport-v8.13.0 Automated backport with mergify backport-v8.14.0 Automated backport with mergify ci Team:Ingest-EngProd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexsapran @elasticmachine @dliappis