Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly set DOCKER_PULL, RACE_DETECTOR and TEST_COVERAGE for pipelines #39510

Merged
merged 4 commits into from
May 10, 2024
Merged

Explicitly set DOCKER_PULL, RACE_DETECTOR and TEST_COVERAGE for pipelines #39510

merged 4 commits into from
May 10, 2024

Conversation

pazone
Copy link
Contributor

@pazone pazone commented May 10, 2024 •
edited

Proposed commit message

Explicitly set DOCKER_PULL , RACE_DETECTOR and TEST_COVERAGE variables for pipelines
The previous approach is unobvious and error-prone

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Relates https://github.com/elastic/ingest-dev/issues/3303

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 10, 2024
@mergify mergify bot assigned pazone May 10, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented May 10, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @pazone? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@pazone pazone marked this pull request as ready for review May 10, 2024 10:50
@pazone pazone requested a review from a team as a code owner May 10, 2024 10:50
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label May 10, 2024
@pazone pazone changed the title Explicitly set RACE_DETECTOR and TEST_COVERAGE for pipelines Explicitly set DOCKER_PULL, RACE_DETECTOR and TEST_COVERAGE for pipelines May 10, 2024
@pazone pazone added backport-v7.17.0 Automated backport with mergify backport-v8.13.0 Automated backport with mergify backport-v8.14.0 Automated backport with mergify labels May 10, 2024
dliappis
dliappis reviewed May 10, 2024
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add those definitions in the deploy/k8s pipeline: https://github.com/elastic/beats/blob/main/.buildkite/deploy/kubernetes/deploy-k8s-pipeline.yml ?

@pazone
Copy link
Contributor Author

pazone commented May 10, 2024

Should we also add those definitions in the deploy/k8s pipeline: https://github.com/elastic/beats/blob/main/.buildkite/deploy/kubernetes/deploy-k8s-pipeline.yml ?

There are no go tests

@dliappis dliappis self-requested a review May 10, 2024 16:47
dliappis
dliappis approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pazone pazone enabled auto-merge (squash) May 10, 2024 16:48
@pazone pazone merged commit c773028 into main May 10, 2024
108 checks passed
@pazone pazone deleted the ci_unit_test_env_vars branch May 10, 2024 18:06
mergify bot pushed a commit that referenced this pull request May 10, 2024
@pazone @mergify
Explicitly set DOCKER_PULL, RACE_DETECTOR and TEST_COVERAGE for pipel…
4eb21e7 
…ines (#39510)

* Explicitly set RACE_DETECTOR and TEST_COVERAGE for pipelines

* Moved DOCKER_PULL var to winlogonbeat pipeline

* added xpack/heartbeat

(cherry picked from commit c773028)
mergify bot pushed a commit that referenced this pull request May 10, 2024
@pazone @mergify
Explicitly set DOCKER_PULL, RACE_DETECTOR and TEST_COVERAGE for pipel…
5381b9a 
…ines (#39510)

* Explicitly set RACE_DETECTOR and TEST_COVERAGE for pipelines

* Moved DOCKER_PULL var to winlogonbeat pipeline

* added xpack/heartbeat

(cherry picked from commit c773028)
mergify bot pushed a commit that referenced this pull request May 10, 2024
@pazone @mergify
Explicitly set DOCKER_PULL, RACE_DETECTOR and TEST_COVERAGE for pipel…
d4222be 
…ines (#39510)

* Explicitly set RACE_DETECTOR and TEST_COVERAGE for pipelines

* Moved DOCKER_PULL var to winlogonbeat pipeline

* added xpack/heartbeat

(cherry picked from commit c773028)
This was referenced May 10, 2024
Merged
Merged
@mergify mergify bot mentioned this pull request May 10, 2024
Merged
6 tasks
pazone added a commit that referenced this pull request May 14, 2024
@mergify @pazone
Explicitly set DOCKER_PULL, RACE_DETECTOR and TEST_COVERAGE for pipel…
7267343 
…ines (#39510) (#39519)

* Explicitly set RACE_DETECTOR and TEST_COVERAGE for pipelines

* Moved DOCKER_PULL var to winlogonbeat pipeline

* added xpack/heartbeat

(cherry picked from commit c773028)

Co-authored-by: Pavel Zorin <pavel.zorin@elastic.co>
pazone added a commit that referenced this pull request May 14, 2024
@mergify @pazone
Explicitly set DOCKER_PULL, RACE_DETECTOR and TEST_COVERAGE for pipel…
b5f3690 
…ines (#39510) (#39518)

* Explicitly set RACE_DETECTOR and TEST_COVERAGE for pipelines

* Moved DOCKER_PULL var to winlogonbeat pipeline

* added xpack/heartbeat

(cherry picked from commit c773028)

Co-authored-by: Pavel Zorin <pavel.zorin@elastic.co>
pazone added a commit that referenced this pull request May 15, 2024
@mergify @pazone
Explicitly set DOCKER_PULL, RACE_DETECTOR and TEST_COVERAGE for pipel…
1eedfac 
…ines (#39510) (#39520)

* Explicitly set RACE_DETECTOR and TEST_COVERAGE for pipelines

* Moved DOCKER_PULL var to winlogonbeat pipeline

* added xpack/heartbeat

(cherry picked from commit c773028)

Co-authored-by: Pavel Zorin <pavel.zorin@elastic.co>
v1v added a commit to v1v/beats that referenced this pull request May 15, 2024
@v1v
Merge remote-tracking branch 'upstream/main' into feature/check-on-gh…
4c5e0d6 
…-actions

* upstream/main: (313 commits)
  github-action: delete opentelemetry workflow (elastic#39559)
  updatecli: move to the .github folder and support for signed commits (elastic#39472)
  Osquerybeat: Add action responses data stream (elastic#39143)
  [winlogbeat] performance improvment; avoid rendering event message twice (elastic#39544)
  Fix the AWS SDK dependencies issue causing the "not found, ResolveEndpointV2" error (elastic#39454)
  x-pack/filebeat/input/cel: add http metrics collection (elastic#39503)
  build(deps): bump github.com/elastic/elastic-agent-libs from 0.9.4 to 0.9.7 (elastic#39424)
  Remove unused env vars from pipelines (elastic#39534)
  [BK] - Remove osx steps from branch execution (elastic#39552)
  [BK] - Remove certain steps from running for Branches (elastic#39533)
  Allow dependabot report BK status checks (elastic#39540)
  Remove hardcoded module definitions in CI (elastic#39506)
  Explicitly set DOCKER_PULL, RACE_DETECTOR and TEST_COVERAGE for pipelines (elastic#39510)
  Fixed pipelines formatting (elastic#39513)
  Update filebeat pipeline to match Jenkins steps (elastic#39261)
  Add error check to groupToEvents so we don't blindly add error values (elastic#39404)
  Remove fields not needed for session view in add_session_view processor (elastic#39500)
  `aws-s3` input: Split S3 poller and SQS reader into explicit input objects (elastic#39353)
  ci(jenkins): remove post-build notifications (elastic#39483)
  [DOCS] Add the `read_pipeline` cluster privilege for winlogbeat and the `auto_configure` index privilege to beats documentation (elastic#38534)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dliappis dliappis dliappis approved these changes

Assignees

@pazone pazone

Labels
backport-v7.17.0 Automated backport with mergify backport-v8.13.0 Automated backport with mergify backport-v8.14.0 Automated backport with mergify enhancement Team:Ingest-EngProd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pazone @dliappis @jlind23