Remove verbose debug logs from acker #39672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belimawr
added
skip-ci
botelastic
bot
added
the
needs_team
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
botelastic
bot
removed
the
needs_team
Remove some debug log entries about acked events. Those log entries turn out to be very verbose and of very little use. They do not carry any information about the acked events, and we already have metrics about acked events in the 30s metrics and monitoring HTTP endpoint.
belimawr
force-pushed
the
remove-acker-debug-logs
branch
from
63b421d
to
944820b
Compare
cmacknz
approved these changes
May 22, 2024
mergify bot
pushed a commit
that referenced
this pull request
May 23, 2024
Remove some debug log entries about acked events. Those log entries turn out to be very verbose and of very little use. They do not carry any information about the acked events, and we already have metrics about acked events in the 30s metrics and monitoring HTTP endpoint. (cherry picked from commit 62b4c18)
6 tasks
belimawr
added a commit
that referenced
this pull request
May 23, 2024
Remove some debug log entries about acked events. Those log entries turn out to be very verbose and of very little use. They do not carry any information about the acked events, and we already have metrics about acked events in the 30s metrics and monitoring HTTP endpoint. (cherry picked from commit 62b4c18) Co-authored-by: Tiago Queiroz <tiago.queiroz@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Remove some debug log entries about acked events. Those log entries turn out to be very verbose and of very little use. They do not carry any information about the acked events, and we already have metrics about acked events in the 30s metrics and monitoring HTTP endpoint.
Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.## Disruptive User Impact## Author's ChecklistHow to test this PR locally
filestreamorloginput configured and debug logs enabled (at least theackerselector)stateful ack ...orstateless ack ...messages are logged## Related issues## Use cases## Screenshots## Logs