Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Metricbeat: set AWS region to terraform.tf #39675

Merged
merged 3 commits into from
May 23, 2024
Merged

[CI] Metricbeat: set AWS region to terraform.tf #39675

merged 3 commits into from
May 23, 2024

Conversation

pazone
Copy link
Contributor

@pazone pazone commented May 22, 2024 •
edited
Loading

Proposed commit message

  1. We have been using the default AWS region (eu-cental-1). However, the build agents are located in us-east.
    The PR sets AWS region to us-east-1.
  2. Changed DB instance class to db.t3.micro. The previous db.t2 is now has depreceted MySQL support.
  3. Un-skipped x-pack/metricbeat Cloud (MODULE) Tests

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@pazone pazone requested a review from a team as a code owner May 22, 2024 19:38
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 22, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label May 22, 2024
@pazone pazone added ci needs_team Indicates that the issue/PR needs a Team:* label labels May 22, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label May 22, 2024
@botelastic
Copy link

botelastic bot commented May 22, 2024

This pull request doesn't have a Team:<team> label.

@mergify mergify bot assigned pazone May 22, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented May 22, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @pazone? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@pazone pazone added backport-v8.14.0 Automated backport with mergify backport-v7.17.0 Automated backport with mergify labels May 22, 2024
@pazone pazone added the aws Enable builds in the CI for aws cloud testing label May 23, 2024
@pazone
Copy link
Contributor Author

pazone commented May 23, 2024

/test

@pazone pazone requested a review from a team as a code owner May 23, 2024 15:14
dliappis
dliappis approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! If CI is green let's close https://github.com/elastic/ingest-dev/issues/3170 which this PR also fixes via the instance_class change.

@pazone pazone enabled auto-merge (squash) May 23, 2024 15:40
@pazone pazone disabled auto-merge May 23, 2024 16:07
@pazone pazone enabled auto-merge (squash) May 23, 2024 16:10
@pazone pazone merged commit 44679fb into main May 23, 2024
18 checks passed
@pazone pazone deleted the ci_set_aws_az branch May 23, 2024 16:42
mergify bot pushed a commit that referenced this pull request May 23, 2024
@pazone @mergify
[CI] Metricbeat: set AWS region to terraform.tf (#39675)
63735c2 
* [CI] Metricbeat: set AWS region to terraform.tf

* Cleanup

* Fix DB instance type

(cherry picked from commit 44679fb)
@mergify mergify bot mentioned this pull request May 23, 2024
Merged
6 tasks
mergify bot pushed a commit that referenced this pull request May 23, 2024
@pazone @mergify
[CI] Metricbeat: set AWS region to terraform.tf (#39675)
bdda45a 
* [CI] Metricbeat: set AWS region to terraform.tf

* Cleanup

* Fix DB instance type

(cherry picked from commit 44679fb)
@mergify mergify bot mentioned this pull request May 23, 2024
Merged
6 tasks
pazone added a commit that referenced this pull request May 24, 2024
@mergify @pazone
[CI] Metricbeat: set AWS region to terraform.tf (#39675) (#39702)
efd7847 
* [CI] Metricbeat: set AWS region to terraform.tf

* Cleanup

* Fix DB instance type

(cherry picked from commit 44679fb)

Co-authored-by: Pavel Zorin <pavel.zorin@elastic.co>
pazone added a commit that referenced this pull request May 24, 2024
@mergify @pazone
[CI] Metricbeat: set AWS region to terraform.tf (#39675) (#39701)
44b02fe 
* [CI] Metricbeat: set AWS region to terraform.tf

* Cleanup

* Fix DB instance type

(cherry picked from commit 44679fb)

Co-authored-by: Pavel Zorin <pavel.zorin@elastic.co>
@oakrizan oakrizan added the backport-v8.13.0 Automated backport with mergify label Jun 5, 2024
mergify bot pushed a commit that referenced this pull request Jun 5, 2024
@pazone @mergify
[CI] Metricbeat: set AWS region to terraform.tf (#39675)
25d2ea7 
* [CI] Metricbeat: set AWS region to terraform.tf

* Cleanup

* Fix DB instance type

(cherry picked from commit 44679fb)
@mergify mergify bot mentioned this pull request Jun 5, 2024
Merged
6 tasks
oakrizan pushed a commit that referenced this pull request Jun 5, 2024
@mergify @pazone
[CI] Metricbeat: set AWS region to terraform.tf (#39675) (#39812)
d234136 
[CI] Metricbeat: set AWS region to terraform.tf & Fix DB instance type

(cherry picked from commit 44679fb)

Co-authored-by: Pavel Zorin <pavel.zorin@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dliappis dliappis dliappis approved these changes

@alexsapran alexsapran alexsapran approved these changes

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

Assignees

@pazone pazone

Labels
aws Enable builds in the CI for aws cloud testing backport-v7.17.0 Automated backport with mergify backport-v8.13.0 Automated backport with mergify backport-v8.14.0 Automated backport with mergify ci enhancement Team:Ingest-EngProd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pazone @dliappis @alexsapran @kaiyan-sheng @oakrizan